Skip to contentSkip to conversation

travis: Use kernel.org pre-built toolchain for riscv

PATCH In review Bin Meng 3 participants 9 messages Aug 30, 2018 – Sep 6, 2018 1 message not in the archive

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/1 travis: Use kernel.org pre-built toolchain for riscv

This updates travis configuration to use kernel.org pre-built toolchain for riscv.

---

 .travis.yml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
.travis.yml +2 -3
index 4db629d..95cfa5b 100644
@@ -87,9 +87,8 @@ before_script:
     fi
   - if [[ "${TOOLCHAIN}" == "powerpc" ]]; then ./tools/buildman/buildman --fetch-arch powerpc; fi
   - if [[ "${TOOLCHAIN}" == "riscv" ]]; then
-        wget https://github.com/andestech/prebuilt/releases/download/20180530/riscv64-unknown-linux-gnu.tar.gz &&
-        tar -C /tmp -xf riscv64-unknown-linux-gnu.tar.gz &&
-        echo -e "\n[toolchain-prefix]\nriscv = /tmp/riscv64-unknown-linux-gnu/bin/riscv64-unknown-linux-gnu-" >> ~/.buildman;
+       ./tools/buildman/buildman --fetch-arch riscv64;
+       echo -e "\n[toolchain-alias]\nriscv = riscv64" >> ~/.buildman;
     fi
   - if [[ "${QEMU_TARGET}" != "" ]]; then
        git clone git://git.qemu.org/qemu.git /tmp/qemu;
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/1 travis: Use kernel.org pre-built toolchain for riscv

Hi Tom,

Quoted 10 lines · Bin Meng

This updates travis configuration to use kernel.org pre-built toolchain for riscv.

---

 .travis.yml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Since this is travis-ci changes, can we take this for v2018.09? I've verified that it works well for current riscv build on travis-ci.org.

Regards,
Bin

#2 lore raw

PATCH 1/1 travis: Use kernel.org pre-built toolchain for riscv

Quoted 10 lines · Bin Meng

Hi Tom,

Quoted 7 lines · Bin Meng

This updates travis configuration to use kernel.org pre-built toolchain for riscv.

---

Quoted 6 lines
Quoted 3 lines
 .travis.yml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Since this is travis-ci changes, can we take this for v2018.09? I've verified that it works well for current riscv build on travis-ci.org.

Seeing as things are still working before this change I would like to see an ack from the custodian, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180903/f051bcd3/attachment.sig>
author
#3 lore raw

PATCH 1/1 travis: Use kernel.org pre-built toolchain for riscv

Hi Rick,

Quoted 16 lines · Tom Rini
Quoted 14 lines · Bin Meng

Hi Tom,

Quoted 10 lines · Bin Meng

This updates travis configuration to use kernel.org pre-built toolchain for riscv.

---

 .travis.yml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Quoted 5 lines
Quoted 2 lines

Since this is travis-ci changes, can we take this for v2018.09? I've verified that it works well for current riscv build on travis-ci.org.

Seeing as things are still working before this change I would like to see an ack from the custodian, thanks!

Are you OK with this?

Regards,
Bin

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

PATCH 1/1 travis: Use kernel.org pre-built toolchain for riscv

Quoted 17 lines

From: Tom Rini [mailto:trini at konsulko.com]
Sent: Tuesday, September 04, 2018 3:24 AM
To: Bin Meng
Cc: U-Boot Mailing List; Rick Jian-Zhi Chen(陳建志)
Subject: Re: [PATCH] travis: Use kernel.org pre-built toolchain for riscv

Quoted 10 lines · Bin Meng

Hi Tom,

Quoted 7 lines · Bin Meng

This updates travis configuration to use kernel.org pre-built toolchain for riscv.

---

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
 .travis.yml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Since this is travis-ci changes, can we take this for v2018.09? I've verified that it works well for current riscv build on travis-ci.org.

Seeing as things are still working before this change I would like

to see an ack

Quoted 4 lines

from the custodian, thanks!

--
Tom

Hi Bin

I think lt is a positive way to use kernel.org pre-built toolchain for code coverage.
And very agree with that.

But there is a problem, it maybe encounter in the future. If I or someone try to add a private csr which the public toolchain may not recognize it.
How shall it be overcomed ? Do you have any ideas ?

Rick

author
#6 lore raw

PATCH 1/1 travis: Use kernel.org pre-built toolchain for riscv

Hi Rick,

Quoted 34 lines · Rick Chen
Quoted 18 lines

From: Tom Rini [mailto:trini at konsulko.com]
Sent: Tuesday, September 04, 2018 3:24 AM
To: Bin Meng
Cc: U-Boot Mailing List; Rick Jian-Zhi Chen(陳建志)
Subject: Re: [PATCH] travis: Use kernel.org pre-built toolchain for riscv

Quoted 10 lines · Bin Meng

Hi Tom,

Quoted 7 lines · Bin Meng

This updates travis configuration to use kernel.org pre-built toolchain for riscv.

---

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
 .travis.yml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Since this is travis-ci changes, can we take this for v2018.09? I've verified that it works well for current riscv build on travis-ci.org.

Seeing as things are still working before this change I would like

to see an ack

Quoted 4 lines

from the custodian, thanks!

--
Tom

Hi Bin

Quoted 7 lines

I think lt is a positive way to use kernel.org pre-built toolchain for code coverage.
And very agree with that.

But there is a problem, it maybe encounter in the future. If I or someone try to add a private csr which the public toolchain may not recognize it.

I assume what you said "private" csr means "vendor-specific" csr that is not defined by the risc-v ISA?

Quoted 1 line

How shall it be overcomed ? Do you have any ideas ?

I believe this shall be implemented properly by the toolchain itself. Or we hardcode the instruction for such "private" csr if there is no good solution from the toolchain side. Having a custom toolchain seems not a good idea.

Regards,
Bin

author
#7 lore raw

PATCH 1/1 travis: Use kernel.org pre-built toolchain for riscv

Hi Rick,

Quoted 49 lines · Bin Meng

Hi Rick,

Quoted 34 lines · Rick Chen
Quoted 18 lines

From: Tom Rini [mailto:trini at konsulko.com]
Sent: Tuesday, September 04, 2018 3:24 AM
To: Bin Meng
Cc: U-Boot Mailing List; Rick Jian-Zhi Chen(陳建志)
Subject: Re: [PATCH] travis: Use kernel.org pre-built toolchain for riscv

Quoted 10 lines · Bin Meng

Hi Tom,

Quoted 7 lines · Bin Meng

This updates travis configuration to use kernel.org pre-built toolchain for riscv.

---

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
 .travis.yml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Since this is travis-ci changes, can we take this for v2018.09? I've verified that it works well for current riscv build on travis-ci.org.

Seeing as things are still working before this change I would like

to see an ack

Quoted 4 lines

from the custodian, thanks!

--
Tom

Hi Bin

Quoted 7 lines

I think lt is a positive way to use kernel.org pre-built toolchain for code coverage.
And very agree with that.

But there is a problem, it maybe encounter in the future. If I or someone try to add a private csr which the public toolchain may not recognize it.

I assume what you said "private" csr means "vendor-specific" csr that is not defined by the risc-v ISA?

Quoted 6 lines
Quoted 1 line

How shall it be overcomed ? Do you have any ideas ?

I believe this shall be implemented properly by the toolchain itself. Or we hardcode the instruction for such "private" csr if there is no good solution from the toolchain side. Having a custom toolchain seems not a good idea.

I did not see a confirmative response on whether this patch is OK. Can you please comment, and if no issue I hope this can catch up the train of upcoming release :)

Regards,
Bin

#8 lore raw

PATCH 1/1 travis: Use kernel.org pre-built toolchain for riscv

Bin Meng <[email protected]> 於 2018年9月6日 週四 上午9:43寫道:

Quoted 59 lines

Hi Rick,

Quoted 55 lines · Bin Meng

Hi Rick,

Quoted 34 lines · Rick Chen
Quoted 18 lines

From: Tom Rini [mailto:trini at konsulko.com]
Sent: Tuesday, September 04, 2018 3:24 AM
To: Bin Meng
Cc: U-Boot Mailing List; Rick Jian-Zhi Chen(陳建志)
Subject: Re: [PATCH] travis: Use kernel.org pre-built toolchain for riscv

Quoted 10 lines · Bin Meng

Hi Tom,

Quoted 7 lines · Bin Meng

This updates travis configuration to use kernel.org pre-built toolchain for riscv.

---

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
 .travis.yml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Since this is travis-ci changes, can we take this for v2018.09? I've verified that it works well for current riscv build on travis-ci.org.

Seeing as things are still working before this change I would like

to see an ack

Quoted 4 lines

from the custodian, thanks!

--
Tom

Hi Bin

Quoted 7 lines

I think lt is a positive way to use kernel.org pre-built toolchain for code coverage.
And very agree with that.

But there is a problem, it maybe encounter in the future. If I or someone try to add a private csr which the public toolchain may not recognize it.

I assume what you said "private" csr means "vendor-specific" csr that is not defined by the risc-v ISA?

Quoted 1 line

How shall it be overcomed ? Do you have any ideas ?

I believe this shall be implemented properly by the toolchain itself. Or we hardcode the instruction for such "private" csr if there is no good solution from the toolchain side. Having a custom toolchain seems not a good idea.

Hi Bin

Agree with you, maybe I shall consider to isolate the vendor-specific code with CONFIG_XXX.

Quoted 5 lines

I did not see a confirmative response on whether this patch is OK. Can you please comment, and if no issue I hope this can catch up the train of upcoming release :)

Hi Tom

I think it is OK to pull this change into the master. Hope everything goes fine :)

Rick

Quoted 2 lines

Regards,
Bin

#9 lore raw
In reply to Bin Meng
Quoted 4 lines · Bin Meng

This updates travis configuration to use kernel.org pre-built toolchain for riscv.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180906/ff0253d1/attachment.sig>