Skip to contentSkip to conversation

interconnect: core: Fix uninitialized variable

PATCH New Gustavo A. R. Silva 1 participant 1 message Sep 6, 2018 Interconnect API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 interconnect: core: Fix uninitialized variable

There is a potential execution path in which variable *ret* is returned without being properly initialized previously.

Fix this by initializing variable *ret* to -EINVAL.

Addresses-Coverity-ID: 1473202 ("Uninitialized scalar variable")

Fixes 81b4cdb447fe ("interconnect: Add generic on-chip interconnect API")
---
 drivers/interconnect/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/interconnect/core.c +1 -1
index 2740f1a..ea5245f 100644
@@ -227,7 +227,7 @@ static int aggregate_requests(struct icc_node *node)
 static int apply_constraints(struct icc_path *path)
 {
 	struct icc_node *next, *prev = NULL;
-	int ret;
+	int ret = -EINVAL;
 	int i;
 
 	for (i = 0; i < path->num_nodes; i++, prev = next) {
Signature · 1 line
2.7.4