leds: pwm: silently error out on EPROBE_DEFER
PATCH 1/1 leds: pwm: silently error out on EPROBE_DEFER
When probing, if we fail to get the pwm due to probe deferal, we shouldn't print an error message. Just be silent in this case.
--- drivers/leds/leds-pwm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/leds/leds-pwm.c +3 -2
@@ -100,8 +100,9 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, led_data->pwm =devm_pwm_get (dev, led->name);if (IS_ERR (led_data->pwm)) { ret =PTR_ERR (led_data->pwm); -dev_err (dev,"unable to request PWM for %s: %d\n" , - led->name, ret); +if (ret != -EPROBE_DEFER ) +dev_err (dev,"unable to request PWM for %s: %d\n" , + led->name, ret);return ret; }
Signature · 1 line
2.17.1
Quoted 13 lines · Jerome Brunet
When probing, if we fail to get the pwm due to probe deferal, we shouldn't print an error message. Just be silent in this case.
Signed-off-by Jerome Brunet <[email protected]>--- drivers/leds/leds-pwm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/leds/leds-pwm.c +0
-0
drivers/leds/leds-pwm.c static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, · line 107
Quoted 10 lines
drivers/leds/leds-pwm.c +3
-2@@ -100,8 +100,9 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, led_data->pwm =devm_pwm_get (dev, led->name);if (IS_ERR (led_data->pwm)) { ret =PTR_ERR (led_data->pwm); -dev_err (dev,"unable to request PWM for %s: %d\n" , - led->name, ret); +if (ret != -EPROBE_DEFER ) +dev_err (dev,"unable to request PWM for %s: %d\n" , + led->name, ret);return ret; }
Hmm, sometimes probing is deffered forever, and in such case debug message is useful.
Do you see excessive number of these?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 28 lines · Pavel Machek
Quoted 13 lines · Jerome Brunet
When probing, if we fail to get the pwm due to probe deferal, we shouldn't print an error message. Just be silent in this case.
Signed-off-by Jerome Brunet <[email protected]>--- drivers/leds/leds-pwm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/leds/leds-pwm.c +0
-0drivers/leds/leds-pwm.c static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, · line 107
Quoted 10 lines
drivers/leds/leds-pwm.c +3
-2@@ -100,8 +100,9 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, led_data->pwm =devm_pwm_get (dev, led->name);if (IS_ERR (led_data->pwm)) { ret =PTR_ERR (led_data->pwm); -dev_err (dev,"unable to request PWM for %s: %d\n" , - led->name, ret); +if (ret != -EPROBE_DEFER ) +dev_err (dev,"unable to request PWM for %s: %d\n" , + led->name, ret);return ret; }Hmm, sometimes probing is deffered forever, and in such case debug message is useful.
Quoted 1 line
Do you see excessive number of these?
About 10 but displaying an error which is not error is already excessive IMO.
There is nothing out of the ordinary here. Feel free to grep git log for EPROBE_DEFER. Many drivers take this into account from the beginning now and we've been fixing others in most subsystem.
Quoted 2 lines
Pavel
Jacek Anaszewski
AppliedHi Jerome,
Thank you for the patch.
Quoted 15 lines · Jerome Brunet
When probing, if we fail to get the pwm due to probe deferal, we shouldn't print an error message. Just be silent in this case.
Signed-off-by Jerome Brunet <[email protected]>--- drivers/leds/leds-pwm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/leds/leds-pwm.c +0
-0@@ -100,8 +100,9 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, led_data->pwm =devm_pwm_get (dev, led->name);
drivers/leds/leds-pwm.c static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, · line 108
Quoted 10 lines
drivers/leds/leds-pwm.c +3
-2if (IS_ERR (led_data->pwm)) { ret =PTR_ERR (led_data->pwm); -dev_err (dev,"unable to request PWM for %s: %d\n" , - led->name, ret); +if (ret != -EPROBE_DEFER ) +dev_err (dev,"unable to request PWM for %s: %d\n" , + led->name, ret);return ret; }
Applied.
Signature · 2 lines
Best regards, Jacek Anaszewski