Skip to contentSkip to conversation

dt-bindings: fpga: fix freeze controller compatible in region doc

PATCH Applied Alan Tull 3 participants 4 messages Sep 6, 2018 – Sep 25, 2018

Subsystems (2)
lore
Share & tools
lore

Alan Tull

author
#0 lore raw

PATCH 1/1 dt-bindings: fpga: fix freeze controller compatible in region doc

Documentation/devicetree/bindings/fpga/fpga-region.txt has an error regarding the freeze controller bridge, secifically:

compatible = "altr,freeze-bridge";

The compatibility string should be "altr,freeze-bridge-controller" as set forth in altera-freeze-bridge.txt.

---
 Documentation/devicetree/bindings/fpga/fpga-region.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/fpga/fpga-region.txt +2 -2
index 6db8aed..90c4469 100644
@@ -415,7 +415,7 @@ DT Overlay contains:
 			firmware-name = "base.rbf";
 
 			fpga-bridge@4400 {
-				compatible = "altr,freeze-bridge";
+				compatible = "altr,freeze-bridge-controller";
 				reg = <0x4400 0x10>;
 
 				fpga_region1: fpga-region1 {
@@ -427,7 +427,7 @@ DT Overlay contains:
 			};
 
 			fpga-bridge@4420 {
-				compatible = "altr,freeze-bridge";
+				compatible = "altr,freeze-bridge-controller";
 				reg = <0x4420 0x10>;
 
 				fpga_region2: fpga-region2 {
Signature · 1 line
2.7.4
maintainer Acked-by on v1 1/1
#1 lore raw

Hi Alan,

looks like it's just the examples, right? So not sure someone would be affected by that, yet?

Quoted 9 lines · Alan Tull

Documentation/devicetree/bindings/fpga/fpga-region.txt has an error regarding the freeze controller bridge, secifically:

compatible = "altr,freeze-bridge";

The compatibility string should be "altr,freeze-bridge-controller" as set forth in altera-freeze-bridge.txt.

Cheers,

Moritz

author
#2 lore raw
Quoted 4 lines · Moritz Fischer

Hi Alan,

looks like it's just the examples, right?

Yes, it's in the examples of use, not the actual freeze bridge bindings doc that I'm correcting.

Quoted 2 lines

So not sure someone
would be affected by that, yet?

It's taken two years for anybody to notice and complain about it :) so the effect has not been very terrible. But it's good to correct it since it's been noticed.

Quoted 10 lines · Alan Tull
Quoted 8 lines

Documentation/devicetree/bindings/fpga/fpga-region.txt has an error regarding the freeze controller bridge, secifically:

compatible = "altr,freeze-bridge";

The compatibility string should be "altr,freeze-bridge-controller" as set forth in altera-freeze-bridge.txt.

Quoted 7 lines
Quoted 1 line

Cheers,

Moritz

Thanks Moritz!

Alan

maintainer Applied
#3 lore raw
In reply to Alan Tull
Quoted 5 lines · Alan Tull

Documentation/devicetree/bindings/fpga/fpga-region.txt has an error regarding the freeze controller bridge, secifically:

compatible = "altr,freeze-bridge";

Quoted 8 lines

The compatibility string should be "altr,freeze-bridge-controller" as set forth in altera-freeze-bridge.txt.

---
 Documentation/devicetree/bindings/fpga/fpga-region.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied.

Rob