usb: typec: don't disable sink or source on initialization
Subsystems (4)
PATCH 1/1 usb: typec: don't disable sink or source on initialization
If the board is being powered by USB disabling the source and sink can remove power from the board. Default to source and sink enabled.
--- drivers/usb/typec/tcpm.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/usb/typec/tcpm.c +5 -3
@@ -2462,9 +2462,11 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret; - ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; +/* default to source and sink enabled in case USB is our only power +* source */ + ret = port->tcpc->set_vbus (port->tcpc, true, true); + port->vbus_source = true; + port->vbus_charge = true;return ret; }
Hello!
Quoted 13 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Default to source and sink enabled.
Signed-off-by Angus Ainslie (Purism) <[email protected]>--- drivers/usb/typec/tcpm.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)drivers/usb/typec/tcpm.c +0
-0
drivers/usb/typec/tcpm.c static int tcpm_init_vbus(struct tcpm_port *port) · line 2466
Quoted 8 lines
drivers/usb/typec/tcpm.c +2
-3@@ -2462,9 +2462,11 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret; - ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; +/* default to source and sink enabled in case USB is our only power +* source */
The multi-line comments should look like this:
/*
* bla
* bla
*/
[...]
MBR, Sergei
Heikki Krogerus
maintainer+Guenter
Quoted 26 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Default to source and sink enabled.
Signed-off-by Angus Ainslie (Purism) <[email protected]>--- drivers/usb/typec/tcpm.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)drivers/usb/typec/tcpm.c +5
-3@@ -2462,9 +2462,11 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret; - ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; +/* default to source and sink enabled in case USB is our only power +* source */ + ret = port->tcpc->set_vbus (port->tcpc, true, true); + port->vbus_source = true; + port->vbus_charge = true;return ret; }
Quoted 6 lines · Heikki Krogerus
+Guenter
Quoted 3 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Default to source and sink enabled.
Seems to me that might violate the specification, and cause trouble for systems where vbus has to be off initially. It may be better to provide this kind of information as configuration parameter instead of imposing it on everyone.
Guenter
Quoted 13 lines
Quoted 13 lines
Signed-off-by Angus Ainslie (Purism) <[email protected]>--- drivers/usb/typec/tcpm.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)drivers/usb/typec/tcpm.c +0
-0@@ -2462,9 +2462,11 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret;
Quoted 5 lines
drivers/usb/typec/tcpm.c static int tcpm_init_vbus(struct tcpm_port *port) · line 2466
Quoted 5 lines
drivers/usb/typec/tcpm.c +2
-3- ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; +/* default to source and sink enabled in case USB is our only power +* source */
I am personally in favor of standard multi-line comments.
Quoted 6 lines
Quoted 5 lines
drivers/usb/typec/tcpm.c +3
-0+ ret = port->tcpc->set_vbus (port->tcpc, true, true); + port->vbus_source = true; + port->vbus_charge = true;return ret; }
Hi Guenter
Quoted 9 lines · Guenter Roeck
Quoted 7 lines · Heikki Krogerus
+Guenter
Quoted 3 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Default to source and sink enabled.
Quoted 7 lines
Seems to me that might violate the specification, and cause trouble for systems
where vbus has to be off initially. It may be better to provide this kind of
information as configuration parameter instead of imposing it on everyone.
It felt like it would not be the correct thing to do either. I've tried re-arranging the code in tcpci.c to enable the sink before disabling the source but the only way I found to not disable the power was by setting both of those to true.
What about adding some device tree entries for the initial vbus state and default to false if they are not present ?
init-vbus-source and init-vbus-charge ?
Angus
Quoted 29 lines
Guenter
Quoted 5 lines
Quoted 5 lines
Signed-off-by Angus Ainslie (Purism) <[email protected]>--- drivers/usb/typec/tcpm.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)Quoted 13 lines
drivers/usb/typec/tcpm.c static int tcpm_init_vbus(struct tcpm_port · line 2467
Quoted 13 lines
drivers/usb/typec/tcpm.c +2
-2@@ -2462,9 +2462,11 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret; - ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; +/* default to source and sink enabled in case USB is our only power +* source */ I am personally in favor of standard multi-line comments.
Quoted 6 lines
Quoted 5 lines
drivers/usb/typec/tcpm.c +3
-0+ ret = port->tcpc->set_vbus (port->tcpc, true, true); + port->vbus_source = true; + port->vbus_charge = true;return ret; }
Quoted 16 lines · Angus Ainslie
Hi Guenter
Quoted 12 lines · Guenter Roeck
Quoted 6 lines · Heikki Krogerus
+Guenter
Quoted 3 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Default to source and sink enabled.
Seems to me that might violate the specification, and cause trouble for systems where vbus has to be off initially. It may be better to provide this kind of information as configuration parameter instead of imposing it on everyone.
Quoted 6 lines
It felt like it would not be the correct thing to do either. I've tried re-arranging the code in
tcpci.cto enable the sink before disabling the source but the only way I found to not disable the power was by setting both of those to true.What about adding some device tree entries for the initial vbus state and default to false if they are not present ?
init-vbus-source and init-vbus-charge ?
Yes, I think we should do something along that line. Another question is if we could or should optionally pull the current state from the low level driver, but that may be secondary.
Thanks,
Guenter
Quoted 32 lines
Angus
Quoted 28 lines
Guenter
Quoted 5 lines
Quoted 5 lines
Signed-off-by Angus Ainslie (Purism) <[email protected]>---
drivers/usb/typec/tcpm.c| 8 +++++---1 file changed, 5 insertions(+), 3 deletions(-)Quoted 12 lines
drivers/usb/typec/tcpm.c static int tcpm_init_vbus(struct tcpm_port *port) · line 2466
Quoted 12 lines
drivers/usb/typec/tcpm.c +2
-2@@ -2462,9 +2462,11 @@ static int tcpm_init_vbus(struct tcpm_port *port) { int ret; - ret = port->tcpc->set_vbus(port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + /* default to source and sink enabled in case USB is our only power +* source */ I am personally in favor of standard multi-line comments.
Quoted 6 lines
Quoted 5 lines
drivers/usb/typec/tcpm.c +3
-0+ ret = port->tcpc->set_vbus(port->tcpc, true, true); + port->vbus_source = true; + port->vbus_charge = true; return ret; }
Quoted 30 lines · Guenter Roeck
Quoted 29 lines · Angus Ainslie
Hi Guenter
Quoted 10 lines · Guenter Roeck
Quoted 8 lines · Heikki Krogerus
+Guenter
Quoted 4 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Default to source and sink enabled.
Quoted 7 lines
Seems to me that might violate the specification, and cause trouble for systems
where vbus has to be off initially. It may be better to provide this kind of
information as configuration parameter instead of imposing it on everyone.It felt like it would not be the correct thing to do either. I've tried re-arranging the code in
tcpci.cto enable the sink before disabling the source but the only way I found to not disable the power was by setting both of those to true.What about adding some device tree entries for the initial vbus state and default to false if they are not present ?
Quoted 9 lines
Quoted 2 lines
init-vbus-source and init-vbus-charge ?
Yes, I think we should do something along that line. Another question is
if we could or should optionally pull the current state from the low level
driver, but that may be secondary.
I thought of trying to do that but from reading the "PTN5110N PD PHY application programming guide" there didn't seem to be a direct way to read those parameters.
Quoted 37 lines
Thanks,
GuenterQuoted 34 lines
Angus
Quoted 30 lines
Guenter
Quoted 5 lines
Quoted 5 lines
Signed-off-by Angus Ainslie (Purism) <[email protected]>---
drivers/usb/typec/tcpm.c| 8 +++++---1 file changed, 5 insertions(+), 3 deletions(-)Quoted 14 lines
Quoted 12 lines
drivers/usb/typec/tcpm.c +1
-2@@ -2462,9 +2462,11 @@ static int tcpm_init_vbus(struct tcpm_port *port) { int ret; - ret = port->tcpc->set_vbus(port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + /* default to source and sink enabled in case USB is our onlyQuoted 2 lines
power
+ * source */I am personally in favor of standard multi-line comments.
Quoted 6 lines
Quoted 5 lines
+ ret =
port->tcpc->set_vbus(port->tcpc, true, true); +port->vbus_source= true;
+port->vbus_charge= true;
return ret;
}
Quoted 25 lines · Angus Ainslie
Quoted 24 lines · Guenter Roeck
Quoted 22 lines · Angus Ainslie
Hi Guenter
Quoted 12 lines · Guenter Roeck
Quoted 6 lines · Heikki Krogerus
+Guenter
Quoted 3 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Default to source and sink enabled.
Seems to me that might violate the specification, and cause trouble for systems where vbus has to be off initially. It may be better to provide this kind of information as configuration parameter instead of imposing it on everyone.
It felt like it would not be the correct thing to do either. I've tried re-arranging the code in
tcpci.cto enable the sink before disabling the source but the only way I found to not disable the power was by setting both of those to true.What about adding some device tree entries for the initial vbus state and default to false if they are not present ?
init-vbus-source and init-vbus-charge ?
Quoted 7 lines
Quoted 4 lines
Yes, I think we should do something along that line. Another question is if we could or should optionally pull the current state from the low level driver, but that may be secondary.
I thought of trying to do that but from reading the "PTN5110N PD PHY application programming guide" there didn't seem to be a direct way to read those parameters.
Let's put that on the backburner (maybe it works for some other chips) and go with the devicetree property for now.
Guenter
Quoted 37 lines
Quoted 35 lines
Thanks,
GuenterQuoted 32 lines
Angus
Quoted 28 lines
Guenter
Quoted 5 lines
Quoted 5 lines
Signed-off-by Angus Ainslie (Purism) <[email protected]>---
drivers/usb/typec/tcpm.c| 8 +++++---1 file changed, 5 insertions(+), 3 deletions(-)Quoted 12 lines
drivers/usb/typec/tcpm.c static int tcpm_init_vbus(struct tcpm_port *port) · line 2466
Quoted 12 lines
drivers/usb/typec/tcpm.c +2
-2@@ -2462,9 +2462,11 @@ static int tcpm_init_vbus(struct tcpm_port *port) { int ret; - ret = port->tcpc->set_vbus(port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + /* default to source and sink enabled in case USB is our only power +* source */ I am personally in favor of standard multi-line comments.
Quoted 6 lines
Quoted 5 lines
drivers/usb/typec/tcpm.c +3
-0+ ret = port->tcpc->set_vbus(port->tcpc, true, true); + port->vbus_source = true; + port->vbus_charge = true; return ret; }
PATCH v2 1/1 usb: typec: get the vbus source and charge values from the devicetree
In reply to Angus Ainslie (Purism)If the board is being powered by USB disabling the source and sink can remove power from the board. Allow the source and sink to be initallized based on devicetree values.
Changed since V1:
use devicetree values instead of hardcoded initialization.
--- .../bindings/connector/usb-connector.txt | 4 ++++ drivers/usb/typec/tcpm.c | 14 +++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/connector/usb-connector.txt +4 -0
@@ -22,6 +22,10 @@ Optional properties for usb-c-connector: or Try.SRC, should be "sink" for Try.SNK or "source" for Try.SRC. - data-role: should be one of "host", "device", "dual"(DRD) if typec connector supports USB data. +- init-vbus-source: set the initalization value for vbus-source to true. + If this property is not present the initial value will be false. +- init-vbus-charge: set the initalization value for vbus-charge to true. + If this property is not present the initial value will be false. Required properties for usb-c-connector with power delivery support: - source-pdos: An array of u32 with each entry providing supported power
drivers/usb/typec/tcpm.c +11 -3
@@ -2462,9 +2462,7 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret; - ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + ret = port->tcpc->set_vbus (port->tcpc, port->vbus_source, port->vbus_charge);return ret; }
@@ -4266,6 +4264,16 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,return -EINVAL ; port->port_type = port->typec_caps.type; +if (fwnode_property_present (fwnode,"init-vbus-source" )) + port->vbus_source = true; +else + port->vbus_source = false; + +if (fwnode_property_present (fwnode,"init-vbus-charge" )) + port->vbus_charge = true; +else + port->vbus_charge = false; +if (port->port_type ==TYPEC_PORT_SNK ) goto sink;
Re: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree
Quoted 19 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Allow the source and sink to be initallized based on devicetree values.
Changed since V1:
use devicetree values instead of hardcoded initialization.
Signed-off-by Angus Ainslie (Purism) <[email protected]>--- .../bindings/connector/usb-connector.txt | 4 ++++ drivers/usb/typec/tcpm.c | 14 +++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/connector/usb-connector.txt +0
-0
Documentation/devicetree/bindings/connector/usb-connector.txt Optional properties for usb-c-connector: · line 29
Quoted 8 lines
Documentation/devicetree/bindings/connector/usb-connector.txt +4
-0@@ -22,6 +22,10 @@ Optional properties for usb-c-connector: or Try.SRC, should be "sink" for Try.SNK or "source" for Try.SRC. - data-role: should be one of "host", "device", "dual"(DRD) if typec connector supports USB data. +- init-vbus-source: set the initalization value for vbus-source to true. + If this property is not present the initial value will be false. +- init-vbus-charge: set the initalization value for vbus-charge to true. + If this property is not present the initial value will be false.
This change will require DT maintainer approval.
Thanks,
Guenter
Quoted 34 lines
Documentation/devicetree/bindings/connector/usb-connector.txt +0
-0Required properties for usb-c-connector with power delivery support: - source-pdos: An array of u32 with each entry providing supported powerdrivers/usb/typec/tcpm.c +11
-3@@ -2462,9 +2462,7 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret; - ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + ret = port->tcpc->set_vbus (port->tcpc, port->vbus_source, port->vbus_charge);return ret; }@@ -4266,6 +4264,16 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,return -EINVAL ; port->port_type = port->typec_caps.type; +if (fwnode_property_present (fwnode,"init-vbus-source" )) + port->vbus_source = true; +else + port->vbus_source = false; + +if (fwnode_property_present (fwnode,"init-vbus-charge" )) + port->vbus_charge = true; +else + port->vbus_charge = false; +if (port->port_type ==TYPEC_PORT_SNK ) goto sink;
Re: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree
In reply to Angus Ainslie (Purism)+Mark
+Rob
Quoted 67 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Allow the source and sink to be initallized based on devicetree values.
Changed since V1:
use devicetree values instead of hardcoded initialization.
Signed-off-by Angus Ainslie (Purism) <[email protected]>--- .../bindings/connector/usb-connector.txt | 4 ++++ drivers/usb/typec/tcpm.c | 14 +++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-)diff --git
a/Documentation/devicetree/bindings/connector/usb-connector.txtb/Documentation/devicetree/bindings/connector/usb-connector.txtindex8855bfcfd778..afe851a713c3100644Documentation/devicetree/bindings/connector/usb-connector.txt +1
-0@@ -22,6 +22,10 @@ Optional properties for usb-c-connector: or Try.SRC, should be "sink" for Try.SNK or "source" for Try.SRC. - data-role: should be one of "host", "device", "dual"(DRD) if typec connector supports USB data. +- init-vbus-source: set the initalization value for vbus-source totrue.
+ If this property is not present the initial value will be false. +- init-vbus-charge: set the initalization value for vbus-charge to true.
+ If this property is not present the initial value will be false.Required properties for usb-c-connector with power delivery support:
- source-pdos: An array of u32 with each entry providing supported
powerdrivers/usb/typec/tcpm.c +11
-3@@ -2462,9 +2462,7 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret; - ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + ret = port->tcpc->set_vbus (port->tcpc, port->vbus_source, port->vbus_charge);return ret; }@@ -4266,6 +4264,16 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, return -EINVAL ; port->port_type = port->typec_caps.type; +if (fwnode_property_present (fwnode,"init-vbus-source" )) + port->vbus_source = true; +else + port->vbus_source = false; + +if (fwnode_property_present (fwnode,"init-vbus-charge" )) + port->vbus_charge = true; +else + port->vbus_charge = false; +if (port->port_type ==TYPEC_PORT_SNK ) goto sink;
Heikki Krogerus
maintainerRe: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree
In reply to Angus Ainslie (Purism)Quoted 19 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Allow the source and sink to be initallized based on devicetree values.
Changed since V1:
use devicetree values instead of hardcoded initialization.
Signed-off-by Angus Ainslie (Purism) <[email protected]>--- .../bindings/connector/usb-connector.txt | 4 ++++ drivers/usb/typec/tcpm.c | 14 +++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/connector/usb-connector.txt +0
-0
Documentation/devicetree/bindings/connector/usb-connector.txt Optional properties for usb-c-connector: · line 28
Quoted 7 lines
Documentation/devicetree/bindings/connector/usb-connector.txt +4
-0@@ -22,6 +22,10 @@ Optional properties for usb-c-connector: or Try.SRC, should be "sink" for Try.SNK or "source" for Try.SRC. - data-role: should be one of "host", "device", "dual"(DRD) if typec connector supports USB data. +- init-vbus-source: set the initalization value for vbus-source to true. + If this property is not present the initial value will be false. +- init-vbus-charge: set the initalization value for vbus-charge to true. + If this property is not present the initial value will be false.
If you put the description of those properties here, you are going to need to rename them. Those describe tcpm specific properties, but to that file you want to put descriptions of generic properties.
Your problem is that you can not cope with a lose of VBUS as a sink, right? For that you just need one boolean device property IMO. Something like depend-on-vbus.
Quoted 36 lines
Documentation/devicetree/bindings/connector/usb-connector.txt +0
-0Required properties for usb-c-connector with power delivery support: - source-pdos: An array of u32 with each entry providing supported powerdrivers/usb/typec/tcpm.c +11
-3@@ -2462,9 +2462,7 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret; - ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + ret = port->tcpc->set_vbus (port->tcpc, port->vbus_source, port->vbus_charge);return ret; }@@ -4266,6 +4264,16 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,return -EINVAL ; port->port_type = port->typec_caps.type; +if (fwnode_property_present (fwnode,"init-vbus-source" )) + port->vbus_source = true; +else + port->vbus_source = false; + +if (fwnode_property_present (fwnode,"init-vbus-charge" )) + port->vbus_charge = true; +else + port->vbus_charge = false; +if (port->port_type ==TYPEC_PORT_SNK ) goto sink;Signature · 1 line
2.17.1
Thanks,
Re: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree
Hi Heikki
Quoted 28 lines · Heikki Krogerus
Quoted 27 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Allow the source and sink to be initallized based on devicetree values.
Changed since V1:
use devicetree values instead of hardcoded initialization.
Signed-off-by Angus Ainslie (Purism) <[email protected]>--- .../bindings/connector/usb-connector.txt | 4 ++++ drivers/usb/typec/tcpm.c | 14 +++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-)(quoted diff) +0
-0
a/Documentation/devicetree/bindings/connector/usb-connector.txtb/Documentation/devicetree/bindings/connector/usb-connector.txtindex8855bfcfd778..afe851a713c3100644Documentation/devicetree/bindings/connector/usb-connector.txt +1
-0@@ -22,6 +22,10 @@ Optional properties for usb-c-connector: or Try.SRC, should be "sink" for Try.SNK or "source" for Try.SRC. - data-role: should be one of "host", "device", "dual"(DRD) if typec connector supports USB data. +- init-vbus-source: set the initalization value for vbus-source totrue.
Quoted 9 lines
Quoted 4 lines
+ If this property is not present the initial value will be false. +- init-vbus-charge: set the initalization value for vbus-charge to true.
+ If this property is not present the initial value will be false.If you put the description of those properties here, you are going to need to rename them. Those describe tcpm specific properties, but to that file you want to put descriptions of generic properties.
They are tcpm specific but need to go into the connector sub-node to get parsed correctly. Would something like below be better ?
ptn5110@50 {Quoted 3 lines
Your problem is that you can not cope with a lose of VBUS as a sink, right? For that you just need one boolean device property IMO. Something like depend-on-vbus.
I thought that it would better to be able to control each independently. With my specific hardware I need both defaulted to true but for another piece of HW just being able to control one of them might be sufficient.
Thanks
Angus
Quoted 39 lines
Quoted 39 lines
Required properties for usb-c-connector with power delivery support:
- source-pdos: An array of u32 with each entry providing supported
powerdrivers/usb/typec/tcpm.c +1
-3@@ -2462,9 +2462,7 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret; - ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + ret = port->tcpc->set_vbus (port->tcpc, port->vbus_source, port->vbus_charge);return ret;}
drivers/usb/typec/tcpm.c +10
-0@@ -4266,6 +4264,16 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, return -EINVAL ; port->port_type = port->typec_caps.type; +if (fwnode_property_present (fwnode,"init-vbus-source" )) + port->vbus_source = true; +else + port->vbus_source = false; + +if (fwnode_property_present (fwnode,"init-vbus-charge" )) + port->vbus_charge = true; +else + port->vbus_charge = false; +if (port->port_type ==TYPEC_PORT_SNK ) goto sink;
Quoted 4 lines
Quoted 2 lines
--
2.17.1Thanks,
(quoted diff) +0 -0
b/Documentation/devicetree/bindings/usb/typec-tcpci.txt index 0dd1469e7318..ae0a3e97d9b6 100644
Documentation/devicetree/bindings/usb/typec-tcpci.txt +2 -0
@@ -15,6 +15,12 @@ Required sub-node: of connector node are specified in Documentation/devicetree/bindings/connector/usb-connector.txt +Optional properties for usb-c-connector sub-node: +- init-vbus-source: set the initalization value for vbus-source to
true.
+ If this property is not present the initial value will be false. +- init-vbus-charge: set the initalization value for vbus-charge to true.
+ If this property is not present the initial value will be false. +
Example:
Re: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree
Quoted 54 lines · Angus Ainslie
Hi Heikki
Quoted 15 lines · Heikki Krogerus
Quoted 14 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Allow the source and sink to be initallized based on devicetree values.
Changed since V1:
use devicetree values instead of hardcoded initialization.
Signed-off-by Angus Ainslie (Purism) <[email protected]>---
.../bindings/connector/usb-connector.txt | 4 ++++ drivers/usb/typec/tcpm.c | 14 +++++++++++---2 files changed, 15 insertions(+), 3 deletions(-)Quoted 17 lines
Quoted 5 lines
Documentation/devicetree/bindings/connector/usb-connector.txt +0
-0@@ -22,6 +22,10 @@ Optional properties for usb-c-connector:Quoted 7 lines
or Try.SRC, should be "sink" for Try.SNK or "source" for Try.SRC.
- data-role: should be one of "host", "device", "dual"(DRD) if typec connector supports USB data.
+- init-vbus-source: set the initalization value for vbus-source to true. + If this property is not present the initial value will be false. +- init-vbus-charge: set the initalization value for vbus-charge to true. + If this property is not present the initial value will be false.If you put the description of those properties here, you are going to need to rename them. Those describe tcpm specific properties, but to that file you want to put descriptions of generic properties.
They are tcpm specific but need to go into the connector sub-node to get parsed correctly. Would something like below be better ?
Documentation/devicetree/bindings/usb/typec-tcpci.txt +0
-0@@ -15,6 +15,12 @@ Required sub-node:of connector node are specified in
Documentation/devicetree/bindings/connector/usb-connector.txtDocumentation/devicetree/bindings/usb/typec-tcpci.txt +6
-0+Optional properties for usb-c-connector sub-node: +- init-vbus-source: set the initalization value for vbus-source to true. + If this property is not present the initial value will be false. +- init-vbus-charge: set the initalization value for vbus-charge to true. + If this property is not present the initial value will be false. +Example:
Quoted 9 lines
ptn5110@50 {
Quoted 3 lines
Your problem is that you can not cope with a lose of VBUS as a sink, right? For that you just need one boolean device property IMO. Something like depend-on-vbus.
I thought that it would better to be able to control each independently. With my specific hardware I need both defaulted to true but for another piece of HW just being able to control one of them might be sufficient.
Turns out the problem goes deeper: Only one of the two values is supposed to be true at any given time. The system is either a sink (vbus_charge=true) or a source (vbus_src=true), but it can not be both.
I think we first need to figure out what actually happens in your system; the result from setting both values to true is that the initial request to set vbus (either as source or as sink) should fail, unless the value is actually cleared and the other value (supposed to be untouched) is set. This does not make sense and warrants further debugging. Can you do that and let us know what exactly actually happens and why your hardware needs that request to fail ?
Thanks,
Guenter
Quoted 44 lines
Thanks
AngusQuoted 39 lines
Quoted 37 lines
Required properties for usb-c-connector with power delivery support:
- source-pdos: An array of u32 with each entry providing supported powerdrivers/usb/typec/tcpm.c +11
-3@@ -2462,9 +2462,7 @@ static int tcpm_init_vbus(struct tcpm_port *port) { int ret; - ret = port->tcpc->set_vbus(port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + ret = port->tcpc->set_vbus(port->tcpc, port->vbus_source, port->vbus_charge); return ret; }@@ -4266,6 +4264,16 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, return -EINVAL; port->port_type = port->typec_caps.type; + if (fwnode_property_present(fwnode, "init-vbus-source")) + port->vbus_source = true; + else + port->vbus_source = false; + + if (fwnode_property_present(fwnode, "init-vbus-charge")) + port->vbus_charge = true; + else + port->vbus_charge = false; + if (port->port_type == TYPEC_PORT_SNK) goto sink;Signature · 1 line
2.17.1Thanks,
Re: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree
Quoted 79 lines · Guenter Roeck
Quoted 68 lines · Angus Ainslie
Hi Heikki
Quoted 30 lines · Heikki Krogerus
Quoted 28 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Allow the source and sink to be initallized based on devicetree values.
Changed since V1:
use devicetree values instead of hardcoded initialization.
Signed-off-by Angus Ainslie (Purism) <[email protected]>---
.../bindings/connector/usb-connector.txt | 4 ++++ drivers/usb/typec/tcpm.c | 14
+++++++++++---2 files changed, 15 insertions(+), 3 deletions(-)(quoted diff) +0
-0
a/Documentation/devicetree/bindings/connector/usb-connector.txtb/Documentation/devicetree/bindings/connector/usb-connector.txtindex8855bfcfd778..afe851a713c3100644Documentation/devicetree/bindings/connector/usb-connector.txt +0
-0@@ -22,6 +22,10 @@ Optional properties for usb-c-connector:or Try.SRC, should be "sink" for Try.SNK or "source" for Try.SRC.
- data-role: should be one of "host", "device", "dual"(DRD) if typec
connector supports USB data.
+- init-vbus-source: set the initalization value for vbus-source to true.Quoted 9 lines
Quoted 4 lines
+ If this property is not present the initial value will be false. +- init-vbus-charge: set the initalization value for vbus-charge to true.
+ If this property is not present the initial value will be false.If you put the description of those properties here, you are going to need to rename them. Those describe tcpm specific properties, but to that file you want to put descriptions of generic properties.
They are tcpm specific but need to go into the connector sub-node to get parsed correctly. Would something like below be better ?
Documentation/devicetree/bindings/usb/typec-tcpci.txt +0
-0@@ -15,6 +15,12 @@ Required sub-node:of connector node are specified in
Documentation/devicetree/bindings/connector/usb-connector.txt+Optional properties for usb-c-connector sub-node:
+- init-vbus-source: set the initalization value for vbus-source to true.
+ If this property is not present the initial value will be false. +- init-vbus-charge: set the initalization value for vbus-charge to true.
+ If this property is not present the initial value will be false. +
Example:ptn5110@50 {
Quoted 9 lines
Quoted 3 lines
Your problem is that you can not cope with a lose of VBUS as a sink, right? For that you just need one boolean device property IMO. Something like depend-on-vbus.
I thought that it would better to be able to control each independently. With my specific hardware I need both defaulted to true but for another piece of HW just being able to control one of them might be sufficient.
Quoted 6 lines
Turns out the problem goes deeper: Only one of the two values is supposed to
be true at any given time. The system is either a sink (vbus_charge=true)
or a source (vbus_src=true), but it can not be both.
I agree but my hardware is being obstinant.
Quoted 4 lines
I think we first need to figure out what actually happens in your system; the
result from setting both values to true is that the initial request to set vbus
Quoted 9 lines
(either as source or as sink) should fail, unless the value is actually cleared
and the other value (supposed to be untouched) is set. This does not make
sense and warrants further debugging. Can you do that and let us know what
exactly actually happens and why your hardware needs that request to fail ?
Neither call fails at the software level.
[ 3.762504] (NULL device *): tcpci drivers/usb/typec/tcpci.c tcpci_register_port 557 [ 3.830968] tcpci 0-0052: tcpci drivers/usb/typec/tcpci.c tcpci_parse_config 534 [ 3.849299] tcpci 0-0052: tcpci drivers/usb/typec/tcpci.c tcpci_init 400 [ 3.872283] tcpci 0-0052: tcpci drivers/usb/typec/tcpci.c tcpci_set_pd_rx 265 [ 3.879952] tcpci 0-0052: tcpci drivers/usb/typec/tcpci.c tcpci_set_vbus 297 source 1 sink 1 [ 3.879957] tcpci 0-0052: tcpci set source drivers/usb/typec/tcpci.c tcpci_set_vbus 327 [ 3.916407] tcpci 0-0052: tcpci set sink drivers/usb/typec/tcpci.c
tcpci_set_vbus 340
When the source gets disabled is when the board loses power.
[ 3.762504] (NULL device *): tcpci drivers/usb/typec/tcpci.c tcpci_register_port 557 [ 3.770603] tcpci 0-0052: tcpci drivers/usb/typec/tcpci.c tcpci_parse_config 534 [ 3.789508] tcpci 0-0052: tcpci drivers/usb/typec/tcpci.c tcpci_init 400 [ 3.799676] tcpci 0-0052: tcpci drivers/usb/typec/tcpci.c tcpci_set_pd_rx 265 [ 3.809322] tcpci 0-0052: tcpci drivers/usb/typec/tcpci.c tcpci_set_vbus 297 source 0 sink 1 [ 3.817956] tcpci 0-0052: tcpci disable source
drivers/usb/typec/tcpci.c tcpci_set_vbus 302
< board stops booting here>
I've added these prints for debugging
@@ -275,36 +293,64 @@ static int tcpci_set_vbus(struct tcpc_dev *tcpc, bool source, bool sink)
struct tcpci *tcpci = tcpc_to_tcpci(tcpc);
int ret;- /* Disable both source and sink first before enabling anything
*/
+ dev_err(tcpci->dev, "tcpci %s %s %d source %d sink %d\n" ,__FILE__,
+ __func__, __LINE__, source, sink );
+ /* Disable both source and sink first before enabling anything
*/
if (!source) {
+ dev_err(tcpci->dev, "tcpci disable source %s %s %d\n" ,
__FILE__,
+ __func__, __LINE__ );
ret = regmap_write(tcpci->regmap, TCPC_COMMAND,
TCPC_CMD_DISABLE_SRC_VBUS);- if (ret < 0)
+ if (ret < 0) {
+ dev_err(tcpci->dev, "tcpci disable source failed
%s %s %d\n" , __FILE__,
+ __func__, __LINE__ );
return ret;
+ }
}
if (!sink) {+ dev_err(tcpci->dev, "tcpci disable sink %s %s %d\n" ,__FILE__,
+ __func__, __LINE__ );
+
ret = regmap_write(tcpci->regmap, TCPC_COMMAND,
TCPC_CMD_DISABLE_SINK_VBUS);- if (ret < 0)
+ if (ret < 0) {
+ dev_err(tcpci->dev, "tcpci disable sink failed
%s %s %d\n" , __FILE__,
+ __func__, __LINE__ );
return ret;
+ }
}
if (source) {+ dev_err(tcpci->dev, "tcpci set source %s %s %d\n" ,__FILE__,
+ __func__, __LINE__ );
+
ret = regmap_write(tcpci->regmap, TCPC_COMMAND,
TCPC_CMD_SRC_VBUS_DEFAULT);- if (ret < 0)
+ if (ret < 0) {
+ dev_err(tcpci->dev, "tcpci enable source failed
%s %s %d\n" , __FILE__,
+ __func__, __LINE__ );
return ret;
+ }
}
if (sink) {+ dev_err(tcpci->dev, "tcpci set sink %s %s %d\n" ,__FILE__,
+ __func__, __LINE__ );
+
ret = regmap_write(tcpci->regmap, TCPC_COMMAND,
TCPC_CMD_SINK_VBUS);- if (ret < 0)
+ if (ret < 0) {
+ dev_err(tcpci->dev, "tcpci enable sink failed %s
%s %d\n" , __FILE__,
+ __func__, __LINE__ );
return ret;
+ }
}+ dev_err(tcpci->dev, "tcpci %s %s %d source %d sink %d\n" ,__FILE__,
+ __func__, __LINE__, source, sink );
+
return 0;
}
Quoted 51 lines
Thanks,
GuenterQuoted 48 lines
Thanks
AngusQuoted 43 lines
Quoted 31 lines
Required properties for usb-c-connector with power delivery support:
- source-pdos: An array of u32 with each entry providing supported powerdrivers/usb/typec/tcpm.c +1
-3@@ -2462,9 +2462,7 @@ static int tcpm_init_vbus(struct tcpm_port *port) { int ret; - ret = port->tcpc->set_vbus(port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + ret = port->tcpc->set_vbus(port->tcpc, port->vbus_source, port->vbus_charge); return ret;}
drivers/usb/typec/tcpm.c +4
-0@@ -4266,6 +4264,16 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, return -EINVAL; port->port_type = port->typec_caps.type; + if (fwnode_property_present(fwnode, "init-vbus-source")) + port->vbus_source = true; + else + port->vbus_source = false;drivers/usb/typec/tcpm.c static int tcpm_fw_get_caps(struct tcpm_port
Quoted 10 lines
drivers/usb/typec/tcpm.c +6
-1+ + if (fwnode_property_present(fwnode, "init-vbus-charge")) + port->vbus_charge = true; + else + port->vbus_charge = false; + if (port->port_type == TYPEC_PORT_SNK) goto sink; -- 2.17.1Thanks,
Heikki Krogerus
maintainerRe: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree
In reply to Angus AinslieHi Angus,
Quoted 9 lines · Angus Ainslie
They are tcpm specific but need to go into the connector sub-node to get parsed correctly. Would something like below be better ?
Documentation/devicetree/bindings/usb/typec-tcpci.txt +0
-0
Documentation/devicetree/bindings/usb/typec-tcpci.txt Required sub-node: · line 22
Quoted 8 lines
Documentation/devicetree/bindings/usb/typec-tcpci.txt +5
-0@@ -15,6 +15,12 @@ Required sub-node: of connector node are specified in Documentation/devicetree/bindings/connector/usb-connector.txt +Optional properties for usb-c-connector sub-node: +- init-vbus-source: set the initalization value for vbus-source to true. + If this property is not present the initial value will be false. +- init-vbus-charge: set the initalization value for vbus-charge to true. + If this property is not present the initial value will be false.
In that file those are fine.
I would prefer init-vbus-sink over init-vbus-charge, but it's up to you.
Thanks,
PATCH v3 1/1 usb: typec: get the vbus source and charge values from the devicetree
In reply to Angus Ainslie (Purism)If the board is being powered by USB disabling the source and sink can remove power from the board. Allow the source and sink to be initallized based on devicetree values.
Changed since V2:
Change the devicetree documentation.
Change the devicetree property names.
Changed since V1:
use devicetree values instead of hardcoded initialization.
--- .../devicetree/bindings/usb/typec-tcpci.txt | 6 ++++++ drivers/usb/typec/tcpm.c | 14 +++++++++++--- 2 files changed, 17 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/usb/typec-tcpci.txt +6 -0
@@ -15,6 +15,12 @@ Required sub-node: of connector node are specified in Documentation/devicetree/bindings/connector/usb-connector.txt +Optional properties for usb-c-connector sub-node: +- init-vbus-source: set the initalization value for vbus-source to true. + If this property is not present the initial value will be false. +- init-vbus-sink: set the initalization value for vbus-sink to true. + If this property is not present the initial value will be false. + Example: ptn5110@50 {
drivers/usb/typec/tcpm.c +11 -3
@@ -2462,9 +2462,7 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret; - ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + ret = port->tcpc->set_vbus (port->tcpc, port->vbus_source, port->vbus_charge);return ret; }
@@ -4266,6 +4264,16 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,return -EINVAL ; port->port_type = port->typec_caps.type; +if (fwnode_property_present (fwnode,"init-vbus-source" )) + port->vbus_source = true; +else + port->vbus_source = false; + +if (fwnode_property_present (fwnode,"init-vbus-sink" )) + port->vbus_charge = true; +else + port->vbus_charge = false; +if (port->port_type ==TYPEC_PORT_SNK ) goto sink;
Re: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree
I cant put my finger on it but this seems wrong. As i said both src and sink should never be true at the same time. I also din’t understand why turning off src should power off your board. Ultimately my concern is that we may be just painting over the real problem, and that would be really bad to do with dt properties.
Note that sending to groeck7@ makes it hard for me to see your emails and to reply. Using [email protected] would be much better.
Guenter
Sent from my iPhone
Quoted 73 lines · Angus Ainslie (Purism)
If the board is being powered by USB disabling the source and sink can remove power from the board. Allow the source and sink to be initallized based on devicetree values.
Changed since V2:
Change the devicetree documentation.
Change the devicetree property names.Changed since V1:
use devicetree values instead of hardcoded initialization.
Signed-off-by Angus Ainslie (Purism) <[email protected]>---
.../devicetree/bindings/usb/typec-tcpci.txt| 6 ++++++drivers/usb/typec/tcpm.c| 14 +++++++++++---2 files changed, 17 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/usb/typec-tcpci.txt +6
-0@@ -15,6 +15,12 @@ Required sub-node: of connector node are specified in Documentation/devicetree/bindings/connector/usb-connector.txt +Optional properties for usb-c-connector sub-node: +- init-vbus-source: set the initalization value for vbus-source to true. + If this property is not present the initial value will be false. +- init-vbus-sink: set the initalization value for vbus-sink to true. + If this property is not present the initial value will be false. +Example:
ptn5110@50 {
drivers/usb/typec/tcpm.c +11
-3@@ -2462,9 +2462,7 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret; - ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + ret = port->tcpc->set_vbus (port->tcpc, port->vbus_source, port->vbus_charge);return ret; }@@ -4266,6 +4264,16 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,return -EINVAL ; port->port_type = port->typec_caps.type; +if (fwnode_property_present (fwnode,"init-vbus-source" )) + port->vbus_source = true; +else + port->vbus_source = false; + +if (fwnode_property_present (fwnode,"init-vbus-sink" )) + port->vbus_charge = true; +else + port->vbus_charge = false; +if (port->port_type ==TYPEC_PORT_SNK ) goto sink;Signature · 1 line
2.17.1
Re: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree
Quoted 6 lines · Guenter Roeck
I cant put my finger on it but this seems wrong. As i said both src and sink should never be true at the same time. I also din’t understand why turning off src should power off your board. Ultimately my concern is that we may be just painting over the real problem, and that would be really bad to do with dt properties.
I agree that this doesn't seem like the correct way of solving the problem. On this HW (Emcraft iMX8M BSB) I think the PTN5110 chip has been connected correctly so I'm assuming that it is some quirk of the PTN5110.
I didn't design the HW or the chip. This is a workaround for "quirky" hardware and there may be others that don't behave exactly as expected.
Quoted 3 lines
Note that sending to groeck7@ makes it hard for me to see your emails and to reply. Using [email protected] would be much better.
Ok, I think that email was grabbed from the driver source.
Quoted 83 lines
Guenter
Sent from my iPhone
Quoted 79 lines
On Sep 11, 2018, at 7:59 AM, Angus Ainslie (Purism) <[email protected]> wrote:
If the board is being powered by USB disabling the source and sink can remove power from the board. Allow the source and sink to be initallized based on devicetree values.
Changed since V2:
Change the devicetree documentation.
Change the devicetree property names.Changed since V1:
use devicetree values instead of hardcoded initialization.
Signed-off-by Angus Ainslie (Purism) <[email protected]>---
.../devicetree/bindings/usb/typec-tcpci.txt| 6 ++++++drivers/usb/typec/tcpm.c| 14 +++++++++++---2 files changed, 17 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/usb/typec-tcpci.txt +2
-0@@ -15,6 +15,12 @@ Required sub-node: of connector node are specified in Documentation/devicetree/bindings/connector/usb-connector.txt +Optional properties for usb-c-connector sub-node: +- init-vbus-source: set the initalization value for vbus-source totrue.
Documentation/devicetree/bindings/usb/typec-tcpci.txt +4
-0+ If this property is not present the initial value will be false. +- init-vbus-sink: set the initalization value for vbus-sink to true. + If this property is not present the initial value will be false. +Example:
ptn5110@50 {
drivers/usb/typec/tcpm.c +1
-3@@ -2462,9 +2462,7 @@ static int tcpm_init_vbus(struct tcpm_port *port) {int ret; - ret = port->tcpc->set_vbus (port->tcpc, false, false); - port->vbus_source = false; - port->vbus_charge = false; + ret = port->tcpc->set_vbus (port->tcpc, port->vbus_source, port->vbus_charge);return ret;}
drivers/usb/typec/tcpm.c +10
-1@@ -4266,6 +4264,16 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, return -EINVAL ; port->port_type = port->typec_caps.type; +if (fwnode_property_present (fwnode,"init-vbus-source" )) + port->vbus_source = true; +else + port->vbus_source = false; + +if (fwnode_property_present (fwnode,"init-vbus-sink" )) + port->vbus_charge = true; +else + port->vbus_charge = false; +if (port->port_type ==TYPEC_PORT_SNK ) goto sink; --2.17.1
Re: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree
Quoted 8 lines · Angus Ainslie
Quoted 6 lines · Guenter Roeck
I cant put my finger on it but this seems wrong. As i said both src and sink should never be true at the same time. I also din’t understand why turning off src should power off your board. Ultimately my concern is that we may be just painting over the real problem, and that would be really bad to do with dt properties.
Quoted 7 lines
I agree that this doesn't seem like the correct way of solving the problem. On this HW (Emcraft iMX8M BSB) I think the PTN5110 chip has been connected correctly so I'm assuming that it is some quirk of the PTN5110.
I didn't design the HW or the chip. This is a workaround for "quirky" hardware and there may be others that don't behave exactly as expected.
I wouldn't be that sure about that. It may as well be that the tcpc driver and/or the tcpm driver are doing something wrong when initializing.
I didn't really understand the logs you sent out earlier. It looked like the system would loose power if the TCPC_CMD_DISABLE_SRC_VBUS command is sent. That doesn't really make sense to me since it indicates that the chip sources power to the remote, and turning that off should not result in a local loss of power.
Note that the chip is supposed to be able to report if it is sourcing vbus and if VBUS is present, in the POWER_STATUS register. Another question is the content of the ROLE_CONTROL register when the system boots, and the DEVICE_CAPABILITIES settings.
Overall I suspect that we don't handle startup for your system correctly in the tcpc driver. The ideal solution would be to find a solution which does not require any devicetree properties, but to do that we'll need to get a better understanding about your system's requirements.
Guenter
Peter Chen
Acked-byRe: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree
Quoted 32 lines · Guenter Roeck
Quoted 8 lines · Angus Ainslie
Quoted 6 lines · Guenter Roeck
I cant put my finger on it but this seems wrong. As i said both src and sink should never be true at the same time. I also din’t understand why turning off src should power off your board. Ultimately my concern is that we may be just painting over the real problem, and that would be really bad to do with dt properties.
Quoted 7 lines
I agree that this doesn't seem like the correct way of solving the problem. On this HW (Emcraft iMX8M BSB) I think the PTN5110 chip has been connected correctly so I'm assuming that it is some quirk of the PTN5110.
I didn't design the HW or the chip. This is a workaround for "quirky" hardware and there may be others that don't behave exactly as expected.
I wouldn't be that sure about that. It may as well be that the tcpc driver and/or the tcpm driver are doing something wrong when initializing.
I didn't really understand the logs you sent out earlier. It looked like the system would loose power if the
TCPC_CMD_DISABLE_SRC_VBUScommand is sent. That doesn't really make sense to me since it indicates that the chip sources power to the remote, and turning that off should not result in a local loss of power.Note that the chip is supposed to be able to report if it is sourcing vbus and if VBUS is present, in the
POWER_STATUSregister. Another question is the content of theROLE_CONTROLregister when the system boots, and theDEVICE_CAPABILITIESsettings.
Quoted 6 lines
Overall I suspect that we don't handle startup for your system correctly in the tcpc driver. The ideal solution would be to find a solution which does not require any devicetree properties, but to do that we'll need to get a better understanding about your system's requirements.
Guenter
Hi Angus,
Would you please check if below patch can fix your issue?
staging: typec: don't do vbus source disable for dead battery
In PTN5110 design, DisableSourceVBUS command also disables the sink enable signal because the EN_SNK can be used to source higher voltage, and, there is only one TCPC command to disable sourcing voltage without telling whether to disable 5V or the high voltage, and to keep the design simple they designed the PTN5110 to disable both. with this fact, we use the flag drive_vbus to check if the source vbus enable was issued, if yes we then do vbus source disable, in dead battery case, we never did vbus source enable, so will not issue vbus source disable command.
--- drivers/staging/typec/tcpci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
if (ret < 0)
drivers/staging/typec/tcpci.c +0 -0
@@ -381,9 +381,8 @@ static int tcpci_set_vbus(struct tcpc_dev *tcpc,
bool source, bool sink)
struct tcpci *tcpci = tcpc_to_tcpci(tcpc);
int ret;
- /* Disable both source and sink first before enabling anything */ -
- if (!source) {
+ /* Only disable source if it was enabled */
+ if (!source && tcpci->drive_vbus) {
ret = regmap_write(tcpci->regmap, TCPC_COMMAND,
TCPC_CMD_DISABLE_SRC_VBUS);
Re: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree
Quoted 57 lines · Peter Chen
Quoted 40 lines · Guenter Roeck
Quoted 8 lines · Angus Ainslie
Quoted 6 lines · Guenter Roeck
I cant put my finger on it but this seems wrong. As i said both src and sink should never be true at the same time. I also din’t understand why turning off src should power off your board. Ultimately my concern is that we may be just painting over the real problem, and that would be really bad to do with dt properties.
Quoted 7 lines
I agree that this doesn't seem like the correct way of solving the problem. On this HW (Emcraft iMX8M BSB) I think the PTN5110 chip has been connected correctly so I'm assuming that it is some quirk of the PTN5110.
I didn't design the HW or the chip. This is a workaround for "quirky" hardware and there may be others that don't behave exactly as expected.
I wouldn't be that sure about that. It may as well be that the tcpc driver
and/or the tcpm driver are doing something wrong when initializing.I didn't really understand the logs you sent out earlier. It looked like
the system would loose power if theTCPC_CMD_DISABLE_SRC_VBUScommand is
sent. That doesn't really make sense to me since it indicates that the
chip sources power to the remote, and turning that off should not result
in a local loss of power.Note that the chip is supposed to be able to report if it is sourcing vbus
and if VBUS is present, in thePOWER_STATUSregister. Another question is
the content of theROLE_CONTROLregister when the system boots, and theDEVICE_CAPABILITIESsettings.Quoted 8 lines
Overall I suspect that we don't handle startup for your system correctly
in the tcpc driver. The ideal solution would be to find a solution which
does not require any devicetree properties, but to do that we'll need to get a better understanding about your system's requirements.Guenter
Hi Angus,
Would you please check if below patch can fix your issue?
staging: typec: don't do vbus source disable for dead battery
Quoted 10 lines
In PTN5110 design, DisableSourceVBUS command also disables the sink enable signal because the
EN_SNKcan be used to source higher voltage, and, there is only one TCPC command to disable sourcing voltage without telling whether to disable 5V or the high voltage, and to keep the design simple they designed the PTN5110 to disable both. with this fact, we use the flagdrive_vbusto check if the source vbus enable was issued, if yes we then do vbus source disable, in dead battery case, we never did vbus source enable, so will not issue vbus source disable command.
Thanks Peter, this sounds like the missing piece of information and I think some form of the code below will fix that.
There is still the issue that my board will need some way of controlling the initial state of vbus-sink.
@Guenter: would my initial patch be acceptable to set the default state of vbus-source and vbus-sink. Would you like some code to sanity check that both were not enabled at the same time ?
Quoted 23 lines
Acked-by Peter Chen <[email protected]>Signed-off-by Li Jun <[email protected]>--- drivers/staging/typec/tcpci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/typec/tcpci.c +2
-3@@ -381,9 +381,8 @@ static int tcpci_set_vbus(struct tcpc_dev *tcpc, bool source, bool sink)struct tcpci *tcpci =tcpc_to_tcpci (tcpc);int ret; -/* Disable both source and sink first before enabling anything */ - -if (!source) { +/* Only disable source if it was enabled */ +if (!source && tcpci->drive_vbus) { ret =regmap_write (tcpci->regmap,TCPC_COMMAND ,TCPC_CMD_DISABLE_SRC_VBUS );
Quoted 1 line
if (ret < 0)
The version of struct tcpci doesn't have a drive_vbus. Where should drive_vbus get set and cleared ?
Is this a more complete version of what you intended ?
TCPC_CMD_DISABLE_SRC_VBUS);
if (ret < 0)
@@ -292,6 +295,8 @@ static int tcpci_set_vbus(struct tcpc_dev *tcpc,
bool source, bool sink)
}
if (source) {
+ tcpci->drive_vbus = true;
+
ret = regmap_write(tcpci->regmap, TCPC_COMMAND,
TCPC_CMD_SRC_VBUS_DEFAULT);
if (ret < 0)
@@ -503,6 +508,7 @@ struct tcpci *tcpci_register_port(struct device
*dev, struct tcpci_data *data)
tcpci->dev = dev;
tcpci->data = data;
tcpci->regmap = data->regmap;+ tcpci->drive_vbus = false;
tcpci->tcpc.init = tcpci_init;
tcpci->tcpc.get_vbus = tcpci_get_vbus;drivers/usb/typec/tcpci.c +1 -0
@@ -28,6 +28,7 @@ struct tcpci {struct regmap *regmap;bool controls_vbus; +bool drive_vbus;struct tcpc_dev tcpc;struct tcpci_data *data;
@@ -277,7 +278,9 @@ static int tcpci_set_vbus(struct tcpc_dev *tcpc,
bool source, bool sink)
/* Disable both source and sink first before enabling anything
*/
- if (!source) {
+ if (!source && tcpci->drive_vbus) {
+ tcpci->drive_vbus = false;
+
ret = regmap_write(tcpci->regmap, TCPC_COMMAND,
Re: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree
Quoted 17 lines · Angus Ainslie
Quoted 13 lines
staging: typec: don't do vbus source disable for dead battery
In PTN5110 design, DisableSourceVBUS command also disables the sink enable signal because the
EN_SNKcan be used to source higher voltage, and, there is only one TCPC command to disable sourcing voltage without telling whether to disable 5V or the high voltage, and to keep the design simple they designed the PTN5110 to disable both. with this fact, we use the flagdrive_vbusto check if the source vbus enable was issued, if yes we then do vbus source disable, in dead battery case, we never did vbus source enable, so will not issue vbus source disable command.Thanks Peter, this sounds like the missing piece of information and I think some form of the code below will fix that.
Quoted 7 lines
There is still the issue that my board will need some way of controlling the initial state of vbus-sink.
@Guenter: would my initial patch be acceptable to set the default state of vbus-source and vbus-sink. Would you like some code to sanity check that both were not enabled at the same time ?
Seems to me this is indeed a chip specific problem. I don't think a fix belongs into the tcpm code. As mentioned before, the current status (ie drive_vbus) should be readable from the chip. I am not sure though if we should add a PTN5110 specific quirk to the driver to handle the situation. I am concerned that fixing this as suggested below for PTN5110 may cause trouble with other chips. Maybe not, but I'd rather be cautious.
Thanks,
Guenter
Quoted 75 lines
Quoted 22 lines
Acked-by Peter Chen <[email protected]>Signed-off-by Li Jun <[email protected]>---
drivers/staging/typec/tcpci.c| 5 ++---1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/typec/tcpci.c +2
-3@@ -381,9 +381,8 @@ static int tcpci_set_vbus(struct tcpc_dev *tcpc, bool source, bool sink)struct tcpci *tcpci =tcpc_to_tcpci (tcpc);int ret; -/* Disable both source and sink first before enabling anything */ - -if (!source) { +/* Only disable source if it was enabled */ +if (!source && tcpci->drive_vbus) { ret =regmap_write (tcpci->regmap,TCPC_COMMAND ,TCPC_CMD_DISABLE_SRC_VBUS );Quoted 1 line
if (ret < 0)
The version of struct tcpci doesn't have a
drive_vbus. Where shoulddrive_vbusget set and cleared ?Is this a more complete version of what you intended ?
drivers/usb/typec/tcpci.c +4
-1@@ -28,6 +28,7 @@ struct tcpci {struct regmap *regmap;bool controls_vbus; +bool drive_vbus;struct tcpc_dev tcpc;struct tcpci_data *data;@@ -277,7 +278,9 @@ static int tcpci_set_vbus(struct tcpc_dev *tcpc, bool source, bool sink)/* Disable both source and sink first before enabling anything */ -if (!source) { +if (!source && tcpci->drive_vbus) { + tcpci->drive_vbus = false; + ret =regmap_write (tcpci->regmap,TCPC_COMMAND ,TCPC_CMD_DISABLE_SRC_VBUS );if (ret < 0)drivers/usb/typec/tcpci.c +2
-0@@ -292,6 +295,8 @@ static int tcpci_set_vbus(struct tcpc_dev *tcpc, bool source, bool sink) }if (source) { + tcpci->drive_vbus = true; + ret =regmap_write (tcpci->regmap,TCPC_COMMAND ,TCPC_CMD_SRC_VBUS_DEFAULT );if (ret < 0)drivers/usb/typec/tcpci.c +1
-0@@ -503,6 +508,7 @@ struct tcpci *tcpci_register_port(struct device *dev, struct tcpci_data *data) tcpci->dev = dev; tcpci->data = data; tcpci->regmap = data->regmap; + tcpci->drive_vbus = false; tcpci->tcpc.init = tcpci_init;tcpci->tcpc.get_vbus = tcpci_get_vbus;
RE: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree
Hi
Quoted 37 lines
-----Original Message-----
From: Guenter Roeck <[email protected]> On Behalf Of Guenter Roeck
Sent: 2018年9月14日 1:35
To: Angus Ainslie <[email protected]>
Cc: Peter Chen <[email protected]>; Heikki Krogerus <[email protected]>; Greg Kroah-Hartman <[email protected]>; [email protected]; lkml <[email protected]>; Peter Chen <[email protected]>; Jun Li <[email protected]>
Subject: Re: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetreeQuoted 17 lines · Angus Ainslie
Quoted 13 lines
staging: typec: don't do vbus source disable for dead battery
In PTN5110 design, DisableSourceVBUS command also disables the sink enable signal because the
EN_SNKcan be used to source higher voltage, and, there is only one TCPC command to disable sourcing voltage without telling whether to disable 5V or the high voltage, and to keep the design simple they designed the PTN5110 to disable both. with this fact, we use the flagdrive_vbusto check if the source vbus enable was issued, if yes we then do vbus source disable, in dead battery case, we never did vbus source enable, so will not issue vbus source disable command.Thanks Peter, this sounds like the missing piece of information and I think some form of the code below will fix that.
Quoted 7 lines
There is still the issue that my board will need some way of controlling the initial state of vbus-sink.
@Guenter: would my initial patch be acceptable to set the default state of vbus-source and vbus-sink. Would you like some code to sanity check that both were not enabled at the same time ?
Quoted 6 lines
Seems to me this is indeed a chip specific problem. I don't think a fix belongs into the tcpm code. As mentioned before, the current status (ie
drive_vbus) should be readable from the chip. I am not sure though if we should add a
PTN5110 specific quirk to the driver to handle the situation. I am concerned that fixing this as suggested below for PTN5110 may cause trouble with other chips. Maybe not, but I'd rather be cautious.
Yes, this is a chip specific problem, the reason DisableSourceVBUS command also disables the sink enable signal because the EN_SNK of PTN5110 can be used to source higher voltage And, there is only one TCPC command to disable sourcing voltage without telling whether to disable 5V or the high voltage, and to keep the design simple, TPN5110 is designed to disable both.
The patch below is to not issue a vbus disable command if it was not enabled, from my point view it should be OK and has the benefit to save one command.
Li Jun
Quoted 81 lines
Thanks,
GuenterQuoted 77 lines
Quoted 23 lines
Acked-by Peter Chen <[email protected]>Signed-off-by Li Jun <[email protected]>---
drivers/staging/typec/tcpci.c| 5 ++---1 file changed, 2 insertions(+), 3 deletions(-)(quoted diff) +0
-0
b/drivers/staging/typec/tcpci.cindex2d4fbb8aac5e..7352207224b5100644drivers/staging/typec/tcpci.c +2
-3@@ -381,9 +381,8 @@ static int tcpci_set_vbus(struct tcpc_dev *tcpc, bool source, bool sink)struct tcpci *tcpci =tcpc_to_tcpci (tcpc);int ret; -/* Disable both source and sink first before enabling anything */ - -if (!source) { +/* Only disable source if it was enabled */ if (!source && + tcpci->drive_vbus) { ret =regmap_write (tcpci->regmap,TCPC_COMMAND ,TCPC_CMD_DISABLE_SRC_VBUS );Quoted 1 line
if (ret < 0)
The version of struct tcpci doesn't have a
drive_vbus. Where shoulddrive_vbusget set and cleared ?Is this a more complete version of what you intended ?
drivers/usb/typec/tcpci.c +4
-1@@ -28,6 +28,7 @@ struct tcpci {struct regmap *regmap;bool controls_vbus; +bool drive_vbus;struct tcpc_dev tcpc;struct tcpci_data *data;@@ -277,7 +278,9 @@ static int tcpci_set_vbus(struct tcpc_dev *tcpc, bool source, bool sink)/* Disable both source and sink first before enabling anything */ -if (!source) { +if (!source && tcpci->drive_vbus) { + tcpci->drive_vbus = false; + ret = regmap_write(tcpci->regmap, TCPC_COMMAND,TCPC_CMD_DISABLE_SRC_VBUS); if (ret < 0)drivers/usb/typec/tcpci.c +2
-0@@ -292,6 +295,8 @@ static int tcpci_set_vbus(struct tcpc_dev *tcpc, bool source, bool sink) }if (source) { + tcpci->drive_vbus = true; + ret =regmap_write (tcpci->regmap,TCPC_COMMAND ,TCPC_CMD_SRC_VBUS_DEFAULT );if (ret < 0)drivers/usb/typec/tcpci.c +1
-0@@ -503,6 +508,7 @@ struct tcpci *tcpci_register_port(struct device *dev, struct tcpci_data *data) tcpci->dev = dev; tcpci->data = data; tcpci->regmap = data->regmap; + tcpci->drive_vbus = false; tcpci->tcpc.init = tcpci_init;tcpci->tcpc.get_vbus = tcpci_get_vbus;
RE: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree
In reply to Angus AinslieHi
Quoted 75 lines
-----Original Message-----
From: Angus Ainslie <[email protected]>
Sent: 2018年9月13日 19:10
To: Peter Chen <[email protected]>
Cc: [email protected]; Heikki Krogerus <[email protected]>; Greg Kroah-Hartman <[email protected]>; [email protected]; lkml <[email protected]>; Peter Chen <[email protected]>; Jun Li <[email protected]>; Guenter Roeck <[email protected]>
Subject: Re: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetreeQuoted 49 lines · Peter Chen
Quoted 33 lines · Guenter Roeck
Quoted 8 lines · Angus Ainslie
Quoted 6 lines · Guenter Roeck
I cant put my finger on it but this seems wrong. As i said both src and sink should never be true at the same time. I also din’t understand why turning off src should power off your board. Ultimately my concern is that we may be just painting over the real problem, and that would be really bad to do with dt properties.
Quoted 7 lines
I agree that this doesn't seem like the correct way of solving the problem. On this HW (Emcraft iMX8M BSB) I think the PTN5110 chip has been connected correctly so I'm assuming that it is some quirk of the PTN5110.
I didn't design the HW or the chip. This is a workaround for "quirky" hardware and there may be others that don't behave exactly as expected.
I wouldn't be that sure about that. It may as well be that the tcpc driver and/or the tcpm driver are doing something wrong when initializing.
I didn't really understand the logs you sent out earlier. It looked like the system would loose power if the
TCPC_CMD_DISABLE_SRC_VBUScommand is sent. That doesn't really make sense to me since it indicates that the chip sources power to the remote, and turning that off should not result in a local loss of power.Note that the chip is supposed to be able to report if it is sourcing vbus and if VBUS is present, in the
POWER_STATUSregister. Another question is the content of theROLE_CONTROLregister when the system boots, and theDEVICE_CAPABILITIESsettings.Quoted 7 lines
Overall I suspect that we don't handle startup for your system correctly in the tcpc driver. The ideal solution would be to find a solution which does not require any devicetree properties, but to do that we'll need to get a better understanding about your system's requirements.
Guenter
Hi Angus,
Would you please check if below patch can fix your issue?
staging: typec: don't do vbus source disable for dead battery
Quoted 10 lines
In PTN5110 design, DisableSourceVBUS command also disables the sink enable signal because the
EN_SNKcan be used to source higher voltage, and, there is only one TCPC command to disable sourcing voltage without telling whether to disable 5V or the high voltage, and to keep the design simple they designed the PTN5110 to disable both. with this fact, we use the flagdrive_vbusto check if the source vbus enable was issued, if yes we then do vbus source disable, in dead battery case, we never did vbus source enable, so will not issue vbus source disable command.Thanks Peter, this sounds like the missing piece of information and I think some form of the code below will fix that.
Quoted 6 lines
There is still the issue that my board will need some way of controlling the initial state of vbus-sink.
@Guenter: would my initial patch be acceptable to set the default state of vbus-source and vbus-sink. Would you like some code to sanity check that both were not enabled at the same time ?
I agree Guenter using a dt property is not the proper way here(maybe valid for your HW with only typec power supply), I think a right way is to change tcpm to handle this kind case(like the existing vbus_never_low flag) so we will have a common handling
if (vbus_on && CC_state_is_RP)
dead_battery = true; bypass tcpm_init_vbus or only enable sink.