x86/intel_rdt: Switch to bitmap_zalloc()
PATCH 1/1 x86/intel_rdt: Switch to bitmap_zalloc()
Switch to bitmap_zalloc() to show clearly what we are allocating. Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by Andy Shevchenko <[email protected]>
--- arch/x86/kernel/cpu/intel_rdt.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
arch/x86/kernel/cpu/intel_rdt.c +4 -6
@@ -485,9 +485,7 @@ static int domain_setup_mon_state(struct rdt_resource *r, struct rdt_domain *d)size_t tsize;if (is_llc_occupancy_enabled ()) { - d->rmid_busy_llc =kcalloc (BITS_TO_LONGS (r->num_rmid), -sizeof (unsigned long ), -GFP_KERNEL ); + d->rmid_busy_llc =bitmap_zalloc (r->num_rmid,GFP_KERNEL );if (!d->rmid_busy_llc)return -ENOMEM ;INIT_DELAYED_WORK (&d->cqm_limbo, cqm_handle_limbo);
@@ -496,7 +494,7 @@ static int domain_setup_mon_state(struct rdt_resource *r, struct rdt_domain *d) tsize =sizeof (*d->mbm_total); d->mbm_total =kcalloc (r->num_rmid, tsize,GFP_KERNEL );if (!d->mbm_total) { -kfree (d->rmid_busy_llc); +bitmap_free (d->rmid_busy_llc);return -ENOMEM ; } }
@@ -504,7 +502,7 @@ static int domain_setup_mon_state(struct rdt_resource *r, struct rdt_domain *d) tsize =sizeof (*d->mbm_local); d->mbm_local =kcalloc (r->num_rmid, tsize,GFP_KERNEL );if (!d->mbm_local) { -kfree (d->rmid_busy_llc); +bitmap_free (d->rmid_busy_llc);kfree (d->mbm_total);return -ENOMEM ; }
@@ -612,7 +610,7 @@ static void domain_remove_cpu(int cpu, struct rdt_resource *r)kfree (d->ctrl_val);kfree (d->mbps_val); -kfree (d->rmid_busy_llc); +bitmap_free (d->rmid_busy_llc);kfree (d->mbm_total);kfree (d->mbm_local);kfree (d);
Signature · 1 line
2.18.0
Quoted 8 lines · Andy Shevchenko
Switch to
bitmap_zalloc()to show clearly what we are allocating. Besides that it returns pointer of bitmap type instead of opaque void *.Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/kernel/cpu/intel_rdt.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
Acked-by Fenghua Yu <[email protected]>
tip-bot for Andy Shevchenko
merge botx86/intel_rdt: Switch to bitmap_zalloc()
Commit-ID: 7b6f10b3e6ee031928642e90a0a7233c767dc4ff Gitweb: https://git.kernel.org/tip/7b6f10b3e6ee031928642e90a0a7233c767dc4ff Author: Andy Shevchenko <[email protected]> AuthorDate: Thu, 30 Aug 2018 14:50:39 +0300 Committer: Thomas Gleixner <[email protected]> CommitDate: Wed, 3 Oct 2018 16:19:35 +0200
x86/intel_rdt: Switch to bitmap_zalloc()
Switch to bitmap_zalloc() to show clearly what is allocated. Besides that it returns a pointer of bitmap type instead of opaque void *.
Signed-off-by Andy Shevchenko <[email protected]>
Signed-off-by Thomas Gleixner <[email protected]>
Acked-by Fenghua Yu <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
--- arch/x86/kernel/cpu/intel_rdt.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
arch/x86/kernel/cpu/intel_rdt.c +4 -6
@@ -485,9 +485,7 @@ static int domain_setup_mon_state(struct rdt_resource *r, struct rdt_domain *d)size_t tsize;if (is_llc_occupancy_enabled ()) { - d->rmid_busy_llc =kcalloc (BITS_TO_LONGS (r->num_rmid), -sizeof (unsigned long ), -GFP_KERNEL ); + d->rmid_busy_llc =bitmap_zalloc (r->num_rmid,GFP_KERNEL );if (!d->rmid_busy_llc)return -ENOMEM ;INIT_DELAYED_WORK (&d->cqm_limbo, cqm_handle_limbo);
@@ -496,7 +494,7 @@ static int domain_setup_mon_state(struct rdt_resource *r, struct rdt_domain *d) tsize =sizeof (*d->mbm_total); d->mbm_total =kcalloc (r->num_rmid, tsize,GFP_KERNEL );if (!d->mbm_total) { -kfree (d->rmid_busy_llc); +bitmap_free (d->rmid_busy_llc);return -ENOMEM ; } }
@@ -504,7 +502,7 @@ static int domain_setup_mon_state(struct rdt_resource *r, struct rdt_domain *d) tsize =sizeof (*d->mbm_local); d->mbm_local =kcalloc (r->num_rmid, tsize,GFP_KERNEL );if (!d->mbm_local) { -kfree (d->rmid_busy_llc); +bitmap_free (d->rmid_busy_llc);kfree (d->mbm_total);return -ENOMEM ; }
@@ -612,7 +610,7 @@ static void domain_remove_cpu(int cpu, struct rdt_resource *r)kfree (d->ctrl_val);kfree (d->mbps_val); -kfree (d->rmid_busy_llc); +bitmap_free (d->rmid_busy_llc);kfree (d->mbm_total);kfree (d->mbm_local);kfree (d);
tip-bot for Andy Shevchenko
merge botx86/intel_rdt: Switch to bitmap_zalloc()
Commit-ID: 82159876d32b7959c0b0ea8fe12c428f41502a6f Gitweb: https://git.kernel.org/tip/82159876d32b7959c0b0ea8fe12c428f41502a6f Author: Andy Shevchenko <[email protected]> AuthorDate: Thu, 30 Aug 2018 14:50:39 +0300 Committer: Thomas Gleixner <[email protected]> CommitDate: Wed, 3 Oct 2018 21:53:49 +0200
x86/intel_rdt: Switch to bitmap_zalloc()
Switch to bitmap_zalloc() to show clearly what is allocated. Besides that it returns a pointer of bitmap type instead of opaque void *.
Signed-off-by Andy Shevchenko <[email protected]>
Signed-off-by Thomas Gleixner <[email protected]>
Acked-by Fenghua Yu <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
--- arch/x86/kernel/cpu/intel_rdt.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
arch/x86/kernel/cpu/intel_rdt.c +4 -6
@@ -485,9 +485,7 @@ static int domain_setup_mon_state(struct rdt_resource *r, struct rdt_domain *d)size_t tsize;if (is_llc_occupancy_enabled ()) { - d->rmid_busy_llc =kcalloc (BITS_TO_LONGS (r->num_rmid), -sizeof (unsigned long ), -GFP_KERNEL ); + d->rmid_busy_llc =bitmap_zalloc (r->num_rmid,GFP_KERNEL );if (!d->rmid_busy_llc)return -ENOMEM ;INIT_DELAYED_WORK (&d->cqm_limbo, cqm_handle_limbo);
@@ -496,7 +494,7 @@ static int domain_setup_mon_state(struct rdt_resource *r, struct rdt_domain *d) tsize =sizeof (*d->mbm_total); d->mbm_total =kcalloc (r->num_rmid, tsize,GFP_KERNEL );if (!d->mbm_total) { -kfree (d->rmid_busy_llc); +bitmap_free (d->rmid_busy_llc);return -ENOMEM ; } }
@@ -504,7 +502,7 @@ static int domain_setup_mon_state(struct rdt_resource *r, struct rdt_domain *d) tsize =sizeof (*d->mbm_local); d->mbm_local =kcalloc (r->num_rmid, tsize,GFP_KERNEL );if (!d->mbm_local) { -kfree (d->rmid_busy_llc); +bitmap_free (d->rmid_busy_llc);kfree (d->mbm_total);return -ENOMEM ; }
@@ -612,7 +610,7 @@ static void domain_remove_cpu(int cpu, struct rdt_resource *r)kfree (d->ctrl_val);kfree (d->mbps_val); -kfree (d->rmid_busy_llc); +bitmap_free (d->rmid_busy_llc);kfree (d->mbm_total);kfree (d->mbm_local);kfree (d);