drm/sun4i: Support color dithering for LCD panels
Subsystems (6)
v2 cover drm/sun4i: Support color dithering for LCD panels
Hi,
This is v2 of my sun4i-drm LCD color dithering series. v1 was from back in April [1]. Most of the driver code is unchanged.
Changes since v1:
- Explicitly list properties from the simple-panel binding that apply to the Bananapi 7" panel
- Moved an incorrectly squashed change from patch 3 to patch 1, where it belongs
[1] https://patchwork.ozlabs.org/cover/900725/
Original cover letter follows:
Dithering is a method of approximating a color from a mixture of other colors when the required color isn't available. It reduces color banding artifacts that can be observed when displaying gradients (e.g. grayscale gradients). This may occur when the image that needs to be displayed is 24-bit but the LCD panel is a lower bit depth and does not perform dithering on its own.
The TCON (LCD controller) found in Allwinner SoCs has hardware support for dithering on channel 0, the channel used to feed LCD panels. This series adds support for it.
Patch 1 reworks the mode set function for the CPU interface to pass the encoder object, so it can be passed to other helper functions.
Patch 2 renames the dithering related register macros to reflect the fact that dithering is only supported on channel 0.
Patch 3 adds support for dithering on all LCD panel output types.
Patch 4 adds support for Banana Pi's 7" DPI LCD panel.
Patch 5 adds a pinmux setting for RGB888 for the Allwinner A20 SoC. This change has been sent by others before.
Patch 6 provides an example for enabling the Banana Pi 7" DPI LCD panel on the Banana Pi M1+. This should not be merged. I will likely rework this into an overlay in the future.
Note that I was only able to test dithering with DPI, as I do not have other panel types. However the underlying concept and core code is the same, as are the drm objects accessed. Nevertheless I'm hoping Jonathan can test LVDS and Maxime can test MIPI DSI.
Also it seems pwm-backlight hardware is unusable at the moment. I'm not sure whether the pwm-backlight or sun4i-pwm driver is to blame. I had to manually poke the pwm registers so the LCD backlight wouldn't be completely black.
Regards
ChenYu
Chen-Yu Tsai (5):
drm/sun4i: tcon: Pass drm_encoder * into sun4i_tcon0_mode_set_cpu drm/sun4i: tcon: Rename Dithering related register macros drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel
ARM: dts: sun7i: add pinmux setting for RGB888 output for LCD0 [DO NOT MERGE] ARM: dts: sun7i: bananapi-m1-plus: Enable Bananapi 7"
800x480 RGB LCD panel
Jonathan Liu (1):
drm/sun4i: tcon: Add dithering support for RGB565/RGB666 LCD panels
.../display/panel/bananapi,s070wv20-ct16.txt | 12 +++ .../boot/dts/sun7i-a20-bananapi-m1-plus.dts | 56 ++++++++++++++ arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++ drivers/gpu/drm/panel/panel-simple.c | 25 ++++++ drivers/gpu/drm/sun4i/sun4i_tcon.c | 76 ++++++++++++++++--- drivers/gpu/drm/sun4i/sun4i_tcon.h | 27 ++++--- 6 files changed, 186 insertions(+), 21 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt
Signature · 1 line
2.19.0.rc1
PATCH v2 1/6 drm/sun4i: tcon: Pass drm_encoder * into sun4i_tcon0_mode_set_cpu
sun4i_tcon0_mode_set_cpu() currently accepts struct mipi_dsi_device * as its second parameter. This is derived from drm_encoder.
The DSI encoder is tied to the CPU interface mode of the TCON as a special case. In theory, if hardware were available, we could also support normal CPU interface modes. It is better to pass the generic encoder instead of the specialized mipi_dsi_device, and handle the differences inside the function.
Passing the encoder would also enable the function to pass it, or any other data structures related to it, to other functions expecting it. One such example would be dithering support that will be added in a later patch, which looks at properties tied to the connector to determine whether dithering should be enabled or not.
--- drivers/gpu/drm/sun4i/sun4i_tcon.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)
drivers/gpu/drm/sun4i/sun4i_tcon.c +6 -9
@@ -278,9 +278,12 @@ static void sun4i_tcon0_mode_set_common(struct sun4i_tcon *tcon, }static void sun4i_tcon0_mode_set_cpu (struct sun4i_tcon *tcon, -struct mipi_dsi_device *device, +const struct drm_encoder *encoder,const struct drm_display_mode *mode) { +/* TODO support normal CPU interface modes */ +struct sun6i_dsi *dsi =encoder_to_sun6i_dsi (encoder); +struct mipi_dsi_device *device = dsi->device;u8 bpp =mipi_dsi_pixel_format_to_bpp (device->format);u8 lanes = device->lanes;u32 block_space, start_delay;
@@ -610,16 +613,10 @@ void sun4i_tcon_mode_set(struct sun4i_tcon *tcon,const struct drm_encoder *encoder, const struct drm_display_mode *mode) { - struct sun6i_dsi *dsi; - switch (encoder->encoder_type) { case DRM_MODE_ENCODER_DSI: -/* -* This is not really elegant, but it's the "cleaner" -* way I could think of... -*/ - dsi =encoder_to_sun6i_dsi (encoder); -sun4i_tcon0_mode_set_cpu (tcon, dsi->device, mode); +/* DSI is tied to special case of CPU interface */ +sun4i_tcon0_mode_set_cpu (tcon ,encoder ,mode );break ;case DRM_MODE_ENCODER_LVDS :sun4i_tcon0_mode_set_lvds (tcon, encoder, mode);
Signature · 1 line
2.19.0.rc1
PATCH v2 2/6 drm/sun4i: tcon: Rename Dithering related register macros
In reply to Chen-Yu TsaiDithering is only supported for TCON channel 0. Throughout the datasheet all the names associated with these register are prefixed "TCON0", instead of "TCON". The only exception is the control register "TCON_FRM_CTL_REG".
Rename the macros to reflect this.
--- drivers/gpu/drm/sun4i/sun4i_tcon.h | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-)
drivers/gpu/drm/sun4i/sun4i_tcon.h +15 -12
@@ -37,18 +37,21 @@#define SUN4I_TCON_GINT1_REG 0x8#define SUN4I_TCON_FRM_CTL_REG 0x10 -#define SUN4I_TCON_FRM_CTL_EN BIT(31) - -#define SUN4I_TCON_FRM_SEED_PR_REG 0x14 -#define SUN4I_TCON_FRM_SEED_PG_REG 0x18 -#define SUN4I_TCON_FRM_SEED_PB_REG 0x1c -#define SUN4I_TCON_FRM_SEED_LR_REG 0x20 -#define SUN4I_TCON_FRM_SEED_LG_REG 0x24 -#define SUN4I_TCON_FRM_SEED_LB_REG 0x28 -#define SUN4I_TCON_FRM_TBL0_REG 0x2c -#define SUN4I_TCON_FRM_TBL1_REG 0x30 -#define SUN4I_TCON_FRM_TBL2_REG 0x34 -#define SUN4I_TCON_FRM_TBL3_REG 0x38 +#define SUN4I_TCON0_FRM_CTL_EN BIT(31) +#define SUN4I_TCON0_FRM_CTL_MODE_R BIT(6) +#define SUN4I_TCON0_FRM_CTL_MODE_G BIT(5) +#define SUN4I_TCON0_FRM_CTL_MODE_B BIT(4) + +#define SUN4I_TCON0_FRM_SEED_PR_REG 0x14 +#define SUN4I_TCON0_FRM_SEED_PG_REG 0x18 +#define SUN4I_TCON0_FRM_SEED_PB_REG 0x1c +#define SUN4I_TCON0_FRM_SEED_LR_REG 0x20 +#define SUN4I_TCON0_FRM_SEED_LG_REG 0x24 +#define SUN4I_TCON0_FRM_SEED_LB_REG 0x28 +#define SUN4I_TCON0_FRM_TBL0_REG 0x2c +#define SUN4I_TCON0_FRM_TBL1_REG 0x30 +#define SUN4I_TCON0_FRM_TBL2_REG 0x34 +#define SUN4I_TCON0_FRM_TBL3_REG 0x38#define SUN4I_TCON0_CTL_REG 0x40#define SUN4I_TCON0_CTL_TCON_ENABLE BIT(31)
Signature · 1 line
2.19.0.rc1
PATCH v2 3/6 drm/sun4i: tcon: Add dithering support for RGB565/RGB666 LCD panels
In reply to Chen-Yu TsaiFrom: Jonathan Liu <[email protected]>
The hardware supports dithering on TCON channel 0 which is used for LCD panels.
Dithering is a method of approximating a color from a mixture of other colors when the required color isn't available. It reduces color banding artifacts that can be observed when displaying gradients (e.g. grayscale gradients). This may occur when the image that needs to be displayed is 24-bit but the LCD panel is a lower bit depth and does not perform dithering on its own.
--- drivers/gpu/drm/sun4i/sun4i_tcon.c | 61 ++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+)
drivers/gpu/drm/sun4i/sun4i_tcon.c +61 -0
@@ -12,6 +12,7 @@#include <drm/drmP.h> #include <drm/drm_atomic_helper.h> +#include <drm/drm_connector.h> #include <drm/drm_crtc.h> #include <drm/drm_crtc_helper.h> #include <drm/drm_encoder.h>
@@ -277,6 +278,57 @@ static void sun4i_tcon0_mode_set_common(struct sun4i_tcon *tcon, SUN4I_TCON0_BASIC0_Y(mode->crtc_vdisplay)); } +static void sun4i_tcon0_mode_set_dithering (struct sun4i_tcon *tcon, +const struct drm_connector *connector) +{ +u32 bus_format =0 ; +u32 val =0 ; + +/* XXX Would this ever happen? */ +if (!connector) +return ; + +/* +* FIXME: Undocumented bits +* +* The whole dithering process and these parameters are not +* explained in the vendor documents or BSP kernel code. +*/ +regmap_write (tcon->regs,SUN4I_TCON0_FRM_SEED_PR_REG ,0x11111111 ); +regmap_write (tcon->regs,SUN4I_TCON0_FRM_SEED_PG_REG ,0x11111111 ); +regmap_write (tcon->regs,SUN4I_TCON0_FRM_SEED_PB_REG ,0x11111111 ); +regmap_write (tcon->regs,SUN4I_TCON0_FRM_SEED_LR_REG ,0x11111111 ); +regmap_write (tcon->regs,SUN4I_TCON0_FRM_SEED_LG_REG ,0x11111111 ); +regmap_write (tcon->regs,SUN4I_TCON0_FRM_SEED_LB_REG ,0x11111111 ); +regmap_write (tcon->regs,SUN4I_TCON0_FRM_TBL0_REG ,0x01010000 ); +regmap_write (tcon->regs,SUN4I_TCON0_FRM_TBL1_REG ,0x15151111 ); +regmap_write (tcon->regs,SUN4I_TCON0_FRM_TBL2_REG ,0x57575555 ); +regmap_write (tcon->regs,SUN4I_TCON0_FRM_TBL3_REG ,0x7f7f7777 ); + +/* Do dithering if panel only supports 6 bits per color */ +if (connector->display_info.bpc ==6 ) + val |=SUN4I_TCON0_FRM_CTL_EN ; + +if (connector->display_info.num_bus_formats ==1 ) + bus_format = connector->display_info.bus_formats[0 ]; + +/* Check the connection format */ +switch (bus_format) { +case MEDIA_BUS_FMT_RGB565_1X16 : +/* R and B components are only 5 bits deep */ + val |=SUN4I_TCON0_FRM_CTL_MODE_R ; + val |=SUN4I_TCON0_FRM_CTL_MODE_B ; +case MEDIA_BUS_FMT_RGB666_1X18 : +case MEDIA_BUS_FMT_RGB666_1X7X3_SPWG : +/* Fall through: enable dithering */ + val |=SUN4I_TCON0_FRM_CTL_EN ; +break ; + } + +/* Write dithering settings */ +regmap_write (tcon->regs,SUN4I_TCON_FRM_CTL_REG , val); +} +static void sun4i_tcon0_mode_set_cpu (struct sun4i_tcon *tcon,const struct drm_encoder *encoder,const struct drm_display_mode *mode)
@@ -294,6 +346,9 @@ static void sun4i_tcon0_mode_set_cpu(struct sun4i_tcon *tcon,sun4i_tcon0_mode_set_common (tcon, mode); +/* Set dithering if needed */ +sun4i_tcon0_mode_set_dithering (tcon,sun4i_tcon_get_connector (encoder)); +regmap_update_bits (tcon->regs,SUN4I_TCON0_CTL_REG ,SUN4I_TCON0_CTL_IF_MASK ,SUN4I_TCON0_CTL_IF_8080 );
@@ -359,6 +414,9 @@ static void sun4i_tcon0_mode_set_lvds(struct sun4i_tcon *tcon, tcon->dclk_max_div =7 ;sun4i_tcon0_mode_set_common (tcon, mode); +/* Set dithering if needed */ +sun4i_tcon0_mode_set_dithering (tcon,sun4i_tcon_get_connector (encoder)); +/* Adjust clock delay */ clk_delay =sun4i_tcon_get_clk_delay (mode,0 ); regmap_update_bits(tcon->regs, SUN4I_TCON0_CTL_REG,
@@ -432,6 +490,9 @@ static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon, tcon->dclk_max_div =127 ;sun4i_tcon0_mode_set_common (tcon, mode); +/* Set dithering if needed */ +sun4i_tcon0_mode_set_dithering (tcon, tcon->panel->connector); +/* Adjust clock delay */ clk_delay =sun4i_tcon_get_clk_delay (mode,0 ); regmap_update_bits(tcon->regs, SUN4I_TCON0_CTL_REG,
Signature · 1 line
2.19.0.rc1
PATCH v2 4/6 drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel
In reply to Chen-Yu TsaiThis panel is marketed as Banana Pi 7" LCD display. On the back is a sticker denoting the model name S070WV20-CT16.
This is a 7" 800x480 panel connected through a 24-bit RGB interface. However the panel only does 262k colors.
Depending on the variant, the PCB attached to the panel module either supports DSI, or DSI + 24-bit RGB. DSI is converted to 24-bit RGB via an onboard ICN6211 MIPI DSI - RGB bridge chip, then fed to the panel itself.
--- .../display/panel/bananapi,s070wv20-ct16.txt | 12 +++++++++ drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt
Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt new file +12 -0
@@ -0,0 +1,12 @@ +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel + +Required properties: +- compatible: should be "bananapi,s070wv20-ct16" +- power-supply: see ./panel-common.txt + +Optional properties: +- enable-gpios: see ./simple-panel.txt +- backlight: see ./simple-panel.txt + +This binding is compatible with the simple-panel binding, which is specified +in ./simple-panel.txt.
drivers/gpu/drm/panel/panel-simple.c +25 -0
@@ -772,6 +772,28 @@ static const struct panel_desc avic_tm070ddh03 = { }, }; +static const struct drm_display_mode bananapi_s070wv20_ct16_mode = { + .clock =30000 , + .hdisplay =800 , + .hsync_start =800 +40 , + .hsync_end =800 +40 +48 , + .htotal =800 +40 +48 +40 , + .vdisplay =480 , + .vsync_start =480 +13 , + .vsync_end =480 +13 +3 , + .vtotal =480 +13 +3 +29 , +}; + +static const struct panel_desc bananapi_s070wv20_ct16 = { + .modes = &bananapi_s070wv20_ct16_mode, + .num_modes =1 , + .bpc =6 , + .size = { + .width =154 , + .height =86 , + }, +}; +static const struct drm_display_mode boe_hv070wsa_mode = { .clock =40800 , .hdisplay =1024 ,
@@ -2369,6 +2391,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "avic,tm070ddh03", .data = &avic_tm070ddh03, + }, { + .compatible = "bananapi,s070wv20-ct16", + .data = &bananapi_s070wv20_ct16, }, { .compatible = "boe,hv070wsa-100", .data = &boe_hv070wsa
Signature · 1 line
2.19.0.rc1
Re: [PATCH v2 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel
Quoted 11 lines · Chen-Yu Tsai
This panel is marketed as Banana Pi 7" LCD display. On the back is a sticker denoting the model name S070WV20-CT16.
This is a 7" 800x480 panel connected through a 24-bit RGB interface. However the panel only does 262k colors.
Depending on the variant, the PCB attached to the panel module either supports DSI, or DSI + 24-bit RGB. DSI is converted to 24-bit RGB via an onboard ICN6211 MIPI DSI - RGB bridge chip, then fed to the panel itself.
Quoted 7 lines
Signed-off-by Chen-Yu Tsai <[email protected]>--- .../display/panel/bananapi,s070wv20-ct16.txt | 12 +++++++++ drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt
Thierry Reding
AppliedRe: [PATCH v2 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel
In reply to Chen-Yu TsaiQuoted 11 lines · Chen-Yu Tsai
This panel is marketed as Banana Pi 7" LCD display. On the back is a sticker denoting the model name S070WV20-CT16.
This is a 7" 800x480 panel connected through a 24-bit RGB interface. However the panel only does 262k colors.
Depending on the variant, the PCB attached to the panel module either supports DSI, or DSI + 24-bit RGB. DSI is converted to 24-bit RGB via an onboard ICN6211 MIPI DSI - RGB bridge chip, then fed to the panel itself.
Quoted 6 lines
Signed-off-by Chen-Yu Tsai <[email protected]>--- .../display/panel/bananapi,s070wv20-ct16.txt | 12 +++++++++ drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt
Next time, please make the bindings and driver changes separate patches.
Applied, thanks.
Thierry
PATCH v2 5/6 ARM: dts: sun7i: add pinmux setting for RGB888 output for LCD0
In reply to Chen-Yu TsaiOn the A20, as well as many other Allwinner SoCs, the PD pingroup has the LCD0 RGB output functions.
Add a pinmux setting for RGB888 output from LCD0, so boards and tablets with parallel RGB LCD panels may reference it.
--- arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/arm/boot/dts/sun7i-a20.dtsi +11 -0
@@ -950,6 +950,17 @@ pins = "PI20", "PI21"; function = "uart7"; }; + + lcd0_rgb888_pins: lcd0-rgb888-pins { + pins = "PD0", "PD1", "PD2", "PD3", "PD4", + "PD5", "PD6", "PD7", "PD8", "PD9", + "PD10", "PD11", "PD12", "PD13", + "PD14", "PD15", "PD16", "PD17", + "PD18", "PD19", "PD20", "PD21", + "PD22", "PD23", "PD24", "PD25", + "PD26", "PD27"; + function = "lcd0"; + }; }; timer@1c20c00 {
Signature · 1 line
2.19.0.rc1
PATCH v2 6/6 ARM: dts: sun7i: bananapi-m1-plus: Enable Bananapi 7" 800x480 RGB LCD panel
In reply to Chen-Yu TsaiThe BPI-M1+ has an FPC connector for connecting an RGB (parallel) or LVDS LCD panel. One of the compatible panels is a 7" 800x480 RGB panel from Bananapi. The backlight can be controlled by driving a PWM signal from the SoC at different duty cycles. The LCD enable pin does not seem to do anything, but it is nevertheless included for completeness. There is also a FT5306 capacitive touchscreen controller.
This should not be confused with the other 7" LCD that is LVDS based and has a resolution of 1024x600.
This patch enables all of the above for the BPI-M1+.
--- .../boot/dts/sun7i-a20-bananapi-m1-plus.dts | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+)
arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts +56 -0
@@ -47,6 +47,7 @@ #include "sunxi-common-regulators.dtsi" #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/pwm/pwm.h> / { model = "Banana Pi BPI-M1-Plus";
@@ -71,6 +72,29 @@ }; }; + lcd_backlight: lcd-backlight { + compatible = "pwm-backlight"; + pwms = <&pwm 0 20000 PWM_POLARITY_INVERTED>; /* 50 kHz */ + enable-gpios = <&pio 7 9 GPIO_ACTIVE_HIGH>; /* PH9 */ + brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; + default-brightness-level = <8>; + }; + + lcd_panel: lcd-panel { + compatible = "bananapi,s070wv20-ct16", "simple-panel"; + power-supply = <®_vcc5v0>; /* Actually driven from IPSOUT */ + /* This doesn't do anything for this particular connector */ + enable-gpios = <&pio 7 12 GPIO_ACTIVE_HIGH>; /* PH12 */ + + port { + backlight = <&lcd_backlight>; + + lcd_panel_input: endpoint { + remote-endpoint = <&tcon0_out_lcd>; + }; + }; + }; + leds { compatible = "gpio-leds"; pinctrl-names = "default";
@@ -173,6 +197,20 @@ status = "okay"; }; +&i2c3 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c3_pins_a>; + status = "okay"; + + touchscreen@38 { + compatible = "edt,edt-ft5306", "edt,edt-ft5x06"; + reg = <0x38>; + interrupt-parent = <&pio>; + interrupts = <7 7 IRQ_TYPE_EDGE_FALLING>; /* PH7 */ + reset-gpios = <&pio 7 8 GPIO_ACTIVE_LOW>; /* PH8 */ + }; +}; + &ir0 { pinctrl-names = "default"; pinctrl-0 = <&ir0_rx_pins_a>;
@@ -249,6 +287,12 @@ }; }; +&pwm { + pinctrl-names = "default"; + pinctrl-0 = <&pwm0_pins_a>; + status = "okay"; +}; + ®_dcdc2 { regulator-always-on; regulator-min-microvolt = <1000000>;
@@ -278,6 +322,18 @@ status = "okay"; }; +&tcon0 { + pinctrl-names = "default"; + pinctrl-0 = <&lcd0_rgb888_pins>; +}; + +&tcon0_out { + tcon0_out_lcd: endpoint@0 { + reg = <0>; + remote-endpoint = <&lcd_panel_input>; + }; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pins_a>;
Signature · 1 line
2.19.0.rc1
Quoted 6 lines · Chen-Yu Tsai
Hi,
This is v2 of my sun4i-drm LCD color dithering series. v1 was from back in April [1]. Most of the driver code is unchanged.
Quoted 7 lines
Changes since v1:
- Explicitly list properties from the simple-panel binding that apply to the Bananapi 7" panel
- Moved an incorrectly squashed change from patch 3 to patch 1, where it belongs
Applied the first three patches, thanks!
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Quoted 10 lines · Maxime Ripard
Quoted 8 lines · Chen-Yu Tsai
Hi,
This is v2 of my sun4i-drm LCD color dithering series. v1 was from back in April [1]. Most of the driver code is unchanged.
Changes since v1:
Quoted 7 lines
Quoted 5 lines
- Explicitly list properties from the simple-panel binding that apply to the Bananapi 7" panel
- Moved an incorrectly squashed change from patch 3 to patch 1, where it belongs
Applied the first three patches, thanks!
Any comments on patches 4 and 5?
Thanks
ChenYu