xen: avoid crash in disable_hotplug_cpu
PATCH v3 1/1 xen: avoid crash in disable_hotplug_cpu
The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0:
BUG: unable to handle kernel NULL pointer dereference at 00000000000002d8 PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga9462db-default #1 openSUSE Tumbleweed (unreleased) Hardware name: Intel Corporation S5520UR/S5520UR, BIOS S5500.86B.01.00.0050.050620101605 05/06/2010 RIP: e030:device_offline+0x9/0xb0 Code: 77 24 00 e9 ce fe ff ff 48 8b 13 e9 68 ff ff ff 48 8b 13 e9 29 ff ff ff 48 8b 13 e9 ea fe ff ff 90 66 66 66 66 90 41 54 55 53 <f6> 87 d8 02 00 00 01 0f 85 88 00 00 00 48 c7 c2 20 09 60 81 31 f6 RSP: e02b:ffffc90040f27e80 EFLAGS: 00010203 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: ffff8801f3800000 RSI: ffffc90040f27e70 RDI: 0000000000000000 RBP: 0000000000000000 R08: ffffffff820e47b3 R09: 0000000000000000 R10: 0000000000007ff0 R11: 0000000000000000 R12: ffffffff822e6d30 R13: dead000000000200 R14: dead000000000100 R15: ffffffff8158b4e0 FS: 00007ffa595158c0(0000) GS:ffff8801f39c0000(0000) knlGS:0000000000000000 CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000000002d8 CR3: 00000001d9602000 CR4: 0000000000002660 Call Trace: handle_vcpu_hotplug_event+0xb5/0xc0 xenwatch_thread+0x80/0x140 ? wait_woken+0x80/0x80 kthread+0x112/0x130 ? kthread_create_worker_on_cpu+0x40/0x40 ret_from_fork+0x3a/0x50
This happens because handle_vcpu_hotplug_event is called twice. In the first iteration cpu_present is still true, in the second iteration cpu_present is false which causes get_cpu_device to return NULL. In case of cpu#0, cpu_online is apparently always true.
Fix this crash by checking if the cpu can be hotplugged, which is false for a cpu that was just removed.
Also check if the cpu was actually offlined by device_remove, otherwise leave the cpu_present state as it is.
--- drivers/xen/cpu_hotplug.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/xen/cpu_hotplug.c +4 -0
@@ -19,11 +19,15 @@ static void enable_hotplug_cpu(int cpu)static void disable_hotplug_cpu (int cpu) { +if (!cpu_is_hotpluggable (cpu)) +return ;if (cpu_online (cpu)) {lock_device_hotplug ();device_offline (get_cpu_device (cpu));unlock_device_hotplug (); } +if (cpu_online (cpu)) +return ;if (cpu_present (cpu))xen_arch_unregister_cpu (cpu);
Juergen Gross
maintainerQuoted 51 lines · Olaf Hering
The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0:
BUG: unable to handle kernel NULL pointer dereference at 00000000000002d8 PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga9462db-default #1 openSUSE Tumbleweed (unreleased) Hardware name: Intel Corporation S5520UR/S5520UR, BIOS S5500.86B.01.00.0050.050620101605 05/06/2010 RIP: e030:device_offline+0x9/0xb0 Code: 77 24 00 e9 ce fe ff ff 48 8b 13 e9 68 ff ff ff 48 8b 13 e9 29 ff ff ff 48 8b 13 e9 ea fe ff ff 90 66 66 66 66 90 41 54 55 53 <f6> 87 d8 02 00 00 01 0f 85 88 00 00 00 48 c7 c2 20 09 60 81 31 f6 RSP: e02b:ffffc90040f27e80 EFLAGS: 00010203 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: ffff8801f3800000 RSI: ffffc90040f27e70 RDI: 0000000000000000 RBP: 0000000000000000 R08: ffffffff820e47b3 R09: 0000000000000000 R10: 0000000000007ff0 R11: 0000000000000000 R12: ffffffff822e6d30 R13: dead000000000200 R14: dead000000000100 R15: ffffffff8158b4e0 FS: 00007ffa595158c0(0000) GS:ffff8801f39c0000(0000) knlGS:0000000000000000 CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000000002d8 CR3: 00000001d9602000 CR4: 0000000000002660 Call Trace: handle_vcpu_hotplug_event+0xb5/0xc0 xenwatch_thread+0x80/0x140 ? wait_woken+0x80/0x80 kthread+0x112/0x130 ? kthread_create_worker_on_cpu+0x40/0x40 ret_from_fork+0x3a/0x50This happens because
handle_vcpu_hotplug_eventis called twice. In the first iterationcpu_presentis still true, in the second iterationcpu_presentis false which causesget_cpu_deviceto return NULL. In case of cpu#0,cpu_onlineis apparently always true.Fix this crash by checking if the cpu can be hotplugged, which is false for a cpu that was just removed.
Also check if the cpu was actually offlined by
device_remove, otherwise leave thecpu_presentstate as it is.Signed-off-by Olaf Hering <[email protected]>--- drivers/xen/cpu_hotplug.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/xen/cpu_hotplug.c +1
-0@@ -19,11 +19,15 @@ static void enable_hotplug_cpu(int cpu)static void disable_hotplug_cpu (int cpu) { +if (!cpu_is_hotpluggable (cpu))
drivers/xen/cpu_hotplug.c static void enable_hotplug_cpu(int cpu) · line 32
Quoted 10 lines
drivers/xen/cpu_hotplug.c +3
-0+return ;if (cpu_online (cpu)) {lock_device_hotplug ();device_offline (get_cpu_device (cpu));unlock_device_hotplug (); } +if (cpu_online (cpu)) +return ;if (cpu_present (cpu))xen_arch_unregister_cpu (cpu);
Could you merge the two if conditions?
if (!cpu_online(cpu) && cpu_present(cpu))
xen_arch_unregister_cpu(cpu);
And while not really important, as we are called in the xenstore watch thread only, it might be a good idea to move the first cpu_online() test into the lock, i.e.:
lock_device_hotplug();
if (cpu_online(cpu))
device_offline(get_cpu_device(cpu));
unlock_device_hotplug();
This will make the code robust against reentry.
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Juergen Gross
maintainerQuoted 51 lines · Olaf Hering
The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0:
BUG: unable to handle kernel NULL pointer dereference at 00000000000002d8 PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga9462db-default #1 openSUSE Tumbleweed (unreleased) Hardware name: Intel Corporation S5520UR/S5520UR, BIOS S5500.86B.01.00.0050.050620101605 05/06/2010 RIP: e030:device_offline+0x9/0xb0 Code: 77 24 00 e9 ce fe ff ff 48 8b 13 e9 68 ff ff ff 48 8b 13 e9 29 ff ff ff 48 8b 13 e9 ea fe ff ff 90 66 66 66 66 90 41 54 55 53 <f6> 87 d8 02 00 00 01 0f 85 88 00 00 00 48 c7 c2 20 09 60 81 31 f6 RSP: e02b:ffffc90040f27e80 EFLAGS: 00010203 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: ffff8801f3800000 RSI: ffffc90040f27e70 RDI: 0000000000000000 RBP: 0000000000000000 R08: ffffffff820e47b3 R09: 0000000000000000 R10: 0000000000007ff0 R11: 0000000000000000 R12: ffffffff822e6d30 R13: dead000000000200 R14: dead000000000100 R15: ffffffff8158b4e0 FS: 00007ffa595158c0(0000) GS:ffff8801f39c0000(0000) knlGS:0000000000000000 CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000000002d8 CR3: 00000001d9602000 CR4: 0000000000002660 Call Trace: handle_vcpu_hotplug_event+0xb5/0xc0 xenwatch_thread+0x80/0x140 ? wait_woken+0x80/0x80 kthread+0x112/0x130 ? kthread_create_worker_on_cpu+0x40/0x40 ret_from_fork+0x3a/0x50This happens because
handle_vcpu_hotplug_eventis called twice. In the first iterationcpu_presentis still true, in the second iterationcpu_presentis false which causesget_cpu_deviceto return NULL. In case of cpu#0,cpu_onlineis apparently always true.Fix this crash by checking if the cpu can be hotplugged, which is false for a cpu that was just removed.
Also check if the cpu was actually offlined by
device_remove, otherwise leave thecpu_presentstate as it is.Signed-off-by Olaf Hering <[email protected]>--- drivers/xen/cpu_hotplug.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/xen/cpu_hotplug.c +1
-0@@ -19,11 +19,15 @@ static void enable_hotplug_cpu(int cpu)static void disable_hotplug_cpu (int cpu) { +if (!cpu_is_hotpluggable (cpu))
drivers/xen/cpu_hotplug.c static void enable_hotplug_cpu(int cpu) · line 32
Quoted 10 lines
drivers/xen/cpu_hotplug.c +3
-0+return ;if (cpu_online (cpu)) {lock_device_hotplug ();device_offline (get_cpu_device (cpu));unlock_device_hotplug (); } +if (cpu_online (cpu)) +return ;if (cpu_present (cpu))xen_arch_unregister_cpu (cpu);
Could you merge the two if conditions?
if (!cpu_online(cpu) && cpu_present(cpu))
xen_arch_unregister_cpu(cpu);
And while not really important, as we are called in the xenstore watch thread only, it might be a good idea to move the first cpu_online() test into the lock, i.e.:
lock_device_hotplug();
if (cpu_online(cpu))
device_offline(get_cpu_device(cpu));
unlock_device_hotplug();
This will make the code robust against reentry.
Juergen
Am Fri, 7 Sep 2018 09:48:28 +0200
schrieb Juergen Gross <[email protected]>:
Quoted 9 lines · Olaf Hering
drivers/xen/cpu_hotplug.c static void enable_hotplug_cpu(int cpu) · line 32
Quoted 4 lines
drivers/xen/cpu_hotplug.c +2
-0+if (cpu_online (cpu)) +return ;if (cpu_present (cpu))xen_arch_unregister_cpu (cpu);Could you merge the two if conditions?
if (!cpu_online(cpu) &&cpu_present(cpu))xen_arch_unregister_cpu(cpu);
Is that any different, beside being wrong, from what the patch actually does? It would still clear the present bit later on.
Olaf
Juergen Gross
maintainerQuoted 13 lines · Olaf Hering
Am Fri, 7 Sep 2018 09:48:28 +0200
schrieb Juergen Gross <[email protected]>:Quoted 9 lines · Olaf Hering
drivers/xen/cpu_hotplug.c static void enable_hotplug_cpu(int cpu) · line 32
Quoted 4 lines
drivers/xen/cpu_hotplug.c +2
-0+if (cpu_online (cpu)) +return ;if (cpu_present (cpu))xen_arch_unregister_cpu (cpu);Could you merge the two if conditions?
if (!cpu_online(cpu) &&cpu_present(cpu))xen_arch_unregister_cpu(cpu);
Quoted 1 line
Is that any different, beside being wrong, from what the patch actually does?
No. Just a matter of style.
Quoted 1 line
It would still clear the present bit later on.
This should be part of the if clause, of course.
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Juergen Gross
maintainerQuoted 13 lines · Olaf Hering
Am Fri, 7 Sep 2018 09:48:28 +0200
schrieb Juergen Gross <[email protected]>:Quoted 9 lines · Olaf Hering
drivers/xen/cpu_hotplug.c static void enable_hotplug_cpu(int cpu) · line 32
Quoted 4 lines
drivers/xen/cpu_hotplug.c +2
-0+if (cpu_online (cpu)) +return ;if (cpu_present (cpu))xen_arch_unregister_cpu (cpu);Could you merge the two if conditions?
if (!cpu_online(cpu) &&cpu_present(cpu))xen_arch_unregister_cpu(cpu);
Quoted 1 line
Is that any different, beside being wrong, from what the patch actually does?
No. Just a matter of style.
Quoted 1 line
It would still clear the present bit later on.
This should be part of the if clause, of course.
Juergen
Am Fri, 7 Sep 2018 09:48:28 +0200
schrieb Juergen Gross <[email protected]>:
Quoted 9 lines · Olaf Hering
drivers/xen/cpu_hotplug.c static void enable_hotplug_cpu(int cpu) · line 32
Quoted 4 lines
drivers/xen/cpu_hotplug.c +2
-0+if (cpu_online (cpu)) +return ;if (cpu_present (cpu))xen_arch_unregister_cpu (cpu);Could you merge the two if conditions?
if (!cpu_online(cpu) &&cpu_present(cpu))xen_arch_unregister_cpu(cpu);
Is that any different, beside being wrong, from what the patch actually does? It would still clear the present bit later on.
Olaf
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 52 lines · Olaf Hering
The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0:
BUG: unable to handle kernel NULL pointer dereference at 00000000000002d8 PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga9462db-default #1 openSUSE Tumbleweed (unreleased) Hardware name: Intel Corporation S5520UR/S5520UR, BIOS S5500.86B.01.00.0050.050620101605 05/06/2010 RIP: e030:device_offline+0x9/0xb0 Code: 77 24 00 e9 ce fe ff ff 48 8b 13 e9 68 ff ff ff 48 8b 13 e9 29 ff ff ff 48 8b 13 e9 ea fe ff ff 90 66 66 66 66 90 41 54 55 53 <f6> 87 d8 02 00 00 01 0f 85 88 00 00 00 48 c7 c2 20 09 60 81 31 f6 RSP: e02b:ffffc90040f27e80 EFLAGS: 00010203 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: ffff8801f3800000 RSI: ffffc90040f27e70 RDI: 0000000000000000 RBP: 0000000000000000 R08: ffffffff820e47b3 R09: 0000000000000000 R10: 0000000000007ff0 R11: 0000000000000000 R12: ffffffff822e6d30 R13: dead000000000200 R14: dead000000000100 R15: ffffffff8158b4e0 FS: 00007ffa595158c0(0000) GS:ffff8801f39c0000(0000) knlGS:0000000000000000 CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000000002d8 CR3: 00000001d9602000 CR4: 0000000000002660 Call Trace: handle_vcpu_hotplug_event+0xb5/0xc0 xenwatch_thread+0x80/0x140 ? wait_woken+0x80/0x80 kthread+0x112/0x130 ? kthread_create_worker_on_cpu+0x40/0x40 ret_from_fork+0x3a/0x50This happens because
handle_vcpu_hotplug_eventis called twice. In the first iterationcpu_presentis still true, in the second iterationcpu_presentis false which causesget_cpu_deviceto return NULL. In case of cpu#0,cpu_onlineis apparently always true.Fix this crash by checking if the cpu can be hotplugged, which is false for a cpu that was just removed.
Also check if the cpu was actually offlined by
device_remove, otherwise leave thecpu_presentstate as it is.Signed-off-by Olaf Hering <[email protected]>--- drivers/xen/cpu_hotplug.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/xen/cpu_hotplug.c +2
-0@@ -19,11 +19,15 @@ static void enable_hotplug_cpu(int cpu)static void disable_hotplug_cpu (int cpu) { +if (!cpu_is_hotpluggable (cpu)) +return ;
drivers/xen/cpu_hotplug.c static void enable_hotplug_cpu(int cpu) · line 33
Quoted 10 lines
drivers/xen/cpu_hotplug.c +2
-0if (cpu_online (cpu)) {lock_device_hotplug ();device_offline (get_cpu_device (cpu));unlock_device_hotplug (); } +if (cpu_online (cpu)) +return ;if (cpu_present (cpu))xen_arch_unregister_cpu (cpu);
You don't get a warning in xen_init_lock_cpu() for CPU0?
Also, as a side question --- what is the purpose of 'xl vcpu-set <domid> 0'?
-boris
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 52 lines · Olaf Hering
The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0:
BUG: unable to handle kernel NULL pointer dereference at 00000000000002d8 PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga9462db-default #1 openSUSE Tumbleweed (unreleased) Hardware name: Intel Corporation S5520UR/S5520UR, BIOS S5500.86B.01.00.0050.050620101605 05/06/2010 RIP: e030:device_offline+0x9/0xb0 Code: 77 24 00 e9 ce fe ff ff 48 8b 13 e9 68 ff ff ff 48 8b 13 e9 29 ff ff ff 48 8b 13 e9 ea fe ff ff 90 66 66 66 66 90 41 54 55 53 <f6> 87 d8 02 00 00 01 0f 85 88 00 00 00 48 c7 c2 20 09 60 81 31 f6 RSP: e02b:ffffc90040f27e80 EFLAGS: 00010203 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: ffff8801f3800000 RSI: ffffc90040f27e70 RDI: 0000000000000000 RBP: 0000000000000000 R08: ffffffff820e47b3 R09: 0000000000000000 R10: 0000000000007ff0 R11: 0000000000000000 R12: ffffffff822e6d30 R13: dead000000000200 R14: dead000000000100 R15: ffffffff8158b4e0 FS: 00007ffa595158c0(0000) GS:ffff8801f39c0000(0000) knlGS:0000000000000000 CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000000002d8 CR3: 00000001d9602000 CR4: 0000000000002660 Call Trace: handle_vcpu_hotplug_event+0xb5/0xc0 xenwatch_thread+0x80/0x140 ? wait_woken+0x80/0x80 kthread+0x112/0x130 ? kthread_create_worker_on_cpu+0x40/0x40 ret_from_fork+0x3a/0x50This happens because
handle_vcpu_hotplug_eventis called twice. In the first iterationcpu_presentis still true, in the second iterationcpu_presentis false which causesget_cpu_deviceto return NULL. In case of cpu#0,cpu_onlineis apparently always true.Fix this crash by checking if the cpu can be hotplugged, which is false for a cpu that was just removed.
Also check if the cpu was actually offlined by
device_remove, otherwise leave thecpu_presentstate as it is.Signed-off-by Olaf Hering <[email protected]>--- drivers/xen/cpu_hotplug.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/xen/cpu_hotplug.c +2
-0@@ -19,11 +19,15 @@ static void enable_hotplug_cpu(int cpu)static void disable_hotplug_cpu (int cpu) { +if (!cpu_is_hotpluggable (cpu)) +return ;
drivers/xen/cpu_hotplug.c static void enable_hotplug_cpu(int cpu) · line 33
Quoted 10 lines
drivers/xen/cpu_hotplug.c +2
-0if (cpu_online (cpu)) {lock_device_hotplug ();device_offline (get_cpu_device (cpu));unlock_device_hotplug (); } +if (cpu_online (cpu)) +return ;if (cpu_present (cpu))xen_arch_unregister_cpu (cpu);
You don't get a warning in xen_init_lock_cpu() for CPU0?
Also, as a side question --- what is the purpose of 'xl vcpu-set <domid> 0'?
-boris
Am Fri, 7 Sep 2018 09:33:20 -0400
schrieb Boris Ostrovsky <[email protected]>:
Quoted 1 line
what is the purpose of 'xl vcpu-set <domid> 0'?
Likely just a script that went wrong. But that command should not break the dom0.
Olaf
Am Fri, 7 Sep 2018 09:33:20 -0400
schrieb Boris Ostrovsky <[email protected]>:
Quoted 1 line
what is the purpose of 'xl vcpu-set <domid> 0'?
Likely just a script that went wrong. But that command should not break the dom0.
Olaf
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 31 lines · Olaf Hering
The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0:
BUG: unable to handle kernel NULL pointer dereference at 00000000000002d8 PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga9462db-default #1 openSUSE Tumbleweed (unreleased) Hardware name: Intel Corporation S5520UR/S5520UR, BIOS S5500.86B.01.00.0050.050620101605 05/06/2010 RIP: e030:device_offline+0x9/0xb0 Code: 77 24 00 e9 ce fe ff ff 48 8b 13 e9 68 ff ff ff 48 8b 13 e9 29 ff ff ff 48 8b 13 e9 ea fe ff ff 90 66 66 66 66 90 41 54 55 53 <f6> 87 d8 02 00 00 01 0f 85 88 00 00 00 48 c7 c2 20 09 60 81 31 f6 RSP: e02b:ffffc90040f27e80 EFLAGS: 00010203 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: ffff8801f3800000 RSI: ffffc90040f27e70 RDI: 0000000000000000 RBP: 0000000000000000 R08: ffffffff820e47b3 R09: 0000000000000000 R10: 0000000000007ff0 R11: 0000000000000000 R12: ffffffff822e6d30 R13: dead000000000200 R14: dead000000000100 R15: ffffffff8158b4e0 FS: 00007ffa595158c0(0000) GS:ffff8801f39c0000(0000) knlGS:0000000000000000 CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000000002d8 CR3: 00000001d9602000 CR4: 0000000000002660 Call Trace: handle_vcpu_hotplug_event+0xb5/0xc0 xenwatch_thread+0x80/0x140 ? wait_woken+0x80/0x80 kthread+0x112/0x130 ? kthread_create_worker_on_cpu+0x40/0x40 ret_from_fork+0x3a/0x50This happens because
handle_vcpu_hotplug_eventis called twice. In the first iterationcpu_presentis still true, in the second iterationcpu_presentis false which causesget_cpu_deviceto return NULL. In case of cpu#0,cpu_onlineis apparently always true.
Quoted 7 lines
Fix this crash by checking if the cpu can be hotplugged, which is false for a cpu that was just removed.
Also check if the cpu was actually offlined by
device_remove, otherwise leave thecpu_presentstate as it is.Signed-off-by Olaf Hering <[email protected]>
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 31 lines · Olaf Hering
The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0:
BUG: unable to handle kernel NULL pointer dereference at 00000000000002d8 PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga9462db-default #1 openSUSE Tumbleweed (unreleased) Hardware name: Intel Corporation S5520UR/S5520UR, BIOS S5500.86B.01.00.0050.050620101605 05/06/2010 RIP: e030:device_offline+0x9/0xb0 Code: 77 24 00 e9 ce fe ff ff 48 8b 13 e9 68 ff ff ff 48 8b 13 e9 29 ff ff ff 48 8b 13 e9 ea fe ff ff 90 66 66 66 66 90 41 54 55 53 <f6> 87 d8 02 00 00 01 0f 85 88 00 00 00 48 c7 c2 20 09 60 81 31 f6 RSP: e02b:ffffc90040f27e80 EFLAGS: 00010203 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: ffff8801f3800000 RSI: ffffc90040f27e70 RDI: 0000000000000000 RBP: 0000000000000000 R08: ffffffff820e47b3 R09: 0000000000000000 R10: 0000000000007ff0 R11: 0000000000000000 R12: ffffffff822e6d30 R13: dead000000000200 R14: dead000000000100 R15: ffffffff8158b4e0 FS: 00007ffa595158c0(0000) GS:ffff8801f39c0000(0000) knlGS:0000000000000000 CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000000002d8 CR3: 00000001d9602000 CR4: 0000000000002660 Call Trace: handle_vcpu_hotplug_event+0xb5/0xc0 xenwatch_thread+0x80/0x140 ? wait_woken+0x80/0x80 kthread+0x112/0x130 ? kthread_create_worker_on_cpu+0x40/0x40 ret_from_fork+0x3a/0x50This happens because
handle_vcpu_hotplug_eventis called twice. In the first iterationcpu_presentis still true, in the second iterationcpu_presentis false which causesget_cpu_deviceto return NULL. In case of cpu#0,cpu_onlineis apparently always true.
Quoted 7 lines
Fix this crash by checking if the cpu can be hotplugged, which is false for a cpu that was just removed.
Also check if the cpu was actually offlined by
device_remove, otherwise leave thecpu_presentstate as it is.Signed-off-by Olaf Hering <[email protected]>
Juergen
Quoted 2 lines · Juergen Gross
Reviewed-by Juergen Gross <[email protected]>
So is it v3 or v4, you gave R-b for both. (I slightly prefer v3, but either is fine).
-boris
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 2 lines · Juergen Gross
Reviewed-by Juergen Gross <[email protected]>
So is it v3 or v4, you gave R-b for both. (I slightly prefer v3, but either is fine).
-boris
Juergen Gross
maintainerQuoted 6 lines · Boris Ostrovsky
Quoted 2 lines · Juergen Gross
Reviewed-by Juergen Gross <[email protected]>So is it v3 or v4, you gave R-b for both. (I slightly prefer v3, but either is fine).
V4 is better as it does the online test only after acquiring the hotplug lock.
Juergen
Juergen Gross
maintainerQuoted 6 lines · Boris Ostrovsky
Quoted 2 lines · Juergen Gross
Reviewed-by Juergen Gross <[email protected]>So is it v3 or v4, you gave R-b for both. (I slightly prefer v3, but either is fine).
V4 is better as it does the online test only after acquiring the hotplug lock.
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel