Skip to contentSkip to conversation

wimax: i2400m: remove unnecessary unlikely()

PATCH New Igor Stoppa 1 participant 1 message Sep 7, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wimax: i2400m: remove unnecessary unlikely()

WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another.

---
 drivers/net/wimax/i2400m/tx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/wimax/i2400m/tx.c +1 -2
index f20886ade1cc..59c70d928249 100644
@@ -655,8 +655,7 @@ void i2400m_tx_close(struct i2400m *i2400m)
 	padding = aligned_size - tx_msg_moved->size;
 	if (padding > 0) {
 		pad_buf = i2400m_tx_fifo_push(i2400m, padding, 0, 0);
-		if (unlikely(WARN_ON(pad_buf == NULL
-				     || pad_buf == TAIL_FULL))) {
+		if (WARN_ON(!pad_buf || pad_buf == TAIL_FULL)) {
 			/* This should not happen -- append should verify
 			 * there is always space left at least to append
 			 * tx_block_size */
Signature · 1 line
2.17.1