Skip to contentSkip to conversation

mtd: nand: denali: fix unaligned cache operation warnings on ARMv7 SoCs

PATCH New Masahiro Yamada 3 participants 4 messages Sep 10, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: nand: denali: fix unaligned cache operation warnings on ARMv7 SoCs

If the OOB size is not multiple of the cache line size, the ARMv7 cache operation still warns "Misaligned operation at range".

The real cache coherency problem was fixed by commit e3332e1a1a04 ("Make kmalloc'ed memory really DMA-safe"). Now it is the matter of the warning messages.

=> nand info

Device 0: nand0, sector size 256 KiB
Page size 4096 b
OOB size 224 b
Erase size 262144 b
subpagesize 4096 b
options 0x00104200
bbt options 0x00060000
=> nand dump 0
CACHE: Misaligned operation at range [9fb15280, 9fb16360]
CACHE: Misaligned operation at range [9fb15280, 9fb16360]
CACHE: Misaligned operation at range [9fb15280, 9fb16360]
CACHE: Misaligned operation at range [9fb15280, 9fb16360]
...

---

 drivers/mtd/nand/denali.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/mtd/nand/denali.c +4 -0
index 7302c37..d1cac06 100644
@@ -21,6 +21,8 @@ static dma_addr_t dma_map_single(void *dev, void *ptr, size_t size,
 {
 	unsigned long addr = (unsigned long)ptr;
 
+	size = ALIGN(size, ARCH_DMA_MINALIGN);
+
 	if (dir == DMA_FROM_DEVICE)
 		invalidate_dcache_range(addr, addr + size);
 	else
@@ -32,6 +34,8 @@ static dma_addr_t dma_map_single(void *dev, void *ptr, size_t size,
 static void dma_unmap_single(void *dev, dma_addr_t addr, size_t size,
 			     enum dma_data_direction dir)
 {
+	size = ALIGN(size, ARCH_DMA_MINALIGN);
+
 	if (dir != DMA_TO_DEVICE)
 		invalidate_dcache_range(addr, addr + size);
 }
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 mtd: nand: denali: fix unaligned cache operation warnings on ARMv7 SoCs

Quoted 6 lines · Masahiro Yamada

If the OOB size is not multiple of the cache line size, the ARMv7 cache operation still warns "Misaligned operation at range".

The real cache coherency problem was fixed by commit e3332e1a1a04 ("Make kmalloc'ed memory really DMA-safe"). Now it is the matter of the warning messages.

The cache ops won't happen if the address isn't aligned, so this is needed on armv7a anyway. It's not just about silencing the messages, this patch is actually required.

Quoted 46 lines

=> nand info

Device 0: nand0, sector size 256 KiB
Page size 4096 b
OOB size 224 b
Erase size 262144 b
subpagesize 4096 b
options 0x00104200
bbt options 0x00060000
=> nand dump 0
CACHE: Misaligned operation at range [9fb15280, 9fb16360]
CACHE: Misaligned operation at range [9fb15280, 9fb16360]
CACHE: Misaligned operation at range [9fb15280, 9fb16360]
CACHE: Misaligned operation at range [9fb15280, 9fb16360]
...

---

 drivers/mtd/nand/denali.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/mtd/nand/denali.c +4 -0
index 7302c37..d1cac06 100644
@@ -21,6 +21,8 @@ static dma_addr_t dma_map_single(void *dev, void *ptr, size_t size,
 {
 	unsigned long addr = (unsigned long)ptr;
 
+	size = ALIGN(size, ARCH_DMA_MINALIGN);
+
 	if (dir == DMA_FROM_DEVICE)
 		invalidate_dcache_range(addr, addr + size);
 	else
@@ -32,6 +34,8 @@ static dma_addr_t dma_map_single(void *dev, void *ptr, size_t size,
 static void dma_unmap_single(void *dev, dma_addr_t addr, size_t size,
 			     enum dma_data_direction dir)
 {
+	size = ALIGN(size, ARCH_DMA_MINALIGN);
+
 	if (dir != DMA_TO_DEVICE)
 		invalidate_dcache_range(addr, addr + size);
 }
Signature · 2 lines
Best regards,
Marek Vasut
#2 lore raw

PATCH 1/1 mtd: nand: denali: fix unaligned cache operation warnings on ARMv7 SoCs

2018-09-10 22:26 GMT+09:00 Marek Vasut <[email protected]>:

Quoted 11 lines · Masahiro Yamada
Quoted 6 lines

If the OOB size is not multiple of the cache line size, the ARMv7 cache operation still warns "Misaligned operation at range".

The real cache coherency problem was fixed by commit e3332e1a1a04 ("Make kmalloc'ed memory really DMA-safe"). Now it is the matter of the warning messages.

The cache ops won't happen if the address isn't aligned, so this is needed on armv7a anyway. It's not just about silencing the messages, this patch is actually required.

You are right.
I was misunderstanding.

I will reword the patch description. Thanks!

Signature · 2 lines
Best Regards
Masahiro Yamada
#3 lore raw

PATCH 1/1 mtd: nand: denali: fix unaligned cache operation warnings on ARMv7 SoCs

In reply to Masahiro Yamada
Quoted 23 lines · Masahiro Yamada

If the OOB size is not multiple of the cache line size, the ARMv7 cache operation still warns "Misaligned operation at range".

The real cache coherency problem was fixed by commit e3332e1a1a04 ("Make kmalloc'ed memory really DMA-safe"). Now it is the matter of the warning messages.

=> nand info

Device 0: nand0, sector size 256 KiB
Page size 4096 b
OOB size 224 b
Erase size 262144 b
subpagesize 4096 b
options 0x00104200
bbt options 0x00060000
=> nand dump 0
CACHE: Misaligned operation at range [9fb15280, 9fb16360]
CACHE: Misaligned operation at range [9fb15280, 9fb16360]
CACHE: Misaligned operation at range [9fb15280, 9fb16360]
CACHE: Misaligned operation at range [9fb15280, 9fb16360]
...

Quoted 2 lines

After re-wording the commit message based on Marek's email, applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180910/34bbff15/attachment.sig>