kgdboc: Fix restrict error
Subsystems (2)
PATCH 1/1 kgdboc: Fix restrict error
There's an error when compiled with restrict:
drivers/tty/serial/kgdboc.c: In function ‘configure_kgdboc’:drivers/tty/serial/kgdboc.c:137:2: error: ‘strcpy’ source argument is the same as destination [-Werror=restrict]
strcpy(config, opt);
^~~~~~~~~~~~~~~~~~~
As the error implies, this is from trying to use config as both source and destination. Drop the call to the function where config is the argument since nothing else happens in the function.
--- drivers/tty/serial/kgdboc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/tty/serial/kgdboc.c +2 -4
@@ -154,15 +154,13 @@ static int configure_kgdboc(void) {struct tty_driver *p;int tty_line =0 ; -int err; +int err = -ENODEV ;char *cptr = config;struct console *cons; - err =kgdboc_option_setup (config); -if (err || !strlen (config) ||isspace (config[0 ])) +if (!strlen (config) ||isspace (config[0 ])) goto noconfig; - err = -ENODEV ; kgdboc_io_ops.is_console =0 ; kgdb_tty_driver =NULL ;
Signature · 1 line
2.17.1
Quoted 8 lines · Laura Abbott
There's an error when compiled with restrict:
drivers/tty/serial/kgdboc.c: In function ‘configure_kgdboc’:drivers/tty/serial/kgdboc.c:137:2: error: ‘strcpy’ source argument is the same as destination [-Werror=restrict]
strcpy(config, opt);
^~~~~~~~~~~~~~~~~~~
Quoted 5 lines
As the error implies, this is from trying to use config as both source and destination. Drop the call to the function where config is the argument since nothing else happens in the function.
Signed-off-by Laura Abbott <[email protected]>
Quoted 29 lines
--- drivers/tty/serial/kgdboc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/tty/serial/kgdboc.c +2
-4@@ -154,15 +154,13 @@ static int configure_kgdboc(void) {struct tty_driver *p;int tty_line =0 ; -int err; +int err = -ENODEV ;char *cptr = config;struct console *cons; - err =kgdboc_option_setup (config); -if (err || !strlen (config) ||isspace (config[0 ])) +if (!strlen (config) ||isspace (config[0 ])) goto noconfig; - err = -ENODEV ; kgdboc_io_ops.is_console =0 ; kgdb_tty_driver =NULL ;Signature · 1 line
2.17.1