Skip to contentSkip to conversation

net: dsa: b53: Only call b53_port_event() for SGMII ports

PATCH Applied Florian Fainelli 2 participants 2 messages Sep 10, 2018 – Sep 12, 2018

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dsa: b53: Only call b53_port_event() for SGMII ports

Built-in PHY ports are still being polled, avoid generating spurious and duplicate events which the PHY library resolves through polling anyways.

Fixes 0e01491de646 ("net: dsa: b53: Add SerDes support")
---
 drivers/net/dsa/b53/b53_srab.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/dsa/b53/b53_srab.c +2 -1
index b0ed81876bae..321052732799 100644
@@ -373,7 +373,8 @@ static irqreturn_t b53_srab_port_thread(int irq, void *dev_id)
 	struct b53_srab_port_priv *port = dev_id;
 	struct b53_device *dev = port->dev;
 
-	b53_port_event(dev->ds, port->num);
+	if (port->mode == PHY_INTERFACE_MODE_SGMII)
+		b53_port_event(dev->ds, port->num);
 
 	return IRQ_HANDLED;
 }
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw

From: Florian Fainelli <[email protected]>
Date: Mon, 10 Sep 2018 16:47:07 -0700

Quoted 6 lines

Built-in PHY ports are still being polled, avoid generating spurious and duplicate events which the PHY library resolves through polling anyways.

Fixes 0e01491de646 ("net: dsa: b53: Add SerDes support")

Applied, thanks Florian.