Skip to contentSkip to conversation

scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx

PATCH Applied Masanari Iida 3 participants 3 messages Sep 11, 2018 – Sep 27, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx

Default value of ql2xasynctmfenable for qla2xxx driver was set to 1 in commit 043dc1d7e8501.
But comment in MODULE_PARAM_DESC was not modified.

---
 drivers/scsi/qla2xxx/qla_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_os.c +1 -1
index 42b8f0d3e580..fe5404be73c5 100644
@@ -204,7 +204,7 @@ int ql2xasynctmfenable = 1;
 module_param(ql2xasynctmfenable, int, S_IRUGO);
 MODULE_PARM_DESC(ql2xasynctmfenable,
 		"Enables issue of TM IOCBs asynchronously via IOCB mechanism"
-		"Default is 0 - Issue TM IOCBs via mailbox mechanism.");
+		"Default is 1 - Issue TM IOCBs via mailbox mechanism.");
 
 int ql2xdontresethba;
 module_param(ql2xdontresethba, int, S_IRUGO|S_IWUSR);
Signature · 1 line
2.19.0
Acked-by on v1 1/1
#1 lore raw
Quoted 28 lines · Masanari Iida

External Email

Default value of ql2xasynctmfenable for qla2xxx driver was set to 1 in commit 043dc1d7e8501.
But comment in MODULE_PARAM_DESC was not modified.

---
drivers/scsi/qla2xxx/qla_os.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_os.c +1 -2
index 42b8f0d3e580..fe5404be73c5 100644
@@ -204,7 +204,7 @@ int ql2xasynctmfenable = 1;
 module_param(ql2xasynctmfenable, int, S_IRUGO);
 MODULE_PARM_DESC(ql2xasynctmfenable,
               "Enables issue of TM IOCBs asynchronously via IOCB mechanism"
-               "Default is 0 - Issue TM IOCBs via mailbox mechanism.");
+               "Default is 1 - Issue TM IOCBs via mailbox mechanism.");
 
 int ql2xdontresethba;
 module_param(ql2xdontresethba, int, S_IRUGO|S_IWUSR);
--
Quoted 2 lines

2.19.0

Thanks for the patch.

-Himanshu

#2 lore raw
In reply to Masanari Iida

Masanari,

Quoted 3 lines

Default value of ql2xasynctmfenable for qla2xxx driver was set to 1 in commit 043dc1d7e8501. But comment in MODULE_PARAM_DESC was not modified.

Applied to 4.20/scsi-queue. Thank you!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering