runner/resultgen: More checking if subtests should exist
PATCH 1/2 runner/resultgen: More checking if subtests should exist
If a test with subtests just exits immediately, or the test binary doesn't exist at all (as is sometimes the case with kms_chamelium), the existence of subtests doesn't end up in the execution journal. As was done for timeouts in a797cbf6918a ("runner/resultgen: Be more robust with incomplete tests"), check if we were attempting to run a subtest before attributing a 'notrun' result to an incorrect field.
--- runner/resultgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
runner/resultgen.c +1 -1
@@ -778,7 +778,7 @@ static void fill_from_journal(int fd,add_runtime (obj, time);/* If no subtests, the test result node also gets the runtime */ -if (subtests->size ==0 ) { +if (subtests->size ==0 && entry->subtest_count ==0 ) { obj =get_or_create_json_object (tests, piglit_name);add_runtime (obj, time); }
Signature · 6 lines
2.14.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH 2/2 runner: Seek to the end to get to the end of kmsg
When draining the rest of kmsg records, read the compare record from the end of kmsg or you get incomplete dmesg fields in the results.
--- runner/executor.c | 1 + 1 file changed, 1 insertion(+)
runner/executor.c +1 -0
@@ -247,6 +247,7 @@ static void dump_dmesg(int kmsgfd, int outfd)if (comparefd <0 )return ; +lseek (comparefd,0 ,SEEK_END );if (fcntl (kmsgfd,F_SETFL ,O_NONBLOCK ))return ;
Signature · 6 lines
2.14.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [igt-dev] [PATCH i-g-t 2/2] runner: Seek to the end to get to the end of kmsg
Quoted 6 lines · Petri Latvala
When draining the rest of kmsg records, read the compare record from the end of kmsg or you get incomplete dmesg fields in the results.
Signed-off-by Petri Latvala <[email protected]>Cc Arkadiusz Hiler <[email protected]>Cc Martin Peres <[email protected]>
on both
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] runner/resultgen: More checking if subtests should exist
In reply to Petri Latvala== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,1/2] runner/resultgen: More checking if subtests should exist
URL : https://patchwork.freedesktop.org/series/49474/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4791 -> IGTPW_1821 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49474/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1821:
=== IGT changes ===
==== Possible regressions ====
igt@kms_psr@primary_mmap_gtt:
{fi-cnl-u}: NOTRUN -> FAIL +3== Known issues ==
Here are the changes found in IGTPW_1821 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@amdgpu/amd_prime@amd-to-i915:
fi-kbl-8809g: NOTRUN -> FAIL (fdo#107341)
igt@drv_module_reload@basic-reload:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106248, fdo#106725)
igt@drv_selftest@live_guc:
fi-cfl-guc: PASS -> DMESG-WARN (fdo#107258)
igt@gem_exec_suspend@basic-s3:
fi-cfl-8109u: PASS -> DMESG-WARN (fdo#107345)
fi-kbl-soraka: NOTRUN -> INCOMPLETE (fdo#107556, fdo#107774)
igt@kms_flip@basic-flip-vs-dpms:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106000)
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191) +1
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-cfl-8109u: PASS -> INCOMPLETE (fdo#106070)
igt@kms_psr@primary_page_flip:
fi-kbl-7560u: PASS -> FAIL (fdo#107336)
==== Possible fixes ====
igt@amdgpu/amd_basic@cs-sdma:
fi-skl-6700k2: FAIL (fdo#107888) -> SKIP +7
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
igt@kms_psr@primary_page_flip:
fi-icl-u: FAIL (fdo#107383) -> PASS +3
fi-whl-u: FAIL (fdo#107336) -> PASS {name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
fdo#107345 https://bugs.freedesktop.org/show_bug.cgi?id=107345
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#107774 https://bugs.freedesktop.org/show_bug.cgi?id=107774
fdo#107888 https://bugs.freedesktop.org/show_bug.cgi?id=107888
== Participating hosts (46 -> 41) ==
Additional (5): fi-kbl-soraka fi-cnl-u fi-blb-e6850 fi-glk-dsi fi-kbl-8809g
Missing (10): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-guc fi-hsw-4770 fi-cnl-psr fi-skl-iommu fi-elk-e7500 fi-bdw-samus
== Build changes ==
* IGT: IGT_4636 -> IGTPW_1821
CI_DRM_4791: 07cf212bc704357ee60aba52ec40bab538222040 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1821: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1821/
IGT_4636: 40de31df52ffed5e392d607a83e3aea4efb150e6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1821/issues.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] runner/resultgen: More checking if subtests should exist
In reply to Petri Latvala== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,1/2] runner/resultgen: More checking if subtests should exist
URL : https://patchwork.freedesktop.org/series/49474/
State : failure
== Summary ==
= CI Bug Log - changes from IGT_4636_full -> IGTPW_1821_full =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_1821_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_1821_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49474/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1821_full:
=== IGT changes ===
==== Possible regressions ====
igt@gem_eio@in-flight-contexts-immediate:
shard-glk: PASS -> FAIL
igt@kms_rotation_crc@sprite-rotation-270:
shard-glk: NOTRUN -> DMESG-FAIL
==== Warnings ====
igt@perf_pmu@rc6:
shard-kbl: SKIP -> PASS
igt@tools_test@tools_test:
shard-apl: PASS -> SKIP
shard-glk: PASS -> SKIP
shard-snb: PASS -> SKIP
shard-hsw: PASS -> SKIP +1
shard-kbl: PASS -> SKIP== Known issues ==
Here are the changes found in IGTPW_1821_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: PASS -> DMESG-WARN (fdo#105763)
igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt:
shard-glk: PASS -> FAIL (fdo#103167) +1
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@gem_exec_reuse@baggage:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
shard-glk: INCOMPLETE (k.org#198133, fdo#103359) -> PASS +1
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: FAIL (fdo#106641) -> PASS
igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
shard-hsw: FAIL (fdo#105767) -> PASS
igt@kms_cursor_legacy@cursor-vs-flip-legacy:
shard-hsw: FAIL (fdo#103355) -> PASS
igt@kms_rotation_crc@sprite-rotation-180:
shard-snb: FAIL (fdo#103925) -> PASS
igt@kms_sysfs_edid_timing:
shard-hsw: WARN (fdo#100047) -> PASS
shard-glk: WARN (fdo#100047) -> PASS fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#105767 https://bugs.freedesktop.org/show_bug.cgi?id=105767
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4636 -> IGTPW_1821
* Linux: CI_DRM_4787 -> CI_DRM_4791
CI_DRM_4787: 6dc8457a2f2093eecb9c6cbb7306fd25bb1664e6 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4791: 07cf212bc704357ee60aba52ec40bab538222040 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1821: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1821/
IGT_4636: 40de31df52ffed5e392d607a83e3aea4efb150e6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1821/shards.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev