llc: avoid blocking in llc_sap_close()
Subsystems (3)
PATCH 1/1 llc: avoid blocking in llc_sap_close()
llc_sap_close() is called by llc_sap_put() which could be called in BH context in llc_rcv(). We can't block in BH.
There is no reason to block it here, kfree_rcu() should be sufficient.
Signed-off-by Cong Wang <[email protected]>
--- include/net/llc.h | 1 + net/llc/llc_core.c | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-)
include/net/llc.h +1 -0
@@ -66,6 +66,7 @@ struct llc_sap {int sk_count;struct hlist_nulls_head sk_laddr_hash[LLC_SK_LADDR_HASH_ENTRIES ];struct hlist_head sk_dev_hash[LLC_SK_DEV_HASH_ENTRIES ]; +struct rcu_head rcu; }; static inline
net/llc/llc_core.c +1 -3
@@ -127,9 +127,7 @@ void llc_sap_close(struct llc_sap *sap)list_del_rcu (&sap->node);spin_unlock_bh (&llc_sap_list_lock); -synchronize_rcu (); - -kfree (sap); +kfree_rcu (sap, rcu); }static struct packet_type llc_packet_type__read_mostly = {
Signature · 1 line
2.14.4
From: Cong Wang <[email protected]>
Date: Tue, 11 Sep 2018 11:42:06 -0700
Quoted 8 lines
llc_sap_close()is called byllc_sap_put()which could be called in BH context inllc_rcv(). We can't block in BH.There is no reason to block it here,
kfree_rcu()should be sufficient.Signed-off-by Cong Wang <[email protected]>
Applied, thanks Cong.