drm/vkms: Add kerneldoc entry
Haneen Mohammed
reviewerPATCH 1/1 drm/vkms: Add kerneldoc entry
Add an initial kerneldoc entry for vkms with a todo list.
--- Documentation/gpu/drivers.rst | 1 + Documentation/gpu/todo.rst | 12 ------------ Documentation/gpu/vkms.rst | 21 +++++++++++++++++++++ drivers/gpu/drm/vkms/vkms_drv.c | 9 +++++++++ 4 files changed, 31 insertions(+), 12 deletions(-) create mode 100644 Documentation/gpu/vkms.rst
Documentation/gpu/drivers.rst +1 -0
@@ -13,6 +13,7 @@ GPU Driver Documentation tve200 v3d vc4 + vkms bridge/dw-hdmi xen-front
Documentation/gpu/todo.rst +0 -12
@@ -398,18 +398,6 @@ the non-i915 specific modeset tests. Contact: Daniel Vetter -Create a virtual KMS driver for testing (vkms) ----------------------------------------------- - -With all the latest helpers it should be fairly simple to create a virtual KMS -driver useful for testing, or for running X or similar on headless machines -(to be able to still use the GPU). This would be similar to vgem, but aimed at -the modeset side. - -Once the basics are there there's tons of possibilities to extend it. - -Contact: Daniel Vetter - Driver Specific ===============
Documentation/gpu/vkms.rst new file +21 -0
@@ -0,0 +1,21 @@ +========================================== + drm/vkms Virtual Kernel Modesetting +========================================== + +.. kernel-doc:: drivers/gpu/drm/vkms/vkms_drv.c + :doc: vkms (Virtual Kernel Modesetting) + +TODO +==== + +CRC API +------- + +- Optimize CRC computation ``compute_crc()`` and plane blending ``blend()`` + +- Use the alpha value to blend vaddr_src with vaddr_dst instead of + overwriting it in ``blend()``. + +- Add igt test to check cleared alpha value for XRGB plane format. + +- Add igt test to check extreme alpha values i.e. fully opaque and fully transparent (intermediate values are affected by hw-specific rounding modes).
drivers/gpu/drm/vkms/vkms_drv.c +9 -0
@@ -5,6 +5,15 @@* (at your option) any later version. */ +/** +* DOC: vkms (Virtual Kernel Modesetting) +* +* vkms is a software-only model of a kms driver that is useful for testing, +* or for running X (or similar) on headless machines and be able to still +* use the GPU. vkms aims to enable a virtual display without the need for +* a hardware display capability. +*/ +#include <linux/module.h> #include <drm/drm_gem.h> #include <drm/drm_crtc_helper.h>
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 32 lines · Haneen Mohammed
Add an initial kerneldoc entry for vkms with a todo list.
Signed-off-by Haneen Mohammed <[email protected]>--- Documentation/gpu/drivers.rst | 1 + Documentation/gpu/todo.rst | 12 ------------ Documentation/gpu/vkms.rst | 21 +++++++++++++++++++++ drivers/gpu/drm/vkms/vkms_drv.c | 9 +++++++++ 4 files changed, 31 insertions(+), 12 deletions(-) create mode 100644 Documentation/gpu/vkms.rstDocumentation/gpu/drivers.rst +1
-0@@ -13,6 +13,7 @@ GPU Driver Documentation tve200 v3d vc4 + vkms bridge/dw-hdmi xen-frontDocumentation/gpu/todo.rst +0
-1@@ -398,18 +398,6 @@ the non-i915 specific modeset tests. Contact: Daniel Vetter -Create a virtual KMS driver for testing (vkms)
Documentation/gpu/todo.rst the non-i915 specific modeset tests. · line 411
Quoted 10 lines
Documentation/gpu/todo.rst +0
-10----------------------------------------------- - -With all the latest helpers it should be fairly simple to create a virtual KMS -driver useful for testing, or for running X or similar on headless machines -(to be able to still use the GPU). This would be similar to vgem, but aimed at -the modeset side. - -Once the basics are there there's tons of possibilities to extend it. - -Contact: Daniel Vetter
I've changed this to instead point at the vkms todo list, so we still have an entry for this here. And then applied your patch.
Cursor patches also applied now, thanks.
Aside: Do you have any plans to continue working on this, i.e. in need of commit rights?
Cheers, Daniel
Quoted 54 lines
Documentation/gpu/todo.rst +0
-1- Driver Specific ===============Documentation/gpu/vkms.rst new file +21
-0@@ -0,0 +1,21 @@ +========================================== + drm/vkms Virtual Kernel Modesetting +========================================== + +.. kernel-doc:: drivers/gpu/drm/vkms/vkms_drv.c + :doc: vkms (Virtual Kernel Modesetting) + +TODO +==== + +CRC API +------- + +- Optimize CRC computation ``compute_crc()`` and plane blending ``blend()`` + +- Use the alpha value to blend vaddr_src with vaddr_dst instead of + overwriting it in ``blend()``. + +- Add igt test to check cleared alpha value for XRGB plane format. + +- Add igt test to check extreme alpha values i.e. fully opaque and fully transparent (intermediate values are affected by hw-specific rounding modes).drivers/gpu/drm/vkms/vkms_drv.c +9
-0@@ -5,6 +5,15 @@* (at your option) any later version. */ +/** +* DOC: vkms (Virtual Kernel Modesetting) +* +* vkms is a software-only model of a kms driver that is useful for testing, +* or for running X (or similar) on headless machines and be able to still +* use the GPU. vkms aims to enable a virtual display without the need for +* a hardware display capability. +*/ +#include <linux/module.h> #include <drm/drm_gem.h> #include <drm/drm_crtc_helper.h> Signature · 1 line
2.17.1
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Haneen Mohammed
reviewerQuoted 47 lines · Daniel Vetter
Quoted 32 lines · Haneen Mohammed
Add an initial kerneldoc entry for vkms with a todo list.
Signed-off-by Haneen Mohammed <[email protected]>--- Documentation/gpu/drivers.rst | 1 + Documentation/gpu/todo.rst | 12 ------------ Documentation/gpu/vkms.rst | 21 +++++++++++++++++++++ drivers/gpu/drm/vkms/vkms_drv.c | 9 +++++++++ 4 files changed, 31 insertions(+), 12 deletions(-) create mode 100644 Documentation/gpu/vkms.rstDocumentation/gpu/drivers.rst +1
-0@@ -13,6 +13,7 @@ GPU Driver Documentation tve200 v3d vc4 + vkms bridge/dw-hdmi xen-frontDocumentation/gpu/todo.rst +0
-1@@ -398,18 +398,6 @@ the non-i915 specific modeset tests. Contact: Daniel Vetter -Create a virtual KMS driver for testing (vkms)Documentation/gpu/todo.rst the non-i915 specific modeset tests. · line 411
Quoted 10 lines
Documentation/gpu/todo.rst +0
-10----------------------------------------------- - -With all the latest helpers it should be fairly simple to create a virtual KMS -driver useful for testing, or for running X or similar on headless machines -(to be able to still use the GPU). This would be similar to vgem, but aimed at -the modeset side. - -Once the basics are there there's tons of possibilities to extend it. - -Contact: Daniel VetterI've changed this to instead point at the vkms todo list, so we still have an entry for this here. And then applied your patch.
Quoted 6 lines
Cursor patches also applied now, thanks.
Aside: Do you have any plans to continue working on this, i.e. in need of commit rights?
Cheers, Daniel
Thanks!
I still have two patches I didn't submit (suspend/resume, and another that checks if work_struct is queued before calling flush_work()).
I can volunteer to review future patches to vkms, but unfortunately I don't think I'd be at capacity to add new features to vkms anymore.
Thank you so much for all your help!
Haneen
Quoted 39 lines
Quoted 39 lines
Documentation/gpu/todo.rst +0
-1- Driver Specific ===============Documentation/gpu/vkms.rst new file +21
-0@@ -0,0 +1,21 @@ +========================================== + drm/vkms Virtual Kernel Modesetting +========================================== + +.. kernel-doc:: drivers/gpu/drm/vkms/vkms_drv.c + :doc: vkms (Virtual Kernel Modesetting) + +TODO +==== + +CRC API +------- + +- Optimize CRC computation ``compute_crc()`` and plane blending ``blend()`` + +- Use the alpha value to blend vaddr_src with vaddr_dst instead of + overwriting it in ``blend()``. + +- Add igt test to check cleared alpha value for XRGB plane format. + +- Add igt test to check extreme alpha values i.e. fully opaque and fully transparent (intermediate values are affected by hw-specific rounding modes).drivers/gpu/drm/vkms/vkms_drv.c +0
-0@@ -5,6 +5,15 @@* (at your option) any later version. */
Quoted 20 lines
Quoted 15 lines
drivers/gpu/drm/vkms/vkms_drv.c +9
-0+/** +* DOC: vkms (Virtual Kernel Modesetting) +* +* vkms is a software-only model of a kms driver that is useful for testing, +* or for running X (or similar) on headless machines and be able to still +* use the GPU. vkms aims to enable a virtual display without the need for +* a hardware display capability. +*/ +#include <linux/module.h> #include <drm/drm_gem.h> #include <drm/drm_crtc_helper.h> Signature · 1 line
2.17.1Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel