Skip to contentSkip to conversation

drm/i915/icl: Add POWER_DOMAIN_GT_IRQ to ICL DC_OFF_POWER_DOMAINS

PATCH In review José Roberto de Souza 4 participants 6 messages Sep 12, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/icl: Add POWER_DOMAIN_GT_IRQ to ICL DC_OFF_POWER_DOMAINS

Without this gem will not be able to turn off DC states to redunce interruption latency when no sink is being driven by driver.

---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_runtime_pm.c +1 -0
index 480dadb1047b..af8a0b6ee79b 100644
@@ -1978,6 +1978,7 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
 	 */
 #define ICL_DISPLAY_DC_OFF_POWER_DOMAINS (		\
 	ICL_PW_2_POWER_DOMAINS |			\
+	BIT_ULL(POWER_DOMAIN_GT_IRQ) |			\
 	BIT_ULL(POWER_DOMAIN_MODESET) |			\
 	BIT_ULL(POWER_DOMAIN_AUX_A) |			\
 	BIT_ULL(POWER_DOMAIN_INIT))
Signature · 6 lines
2.18.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for drm/i915/icl: Add POWER_DOMAIN_GT_IRQ to ICL DC_OFF_POWER_DOMAINS

== Series Details ==

== Series Details ==

Series: drm/i915/icl: Add POWER_DOMAIN_GT_IRQ to ICL DC_OFF_POWER_DOMAINS
URL : https://patchwork.freedesktop.org/series/49514/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4806 -> Patchwork_10146 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/49514/revisions/1/mbox/

== Known issues ==

Here are the changes found in Patchwork_10146 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@amdgpu/amd_prime@amd-to-i915:
      fi-kbl-8809g:       NOTRUN -> FAIL (fdo#107341)

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     PASS -> FAIL (fdo#103167)

    
    ==== Possible fixes ====

    igt@amdgpu/amd_basic@userptr:
      fi-kbl-8809g:       INCOMPLETE (fdo#107402) -> PASS

    igt@gem_exec_suspend@basic-s3:
      fi-blb-e6850:       INCOMPLETE (fdo#107718) -> PASS
      fi-icl-u:           INCOMPLETE (fdo#107901) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#103191, fdo#107362) -> PASS

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         FAIL (fdo#104008) -> PASS

fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107402 https://bugs.freedesktop.org/show_bug.cgi?id=107402
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107901 https://bugs.freedesktop.org/show_bug.cgi?id=107901

== Participating hosts (49 -> 43) ==

Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-glk-j4005

== Build changes ==

* Linux: CI_DRM_4806 -> Patchwork_10146

CI_DRM_4806: feeccde66999c5e87be3550f2159e5d7eeb61c67 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4638: 20a7ead8bdf09774c7d58fcbe6a0980d08ed5365 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10146: 5e67647ffd56c598988f0c70a71dd9607a51e96a @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

5e67647ffd56 drm/i915/icl: Add POWER_DOMAIN_GT_IRQ to ICL DC_OFF_POWER_DOMAINS

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10146/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.IGT: success for drm/i915/icl: Add POWER_DOMAIN_GT_IRQ to ICL DC_OFF_POWER_DOMAINS

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: drm/i915/icl: Add POWER_DOMAIN_GT_IRQ to ICL DC_OFF_POWER_DOMAINS
URL : https://patchwork.freedesktop.org/series/49514/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4806_full -> Patchwork_10146_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_10146_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10146_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10146_full:

=== IGT changes ===

    ==== Warnings ====

    igt@kms_atomic_interruptible@universal-setplane-primary:
      shard-snb:          PASS -> SKIP +4

== Known issues ==

Here are the changes found in Patchwork_10146_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-glk:          PASS -> FAIL (fdo#106886)

    igt@gem_exec_await@wide-contexts:
      shard-kbl:          PASS -> FAIL (fdo#106680)

    
    ==== Possible fixes ====

    igt@gem_exec_await@wide-contexts:
      shard-glk:          FAIL (fdo#106680) -> PASS

    igt@kms_cursor_legacy@cursor-vs-flip-toggle:
      shard-hsw:          FAIL (fdo#103355) -> PASS

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          FAIL (fdo#105363) -> PASS

fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4806 -> Patchwork_10146

CI_DRM_4806: feeccde66999c5e87be3550f2159e5d7eeb61c67 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4638: 20a7ead8bdf09774c7d58fcbe6a0980d08ed5365 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10146: 5e67647ffd56c598988f0c70a71dd9607a51e96a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10146/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to José Roberto de Souza
Quoted 2 lines · José Roberto de Souza

Without this gem will not be able to turn off DC states to redunce interruption latency when no sink is being driven by driver.

Do we know that for sure this is still required? Some kind of test results to confirm would be nice.

Quoted 26 lines
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_runtime_pm.c +1 -0
index 480dadb1047b..af8a0b6ee79b 100644
@@ -1978,6 +1978,7 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
 	 */
 #define ICL_DISPLAY_DC_OFF_POWER_DOMAINS (		\
 	ICL_PW_2_POWER_DOMAINS |			\
+	BIT_ULL(POWER_DOMAIN_GT_IRQ) |			\
 	BIT_ULL(POWER_DOMAIN_MODESET) |			\
 	BIT_ULL(POWER_DOMAIN_AUX_A) |			\
 	BIT_ULL(POWER_DOMAIN_INIT))
Signature · 6 lines
2.18.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

Quoting Ville Syrjälä (2018-09-12 13:48:42)

Quoted 6 lines · José Roberto de Souza
Quoted 2 lines

Without this gem will not be able to turn off DC states to redunce interruption latency when no sink is being driven by driver.

Do we know that for sure this is still required? Some kind of test results to confirm would be nice.

After all it was working around a bug in the dmc that was meant to be fixed at some point in the future.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 9 lines · Chris Wilson

Quoting Ville Syrjälä (2018-09-12 13:48:42)

Quoted 8 lines
Quoted 3 lines · José Roberto de Souza

Without this gem will not be able to turn off DC states to redunce
interruption latency when no sink is being driven by driver.

Do we know that for sure this is still required? Some kind of test results to confirm would be nice.

I'm not sure if is still needed, I just saw that older platforms have that domain in DC off and it is used by gem but ICL don't have it set. Also we are still not loading DMC firmware for ICL so it will not be reproducible until that but I guess is better already be prepared and keep consistent with other platforms.

Quoted 4 lines

After all it was working around a bug in the dmc that was meant to be fixed at some point in the future.
-Chris

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx