Skip to contentSkip to conversation

Punctuation fixes

PATCH In review Diego Viola 4 participants 8 messages Sep 12, 2018 – Sep 25, 2018 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Punctuation fixes

---
 CREDITS     | 2 +-
 MAINTAINERS | 2 +-
 Makefile    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
CREDITS +1 -1
index 5befd2d71..b82efb36d 100644
@@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/
 W: http://www.linuxdiskcert.org/
 D: Random SMP kernel hacker...
 D: Uniform Multi-Platform E-IDE driver
-D: Active-ATA-Chipset maddness..........
+D: Active-ATA-Chipset maddness...
 D: Ultra DMA 133/100/66/33 w/48-bit Addressing
 D: ATA-Disconnect, ATA-TCQ
 D: ATA-Smart Kernel Daemon
MAINTAINERS +1 -1
index d870cb57c..6567bf245 100644
@@ -93,7 +93,7 @@ Descriptions of section entries:
 	   Supported:	Someone is actually paid to look after this.
 	   Maintained:	Someone actually looks after it.
 	   Odd Fixes:	It has a maintainer but they don't have time to do
-			much other than throw the odd patch in. See below..
+			much other than throw the odd patch in. See below.
 	   Orphan:	No current maintainer [but maybe you could take the
 			role as you write your new code].
 	   Obsolete:	Old code. Something tagged obsolete generally means
Makefile +1 -1
index 4d5c883a9..7b5c5d634 100644
@@ -1109,7 +1109,7 @@ archprepare: archheaders archscripts prepare1 scripts_basic
 prepare0: archprepare gcc-plugins
 	$(Q)$(MAKE) $(build)=.
 
-# All the preparing..
+# All the preparing...
 prepare: prepare0 prepare-objtool
 
 # Support for using generic headers in asm-generic
Signature · 1 line
2.19.0
#1 lore raw
Quoted 48 lines · Diego Viola
---
 CREDITS     | 2 +-
 MAINTAINERS | 2 +-
 Makefile    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
CREDITS +1 -1
index 5befd2d71..b82efb36d 100644
@@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/
 W: http://www.linuxdiskcert.org/
 D: Random SMP kernel hacker...
 D: Uniform Multi-Platform E-IDE driver
-D: Active-ATA-Chipset maddness..........
+D: Active-ATA-Chipset maddness...
 D: Ultra DMA 133/100/66/33 w/48-bit Addressing
 D: ATA-Disconnect, ATA-TCQ
 D: ATA-Smart Kernel Daemon
MAINTAINERS +1 -1
index d870cb57c..6567bf245 100644
@@ -93,7 +93,7 @@ Descriptions of section entries:
           Supported:   Someone is actually paid to look after this.
           Maintained:  Someone actually looks after it.
           Odd Fixes:   It has a maintainer but they don't have time to do
-                       much other than throw the odd patch in. See below..
+                       much other than throw the odd patch in. See below.
           Orphan:      No current maintainer [but maybe you could take the
                        role as you write your new code].
           Obsolete:    Old code. Something tagged obsolete generally means
Makefile +1 -2
index 4d5c883a9..7b5c5d634 100644
@@ -1109,7 +1109,7 @@ archprepare: archheaders archscripts prepare1 scripts_basic
 prepare0: archprepare gcc-plugins
        $(Q)$(MAKE) $(build)=.
 
-# All the preparing..
+# All the preparing...
 prepare: prepare0 prepare-objtool
 
 # Support for using generic headers in asm-generic
--
Quoted 2 lines

2.19.0

Jonathan,

can you please merge my patch? After you merge this one, I'll go through the rest of the documentation to make it more consistent.

Diego

#2 lore raw

Hi Diego,

A few things, since it looks like this is your first patch.

Quoted 9 lines · Diego Viola
Quoted 8 lines · Diego Viola
---
 CREDITS     | 2 +-
 MAINTAINERS | 2 +-
 Makefile    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Quoted 10 lines

CREDITS W: http://www.linux-ide.org/ · line 1476

Quoted 10 lines
CREDITS +1 -1
index 5befd2d71..b82efb36d 100644
@@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/
 W: http://www.linuxdiskcert.org/
 D: Random SMP kernel hacker...
 D: Uniform Multi-Platform E-IDE driver
-D: Active-ATA-Chipset maddness..........
+D: Active-ATA-Chipset maddness...

I think the extra dots is what was intended here :)

Quoted 35 lines
Quoted 30 lines
CREDITS +0 -0
 D: Ultra DMA 133/100/66/33 w/48-bit Addressing
 D: ATA-Disconnect, ATA-TCQ
 D: ATA-Smart Kernel Daemon
MAINTAINERS +1 -1
index d870cb57c..6567bf245 100644
@@ -93,7 +93,7 @@ Descriptions of section entries:
           Supported:   Someone is actually paid to look after this.
           Maintained:  Someone actually looks after it.
           Odd Fixes:   It has a maintainer but they don't have time to do
-                       much other than throw the odd patch in. See below..
+                       much other than throw the odd patch in. See below.
           Orphan:      No current maintainer [but maybe you could take the
                        role as you write your new code].
           Obsolete:    Old code. Something tagged obsolete generally means
Makefile +1 -2
index 4d5c883a9..7b5c5d634 100644
@@ -1109,7 +1109,7 @@ archprepare: archheaders archscripts prepare1 scripts_basic
 prepare0: archprepare gcc-plugins
        $(Q)$(MAKE) $(build)=.
 
-# All the preparing..
+# All the preparing...
 prepare: prepare0 prepare-objtool
 
 # Support for using generic headers in asm-generic
--
Quoted 2 lines

2.19.0

Jonathan,

Quoted 2 lines

can you please merge my patch? After you merge this one, I'll go through the rest of the documentation to make it more consistent.

Jonathan is not responsible for these files. Jiri Kosina is the maintainer of the trivial tree.

There are 1700+ instances of a "two-stops ellipsis" in the kernel. I am not sure they were mistakes, given their prevalence, even if they are not formal/common English. Also, I am not sure a commit for each 3 is really appropriate! :) Maybe do the full sweep of the Documentation ones in a single patch?

Also, typically you would note in the subject that this is a "v2" of your previous patch (if I am not wrong, you sent a first version fixing only one of the 3 mistakes).

Thanks for your first patch!

Cheers,
Miguel

#3 lore raw
Quoted 4 lines · Miguel Ojeda

Hi Diego,

A few things, since it looks like this is your first patch.

git log...

Quoted 10 lines · Diego Viola
Quoted 9 lines · Diego Viola
Quoted 8 lines
---
 CREDITS     | 2 +-
 MAINTAINERS | 2 +-
 Makefile    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Quoted 12 lines
Quoted 10 lines

CREDITS W: http://www.linux-ide.org/ · line 1476

Quoted 10 lines
CREDITS +1 -1
index 5befd2d71..b82efb36d 100644
@@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/
 W: http://www.linuxdiskcert.org/
 D: Random SMP kernel hacker...
 D: Uniform Multi-Platform E-IDE driver
-D: Active-ATA-Chipset maddness..........
+D: Active-ATA-Chipset maddness...

I think the extra dots is what was intended here :)

Diego, I know you can do better. :-)
How about running linux-next and hunting down regressions? I think we suggested this already on IRC.

Signature · 2 lines
Thanks,
//richard
#4 lore raw

Hi Richard,

Quoted 8 lines · Richard Weinberger
Quoted 4 lines · Miguel Ojeda

Hi Diego,

A few things, since it looks like this is your first patch.

git log...

Oops! I guess I mistyped the search string, sorry Diego!

Cheers,
Miguel

#5 lore raw
In reply to Richard Weinberger
Quoted 33 lines · Richard Weinberger
Quoted 4 lines · Miguel Ojeda

Hi Diego,

A few things, since it looks like this is your first patch.

git log...

Quoted 10 lines · Diego Viola
Quoted 9 lines · Diego Viola
Quoted 8 lines
---
 CREDITS     | 2 +-
 MAINTAINERS | 2 +-
 Makefile    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Quoted 12 lines
Quoted 10 lines

CREDITS W: http://www.linux-ide.org/ · line 1476

Quoted 10 lines
CREDITS +1 -1
index 5befd2d71..b82efb36d 100644
@@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/
 W: http://www.linuxdiskcert.org/
 D: Random SMP kernel hacker...
 D: Uniform Multi-Platform E-IDE driver
-D: Active-ATA-Chipset maddness..........
+D: Active-ATA-Chipset maddness...

I think the extra dots is what was intended here :)

Quoted 3 lines

Diego, I know you can do better. :-)
How about running linux-next and hunting down regressions? I think we suggested this already on IRC.

OK. I'll do that after I'm done with the documentation.

Quoted 4 lines

--
Thanks,
//richard

Thanks,
Diego

#6 lore raw

Am Dienstag, 25. September 2018, 02:09:20 CEST schrieb Diego Viola:

Quoted 5 lines
Quoted 3 lines

Diego, I know you can do better. :-)
How about running linux-next and hunting down regressions? I think we suggested this already on IRC.

OK. I'll do that after I'm done with the documentation.

By the definition of done. ;-)
If you want to help,
Documentation/virtual/uml/UserModeLinux-HOWTO.txt
needs an update.

Thanks,
//richard

#7 lore raw
In reply to Miguel Ojeda

Hi Miguel,

Quoted 15 lines · Miguel Ojeda

Hi Diego,

A few things, since it looks like this is your first patch.

Quoted 9 lines · Diego Viola
Quoted 8 lines · Diego Viola
---
 CREDITS     | 2 +-
 MAINTAINERS | 2 +-
 Makefile    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Quoted 12 lines
Quoted 10 lines

CREDITS W: http://www.linux-ide.org/ · line 1476

Quoted 10 lines
CREDITS +1 -1
index 5befd2d71..b82efb36d 100644
@@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/
 W: http://www.linuxdiskcert.org/
 D: Random SMP kernel hacker...
 D: Uniform Multi-Platform E-IDE driver
-D: Active-ATA-Chipset maddness..........
+D: Active-ATA-Chipset maddness...

I think the extra dots is what was intended here :)

OK.

Quoted 36 lines
Quoted 36 lines
Quoted 31 lines
CREDITS +0 -0
 D: Ultra DMA 133/100/66/33 w/48-bit Addressing
 D: ATA-Disconnect, ATA-TCQ
 D: ATA-Smart Kernel Daemon
MAINTAINERS +1 -1
index d870cb57c..6567bf245 100644
@@ -93,7 +93,7 @@ Descriptions of section entries:
           Supported:   Someone is actually paid to look after this.
           Maintained:  Someone actually looks after it.
           Odd Fixes:   It has a maintainer but they don't have time to do
-                       much other than throw the odd patch in. See below..
+                       much other than throw the odd patch in. See below.
           Orphan:      No current maintainer [but maybe you could take the
                        role as you write your new code].
           Obsolete:    Old code. Something tagged obsolete generally means
Makefile +1 -2
index 4d5c883a9..7b5c5d634 100644
@@ -1109,7 +1109,7 @@ archprepare: archheaders archscripts prepare1 scripts_basic
 prepare0: archprepare gcc-plugins
        $(Q)$(MAKE) $(build)=.
 
-# All the preparing..
+# All the preparing...
 prepare: prepare0 prepare-objtool
 
 # Support for using generic headers in asm-generic
--
Quoted 2 lines

2.19.0

Jonathan,

Quoted 5 lines
Quoted 2 lines

can you please merge my patch? After you merge this one, I'll go through the rest of the documentation to make it more consistent.

Jonathan is not responsible for these files. Jiri Kosina is the maintainer of the trivial tree.

OK, I'm CCing him with this email.

Quoted 6 lines

There are 1700+ instances of a "two-stops ellipsis" in the kernel. I am not sure they were mistakes, given their prevalence, even if they are not formal/common English. Also, I am not sure a commit for each 3 is really appropriate! :) Maybe do the full sweep of the Documentation ones in a single patch?

Good idea, do you know what approach I can use for the full sweep? sed perhaps? Doing this manually would be very tedious and using sed might be error prone.

Quoted 4 lines

Also, typically you would note in the subject that this is a "v2" of your previous patch (if I am not wrong, you sent a first version fixing only one of the 3 mistakes).

Correct, this is my V2 of the first patch. Sorry for not specifying that.

Quoted 5 lines

Thanks for your first patch!

Cheers,
Miguel

Thanks,
Diego