Skip to contentSkip to conversation

ARM: dts: imx53-qsb: disable 1.2GHz OPP

PATCH Superseded Sascha Hauer 2 participants 6 messages Sep 10, 2018 – Sep 12, 2018

Subsystems (2)
lore
Share & tools
lore

Sascha Hauer

author maintainer
#0 lore raw

PATCH 1/1 ARM: dts: imx53-qsb: disable 1.2GHz OPP

The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the 1.2GHz OPP. This makes the board work with cpufreq again.

Fixes 791f416608 ("ARM: dts: imx53: add cpufreq-dt support")
---
 arch/arm/boot/dts/imx53-qsb-common.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/imx53-qsb-common.dtsi +11 -0
index 7423d462d1e4..50dde84b72ed 100644
@@ -123,6 +123,17 @@
 	};
 };
 
+&cpu0 {
+	/* CPU rated to 1GHz, not 1.2GHz as per the default settings */
+	operating-points = <
+		/* kHz   uV */
+		166666  850000
+		400000  900000
+		800000  1050000
+		1000000 1200000
+	>;
+};
+
 &esdhc1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_esdhc1>;
Signature · 1 line
2.18.0
#1 lore raw

PATCH 1/1 ARM: dts: imx53-qsb: disable 1.2GHz OPP

Quoted 2 lines · Sascha Hauer

The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the 1.2GHz OPP. This makes the board work with cpufreq again.

I feel that the word 'again' and the Fixes tag below are a little confusing. It makes impression that cpufreq worked fine on the board before and commit 791f416608 broke it. However, this is not the case, right?

Quoted 2 lines
Fixes 791f416608 ("ARM: dts: imx53: add cpufreq-dt support")

Shawn

Quoted 31 lines
---
 arch/arm/boot/dts/imx53-qsb-common.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/imx53-qsb-common.dtsi +11 -0
index 7423d462d1e4..50dde84b72ed 100644
@@ -123,6 +123,17 @@
 	};
 };
 
+&cpu0 {
+	/* CPU rated to 1GHz, not 1.2GHz as per the default settings */
+	operating-points = <
+		/* kHz   uV */
+		166666  850000
+		400000  900000
+		800000  1050000
+		1000000 1200000
+	>;
+};
+
 &esdhc1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_esdhc1>;
Signature · 1 line
2.18.0
author maintainer
#2 lore raw

PATCH 1/1 ARM: dts: imx53-qsb: disable 1.2GHz OPP

Hi Shawn,

Quoted 8 lines · Shawn Guo
Quoted 2 lines · Sascha Hauer

The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the 1.2GHz OPP. This makes the board work with cpufreq again.

I feel that the word 'again' and the Fixes tag below are a little confusing. It makes impression that cpufreq worked fine on the board before and commit 791f416608 broke it. However, this is not the case, right?

You're right, the "again" shouldn't be there. I meant that the board works "again" after the addition of cpufreq support broke it.

Just resent the patch with a rephrased commit message.

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#3 lore raw

PATCH 1/1 ARM: dts: imx53-qsb: disable 1.2GHz OPP

Quoted 12 lines · Sascha Hauer

Hi Shawn,

Quoted 8 lines · Shawn Guo
Quoted 2 lines · Sascha Hauer

The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the 1.2GHz OPP. This makes the board work with cpufreq again.

I feel that the word 'again' and the Fixes tag below are a little confusing. It makes impression that cpufreq worked fine on the board before and commit 791f416608 broke it. However, this is not the case, right?

Quoted 4 lines

You're right, the "again" shouldn't be there. I meant that the board works "again" after the addition of cpufreq support broke it.

Just resent the patch with a rephrased commit message.

Thanks, Sascha.

Shawn

author maintainer
#4 lore raw

PATCH v2 1/1 ARM: dts: imx53-qsb: disable 1.2GHz OPP

In reply to Sascha Hauer

The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the 1.2GHz OPP. This makes the board work again with configs that have cpufreq enabled like imx_v6_v7_defconfig on which the board stopped working with the addition of cpufreq-dt support.

Fixes 791f416608 ("ARM: dts: imx53: add cpufreq-dt support")

---

Changes since v1:
- rephrase commit message

arch/arm/boot/dts/imx53-qsb-common.dtsi | 11 +++++++++++

 1 file changed, 11 insertions(+)
arch/arm/boot/dts/imx53-qsb-common.dtsi +11 -0
index 7423d462d1e4..50dde84b72ed 100644
@@ -123,6 +123,17 @@
 	};
 };
 
+&cpu0 {
+	/* CPU rated to 1GHz, not 1.2GHz as per the default settings */
+	operating-points = <
+		/* kHz   uV */
+		166666  850000
+		400000  900000
+		800000  1050000
+		1000000 1200000
+	>;
+};
+
 &esdhc1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_esdhc1>;
Signature · 1 line
2.18.0
Applied
#5 lore raw

PATCH v2 1/1 ARM: dts: imx53-qsb: disable 1.2GHz OPP

Quoted 8 lines · Sascha Hauer

The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the 1.2GHz OPP. This makes the board work again with configs that have cpufreq enabled like imx_v6_v7_defconfig on which the board stopped working with the addition of cpufreq-dt support.

Fixes 791f416608 ("ARM: dts: imx53: add cpufreq-dt support")

Applied, thanks.