package/mongodb: add patch to compile with glibc >= 2.28
PATCH 1/1 package/mongodb: add patch to compile with glibc >= 2.28
glibc 2.28 no longer includes <sys/sysmacros.h> from <sys/types.h>, and therefore <sys/sysmacros.h> must be included explicitly when major()/minor() are used.
--- package/mongodb/mongodb.patch | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 package/mongodb/mongodb.patch
package/mongodb/mongodb.patch new file +10 -0
@@ -0,0 +1,10 @@ +--- ./src/mongo/db/storage/mmap_v1/mmap_v1_engine.cpp ++++ ./src/mongo/db/storage/mmap_v1/mmap_v1_engine.cpp +@@ -32,6 +32,7 @@ + + #include "mongo/db/storage/mmap_v1/mmap_v1_engine.h" + ++#include <sys/sysmacros.h> + #include <boost/filesystem/path.hpp> + #include <boost/filesystem/operations.hpp> + #include <fstream>
Signature · 9 lines
2.17.1 Gesch?ftsf?hrung: Susanne Kunschert, Thomas Pilz Pilz GmbH & Co. KG, Sitz: Ostfildern, HRA 210 893, Amtsgericht Stuttgart Kompl. Ges. Peter Pilz GmbH, Sitz: Ostfildern, HRB 210 612, Amtsgericht Stuttgart Umsatzsteuer: ID-Nr. DE 145 355 773, WEEE-Reg.-Nr. DE 71636849 This email is intended solely for the use of the named address(es). Any unauthorised disclosure, copying or distribution of these confidential information contained therein, or the taking of any action based on it, is prohibited. The sender disclaims any liability for the integrity of this email. Legally binding declarations must be in written form. Umweltschutz liegt uns am Herzen! - Bitte denken Sie an unsere Umwelt, bevor Sie diese E-Mail drucken. We do care about the environment! - Please consider the environment before printing this e-mail.
PATCH 1/1 package/mongodb: add patch to compile with glibc >= 2.28
Hello,
Quoted 5 lines · Florian La Roche
glibc 2.28 no longer includes <
sys/sysmacros.h> from <sys/types.h>, and therefore <sys/sysmacros.h> must be included explicitly when major()/minor() are used.Signed-off-by Florian La Roche <[email protected]>
Thanks a lot for this patch.
package/mongodb/mongodb.patch
Quoted 10 lines
--- package/mongodb/mongodb.patch | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 package/mongodb/mongodb.patchpackage/mongodb/mongodb.patch new file +0
-0
Since mongodb upstream is maintained in Git, we like to have a Git formatted patch. So could you instead clone
https://github.com/mongodb/mongo.git, checkout the 3.3.4 tag, make the fix, do a commit, and then "git format-patch HEAD^", and use the generated 0001 file ?
BTW, I see that in the latest version of mongodb, this file no longer exists. Our package of mongodb is quite old, so if you have some specific interest in mongodb, it might be useful to update it. Or maybe Sergio can comment on this.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] Antwort: Re: [PATCH 1/1] package/mongodb: add patch to compile with glibc >= 2.28
Hello Thomas,
I'll create a new patch from mongodb github and submit that as followup here within the next 2 days.
The mongodb version is indeed quite old. I've tried to update it, but did not succeed. Sergio,
do you have plans or have started such an update?
best regards,
Florian La Roche
Gesch?ftsf?hrung: Susanne Kunschert, Thomas Pilz
Pilz GmbH & Co. KG, Sitz: Ostfildern, HRA 210 893, Amtsgericht Stuttgart
Kompl. Ges. Peter Pilz GmbH, Sitz: Ostfildern, HRB 210 612, Amtsgericht Stuttgart
Umsatzsteuer: ID-Nr. DE 145 355 773, WEEE-Reg.-Nr. DE 71636849
This email is intended solely for the use of the named address(es). Any unauthorised disclosure, copying or distribution of these confidential information contained therein, or the taking of any action based on it, is prohibited. The sender disclaims any liability for the integrity of this email. Legally binding declarations must be in written form. Umweltschutz liegt uns am Herzen! - Bitte denken Sie an unsere Umwelt, bevor Sie diese E-Mail drucken.
We do care about the environment! - Please consider the environment before printing this e-mail.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180912/4f4b168b/attachment.html>
[Buildroot] Antwort: Re: [PATCH 1/1] package/mongodb: add patch to compile with glibc >= 2.28
In reply to Thomas PetazzoniHello Thomas,
Thomas Petazzoni <[email protected]> schrieb am 12.09.2018 10:52:28:
Quoted 5 lines
Since mongodb upstream is maintained in Git, we like to have a Git formatted patch. So could you instead clone
https://github.com/mongodb/mongo.git, checkout the 3.3.4 tag, make the fix, do a commit, and then "git format-patch HEAD^", and use the generated 0001 file ?
The github repo only contains v3.4 and newer, but buildroot is currently using 3.3.4.
Can you commit my original patch or any other idea on how to submit this change?
best regards,
Florian La Roche
Gesch?ftsf?hrung: Susanne Kunschert, Thomas Pilz
Pilz GmbH & Co. KG, Sitz: Ostfildern, HRA 210 893, Amtsgericht Stuttgart
Kompl. Ges. Peter Pilz GmbH, Sitz: Ostfildern, HRB 210 612, Amtsgericht Stuttgart
Umsatzsteuer: ID-Nr. DE 145 355 773, WEEE-Reg.-Nr. DE 71636849
This email is intended solely for the use of the named address(es). Any unauthorised disclosure, copying or distribution of these confidential information contained therein, or the taking of any action based on it, is prohibited. The sender disclaims any liability for the integrity of this email. Legally binding declarations must be in written form. Umweltschutz liegt uns am Herzen! - Bitte denken Sie an unsere Umwelt, bevor Sie diese E-Mail drucken.
We do care about the environment! - Please consider the environment before printing this e-mail.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180912/bb3c1f35/attachment.html>
PATCH 1/1 package/mongodb: add patch to compile with glibc >= 2.28
Hello Thomas and Florian,
I'll work on the mongodb update in the next days.
One thing I notice is that since version 3.4 mongodb no longer supports 32-bit x86 platforms [1].
What should we do in that case? Just update to the newest version and stop supporting 32 bits systems, or create a new recipe and maintain both versions?
[1] https://docs.mongodb.com/manual/installation/#supported-platforms
Best regards,
Sergio Prado
Embedded Labworks
Office: +55 11 2628-3461
Mobile: +55 11 97123-3420
Em qua, 12 de set de 2018 ?s 09:40, Florian La Roche <[email protected]> escreveu:
Quoted 22 lines
Hello Thomas,
Thomas Petazzoni <[email protected]> schrieb am 12.09.2018 10:52:28:
Quoted 5 lines
Since mongodb upstream is maintained in Git, we like to have a Git formatted patch. So could you instead clone
https://github.com/mongodb/mongo.git, checkout the 3.3.4 tag, make the fix, do a commit, and then "git format-patch HEAD^", and use the generated 0001 file ?The github repo only contains v3.4 and newer, but buildroot is currently using 3.3.4.
Can you commit my original patch or any other idea on how to submit this change?
best regards,
Florian La Roche
Quoted 14 lines
Gesch?ftsf?hrung: Susanne Kunschert, Thomas Pilz
Pilz GmbH & Co. KG, Sitz: Ostfildern, HRA 210 893, Amtsgericht Stuttgart Kompl. Ges. Peter Pilz GmbH, Sitz: Ostfildern, HRB 210 612, Amtsgericht Stuttgart
Umsatzsteuer: ID-Nr. DE 145 355 773, WEEE-Reg.-Nr. DE 71636849 This email is intended solely for the use of the named address(es). Any unauthorised disclosure, copying or distribution of these confidential information contained therein, or the taking of any action based on it, is prohibited. The sender disclaims any liability for the integrity of this email. Legally binding declarations must be in written form. Umweltschutz liegt uns am Herzen! - Bitte denken Sie an unsere Umwelt, bevor Sie diese E-Mail drucken.
We do care about the environment! - Please consider the environment before printing this e-mail.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180912/de2d723e/attachment.html>
PATCH 1/1 package/mongodb: add patch to compile with glibc >= 2.28
Hello Sergio,
Quoted 8 lines · Sergio Prado
I'll work on the mongodb update in the next days.
One thing I notice is that since version 3.4 mongodb no longer supports 32-bit x86 platforms [1].
What should we do in that case? Just update to the newest version and stop supporting 32 bits systems, or create a new recipe and maintain both versions?
I'd say, just update to the newest version and stop supporting 32-bit platforms. That's upstream choice, if people are unhappy with it, they should bring this up to upstream or fork the project.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Thomas Petazzoni
AppliedPATCH 1/1 package/mongodb: add patch to compile with glibc >= 2.28
In reply to Florian La RocheHello,
Quoted 9 lines · Florian La Roche
glibc 2.28 no longer includes <
sys/sysmacros.h> from <sys/types.h>, and therefore <sys/sysmacros.h> must be included explicitly when major()/minor() are used.Signed-off-by Florian La Roche <[email protected]>--- package/mongodb/mongodb.patch | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 package/mongodb/mongodb.patch
Applied to master, after adding a proper description in the patch.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com