Skip to contentSkip to conversation

clk: mvebu: ap806: Remove superfluous of_clk_add_provider

PATCH Applied Gregory CLEMENT 2 participants 2 messages Sep 12, 2018 – Oct 1, 2018

Subsystems (2)
lore
Share & tools
lore

Gregory CLEMENT

author maintainer
#0 lore raw

PATCH 1/1 clk: mvebu: ap806: Remove superfluous of_clk_add_provider

While applying the commit a8309cedcdce ("clk: apn806: Add eMMC clock to system controller driver"), of_clk_add_provider was added wheres it was already present in the probe function.

This extraneous call is harmless but not useful so remove it.

---
 drivers/clk/mvebu/ap806-system-controller.c | 1 -
 1 file changed, 1 deletion(-)
drivers/clk/mvebu/ap806-system-controller.c +0 -1
index 9fbec3eb725f..ea54a874bbda 100644
@@ -153,7 +153,6 @@ static int ap806_syscon_common_probe(struct platform_device *pdev,
 		goto fail4;
 	}
 
-	of_clk_add_provider(np, of_clk_src_onecell_get, &ap806_clk_data);
 	ret = of_clk_add_provider(np, of_clk_src_onecell_get, &ap806_clk_data);
 	if (ret)
 		goto fail_clk_add;
Signature · 1 line
2.18.0
maintainer Applied
#1 lore raw

Quoting Gregory CLEMENT (2018-09-12 08:35:49)

Quoted 8 lines

While applying the commit a8309cedcdce ("clk: apn806: Add eMMC clock to system controller driver"), of_clk_add_provider was added wheres it was already present in the probe function.

This extraneous call is harmless but not useful so remove it.

---

Applied to clk-next