Skip to contentSkip to conversation

Add /proc/<pid>/numa_vamaps for numa node information

RFC PATCH Alexey Dobriyan 2 participants 2 messages Sep 12, 2018 – Sep 13, 2018

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines

The /proc/pid/numa_vamaps shows mapped address ranges to numa node id from where the physical pages are allocated.

All these files make the problem with useless dentry and /proc/*/* inode instantiations worse (unlike top level /proc/* files which are tolerable).

Review

Quoted 11 lines
(quoted diff) +11 -0
+address-range	numa-node-id
+
+00400000-00410000 N1
+00410000-0047f000 N0
+0047f000-00480000 N2
+00480000-00481000 -
+00481000-004a0000 N0
+004a0000-004a2000 -
+004a2000-004aa000 N2
+004aa000-004ad000 N0
+004ad000-004ae000 -

'N' is useless data.

Parsing with awk won't work because field #3 is separated with space but field #2 with '-'.

%08lx-%08lx kind of sucks: 32-bit get aligned data so parsing can be faster by pointing to &p[8+1] but not on 64-bit.
If scanf("%lx-%lx") is used then leading zeroes are useless.

Text is harder than it looks.
Please in the name of everything holy add new honest system call.

#1 lore raw
Quoted 6 lines · Alexey Dobriyan
Quoted 2 lines

The /proc/pid/numa_vamaps shows mapped address ranges to numa node id from where the physical pages are allocated.

All these files make the problem with useless dentry and /proc/*/* inode instantiations worse (unlike top level /proc/* files which are tolerable).

Quoted 12 lines

Review

Quoted 11 lines
(quoted diff) +11 -0
+address-range	numa-node-id
+
+00400000-00410000 N1
+00410000-0047f000 N0
+0047f000-00480000 N2
+00480000-00481000 -
+00481000-004a0000 N0
+004a0000-004a2000 -
+004a2000-004aa000 N2
+004aa000-004ad000 N0
+004ad000-004ae000 -

'N' is useless data.

'N' could be dropped.

Quoted 7 lines

Parsing with awk won't work because field #3 is separated with space but field #2 with '-'.

%08lx-%08lx kind of sucks: 32-bit get aligned data so parsing can be faster by pointing to &p[8+1] but not on 64-bit.
If scanf("%lx-%lx") is used then leading zeroes are useless.

This was similar to how '/proc/*/maps' file presents the address range. However, we could separate start and end address of the range with a space, if that would be preferred.

Quoted 1 line

Text is harder than it looks.

We could make each line fixed length. It could be "%016lx %016lx %04d" i.e 4 digit for node number?

Quoted 1 line

Please in the name of everything holy add new honest system call.