Fix generation of specs
PATCH 1/1 Fix generation of specs
With no trailing space in LINK_EH_SPEC linker spec gets generated as:
------------------------>8--------------------- %{!r:--build-id} --eh-frame-hdr%{h*} ... ------------------------>8---------------------
or even worse if hash style is added:
------------------------>8--------------------- %{!r:--build-id} --eh-frame-hdr--hash-style=sysv %{h*} ... ------------------------>8---------------------
Now if that spec is really used by LD then it fails inevitably saying that it doesn't know option "--eh-frame-hdr--hash-style=sysv".
--- gcc/config/arc/linux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
gcc/config/arc/linux.h +1 -1
@@ -98,7 +98,7 @@ along with GCC; see the file COPYING3. If not seeSignalize that because we have fde-glibc, we don't need all C shared libs linked against -lgcc_s. */ #undef LINK_EH_SPEC -#define LINK_EH_SPEC "--eh-frame-hdr" +#define LINK_EH_SPEC "--eh-frame-hdr "#endif #undef SUBTARGET_CPP_SPEC
Signature · 1 line
2.17.1
PATCH 1/1 Fix generation of specs
The patch is missing the entry change log. Otherwise is ok. I'll push it with the mentioned changes.
Thank you,
Claudiu
Quoted 44 lines
-----Original Message-----
From: Alexey Brodkin [mailto:abrodkin at synopsys.com]
Sent: Thursday, September 13, 2018 9:41 AM
To: gcc-patches at gcc.gnu.org
Cc: linux-snps-arc at lists.infradead.org; Alexey Brodkin <abrodkin at synopsys.com>; Andrew Burgess <andrew.burgess at embecosm.com>; Claudiu Zissulescu <claziss at synopsys.com>
Subject: [PATCH] [ARC] Fix generation of specsWith no trailing space in
LINK_EH_SPEClinker spec gets generated as:
------------------------>8--------------------- %{!r:--build-id} --eh-frame-hdr%{h*} ... ------------------------>8---------------------or even worse if hash style is added:
------------------------>8--------------------- %{!r:--build-id} --eh-frame-hdr--hash-style=sysv %{h*} ... ------------------------>8---------------------Now if that spec is really used by LD then it fails inevitably saying that it doesn't know option "--eh-frame-hdr--hash-style=sysv".
Cc Andrew Burgess <andrew.burgess at embecosm.com>Cc Claudiu Zissulescu <claziss at synopsys.com>--- gcc/config/arc/linux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)gcc/config/arc/linux.h +1
-2@@ -98,7 +98,7 @@ along with GCC; see the file COPYING3. If not seeSignalize that because we have fde-glibc, we don't need all C shared libs linked against -lgcc_s. */ #undef LINK_EH_SPEC -#define LINK_EH_SPEC "--eh-frame-hdr" +#define LINK_EH_SPEC "--eh-frame-hdr "#endif #undef SUBTARGET_CPP_SPEC --2.17.1
PATCH 1/1 Fix generation of specs
Hi Claus,
Quoted 1 line · Claudiu Zissulescu
The patch is missing the entry change log. Otherwise is ok. I'll push it with the mentioned changes.
Thanks for taking care.
Also may we have it back-ported to 8.x branch so it will be a part of 8.3 release later?
-Alexey