Fixes for gcov-related linker problems
Subsystems (2)
cover Fixes for gcov-related linker problems
Commit
6b7dca401cb1 ("tracing: Allow gcov profiling on only ftrace subsystem")
uncovered linker problems when using gcov kernel profiling on some architectures. These problems were likely introduced earlier, and are possibly related to compiler changes.
Arnd: Can you pick up these fixes?
Peter Oberparleiter (2):
vmlinux.lds.h: Fix incomplete .text.exit discards vmlinux.lds.h: Fix linker warnings about orphan .LPBX sections
arch/arm/kernel/vmlinux.lds.h | 2 ++ include/asm-generic/vmlinux.lds.h | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-)
Signature · 1 line
2.17.0
PATCH 1/2 vmlinux.lds.h: Fix incomplete .text.exit discards
Enabling CONFIG_GCOV_PROFILE_ALL=y causes linker errors on ARM:
.text.exit' referenced in section .ARM.exidx.text.exit':
defined in discarded section `.text.exit'
.text.exit' referenced in section .fini_array.00100':
defined in discarded section `.text.exit'
And related errors on NDS32:
.text.exit' referenced in section .dtors.65435':
defined in discarded section `.text.exit'
The gcov compiler flags cause certain compiler versions to generate additional destructor-related sections that are not yet handled by the linker script, resulting in references between discarded and non-discarded sections.
Since destructors are not used in the Linux kernel, fix this by discarding these additional sections.
--- arch/arm/kernel/vmlinux.lds.h | 2 ++ include/asm-generic/vmlinux.lds.h | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-)
arch/arm/kernel/vmlinux.lds.h +2 -0
@@ -49,6 +49,8 @@#define ARM_DISCARD \ *(.ARM.exidx.exit.text) \ *(.ARM.extab.exit.text) \ + *(.ARM.exidx.text.exit) \ + *(.ARM.extab.text.exit) \ ARM_CPU_DISCARD(*(.ARM.exidx.cpuexit.text)) \ ARM_CPU_DISCARD(*(.ARM.extab.cpuexit.text)) \ ARM_EXIT_DISCARD(EXIT_TEXT) \
include/asm-generic/vmlinux.lds.h +2 -2
@@ -613,8 +613,8 @@#define EXIT_DATA \ *(.exit.data .exit.data.*) \ - *(.fini_array) \ - *(.dtors) \ + *(.fini_array .fini_array.*) \ + *(.dtors .dtors.*) \ MEM_DISCARD(exit.data*) \ MEM_DISCARD(exit.rodata*)
Signature · 1 line
2.17.0
PATCH 2/2 vmlinux.lds.h: Fix linker warnings about orphan .LPBX sections
In reply to Peter OberparleiterEnabling both CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=y and CONFIG_GCOV_PROFILE_ALL=y results in linker warnings:
warning: orphan section .data..LPBX1' being placed in section .data..LPBX1'.
LD_DEAD_CODE_DATA_ELIMINATION adds compiler flag -fdata-sections. This option causes GCC to create separate data sections for data objects, including those generated by GCC internally for gcov profiling. The names of these objects start with a dot (.LPBX0, .LPBX1), resulting in section names starting with 'data..'.
As section names starting with 'data..' are used for specific purposes in the Linux kernel, the linker script does not automatically include them in the output data section, resulting in the "orphan section" linker warnings.
Fix this by specifically including sections named "data..LPBX*" in the data section.
--- include/asm-generic/vmlinux.lds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/asm-generic/vmlinux.lds.h +1 -1
@@ -68,7 +68,7 @@*/ #ifdef CONFIG_LD_DEAD_CODE_DATA_ELIMINATION #define TEXT_MAIN .text .text.[0-9a-zA-Z_]* -#define DATA_MAIN .data .data.[0-9a-zA-Z_]* +#define DATA_MAIN .data .data.[0-9a-zA-Z_]* .data..LPBX*#define SDATA_MAIN .sdata .sdata.[0-9a-zA-Z_]*#define RODATA_MAIN .rodata .rodata.[0-9a-zA-Z_]*#define BSS_MAIN .bss .bss.[0-9a-zA-Z_]*
Signature · 1 line
2.17.0