Skip to contentSkip to conversation

net/i40e: remove invalid comment

PATCH Applied Ferruh Yigit 2 participants 2 messages Sep 13, 2018 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/i40e: remove invalid comment

Comments says "no csum error report support" but there is no check related csum offloads. Removing the comment.

---
Patch can be other way around too, adding the csum check mentioned in the comment.
Please comment if this is the correct thing to do.

---
 drivers/net/i40e/i40e_rxtx_vec_common.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/i40e/i40e_rxtx_vec_common.h +1 -3
index 63cb17742..f00f6d648 100644
@@ -199,9 +199,7 @@ i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev)
 	if (fconf->mode != RTE_FDIR_MODE_NONE)
 		return -1;
 
-	 /* - no csum error report support
-	 * - no header split support
-	 */
+	 /* no header split support */
 	if (rxmode->offloads & DEV_RX_OFFLOAD_HEADER_SPLIT)
 		return -1;
 
Signature · 1 line
2.17.1
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: Yigit, Ferruh
Sent: Thursday, September 13, 2018 7:21 PM
To: Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; Yigit, Ferruh <[email protected]>
Subject: [PATCH] net/i40e: remove invalid comment

Quoted 4 lines

Comments says "no csum error report support" but there is no check related csum offloads. Removing the comment.

Applied to dpdk-next-net-intel.

Thanks
Qi