Skip to contentSkip to conversation

gpiolib: Free the last requested descriptor

PATCH In review Ricardo Ribalda Delgado 2 participants 5 messages Sep 13, 2018 – Sep 17, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpiolib: Free the last requested descriptor

The current code only frees N-1 gpios if an error occurs during gpiod_set_transitory, gpiod_direction_output or gpiod_direction_input. Leading to gpios that cannot be used by userspace nor other drivers.

Cc Timur Tabi <[email protected]>
Fixes ab3dbcf78f60f46d ("gpioib: do not free unrequested descriptors)
---
 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpiolib.c +1 -1
index e8f8a1999393..a57300c1d649 100644
@@ -571,7 +571,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
 		if (ret)
 			goto out_free_descs;
 		lh->descs[i] = desc;
-		count = i;
+		count = i + 1;
 
 		if (lflags & GPIOHANDLE_REQUEST_ACTIVE_LOW)
 			set_bit(FLAG_ACTIVE_LOW, &desc->flags);
Signature · 1 line
2.18.0
#1 lore raw
Quoted 29 lines · Ricardo Ribalda Delgado

The current code only frees N-1 gpios if an error occurs during gpiod_set_transitory, gpiod_direction_output or gpiod_direction_input. Leading to gpios that cannot be used by userspace nor other drivers.

Cc Timur Tabi <[email protected]>
Fixes ab3dbcf78f60f46d ("gpioib: do not free unrequested descriptors)
---
 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpiolib.c +1 -2
index e8f8a1999393..a57300c1d649 100644
@@ -571,7 +571,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
                if (ret)
                        goto out_free_descs;
                lh->descs[i] = desc;
-               count = i;
+               count = i + 1;
 
                if (lflags & GPIOHANDLE_REQUEST_ACTIVE_LOW)
                        set_bit(FLAG_ACTIVE_LOW, &desc->flags);
--

2.18.0

Signature · 1 line
Ricardo Ribalda
#2 lore raw
In reply to Ricardo Ribalda Delgado
Quoted 8 lines · Ricardo Ribalda Delgado

The current code only frees N-1 gpios if an error occurs during gpiod_set_transitory, gpiod_direction_output or gpiod_direction_input. Leading to gpios that cannot be used by userspace nor other drivers.

Cc Timur Tabi <[email protected]>
Fixes ab3dbcf78f60f46d ("gpioib: do not free unrequested descriptors)

Patch applied for fixes with Jan's Reported-by tag.

Yours,
Linus Walleij

#3 lore raw

Hi Linus

Quoted 8 lines · Linus Walleij
Quoted 4 lines · Ricardo Ribalda Delgado

The current code only frees N-1 gpios if an error occurs during gpiod_set_transitory, gpiod_direction_output or gpiod_direction_input. Leading to gpios that cannot be used by userspace nor other drivers.

Quoted 6 lines
Quoted 4 lines
Cc Timur Tabi <[email protected]>
Fixes ab3dbcf78f60f46d ("gpioib: do not free unrequested descriptors)

Patch applied for fixes with Jan's Reported-by tag.

Just a heads-up

I haven't seem the patch on your kernel tree at
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/refs/heads

it is probably on your computer tree, but I wanted to make sure the patch is not lost in the wind :P

Thanks!

Quoted 3 lines

Yours,
Linus Walleij

Signature · 1 line
Ricardo Ribalda