Skip to contentSkip to conversation

misc: sgi-gru: fix fall-through annotations

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Sep 13, 2018 – Sep 14, 2018 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 misc: sgi-gru: fix fall-through annotations

Replace "fallthru" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough

---
 drivers/misc/sgi-gru/grukservices.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/sgi-gru/grukservices.c +2 -2
index 0307690..4b23d58 100644
@@ -634,7 +634,7 @@ static int send_noop_message(void *cb, struct gru_message_queue_desc *mqd,
 			break;
 		case CBSS_PAGE_OVERFLOW:
 			STAT(mesq_noop_page_overflow);
-			/* fallthru */
+			/* fall through */
 		default:
 			BUG();
 		}
@@ -792,7 +792,7 @@ static int send_message_failure(void *cb, struct gru_message_queue_desc *mqd,
 		break;
 	case CBSS_PAGE_OVERFLOW:
 		STAT(mesq_page_overflow);
-		/* fallthru */
+		/* fall through */
 	default:
 		BUG();
 	}
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 35 lines · Gustavo A. R. Silva

Replace "fallthru" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough

---
 drivers/misc/sgi-gru/grukservices.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/sgi-gru/grukservices.c +2 -2
index 0307690..4b23d58 100644
@@ -634,7 +634,7 @@ static int send_noop_message(void *cb, struct gru_message_queue_desc *mqd,
 			break;
 		case CBSS_PAGE_OVERFLOW:
 			STAT(mesq_noop_page_overflow);
-			/* fallthru */
+			/* fall through */
 		default:
 			BUG();
 		}
@@ -792,7 +792,7 @@ static int send_message_failure(void *cb, struct gru_message_queue_desc *mqd,
 		break;
 	case CBSS_PAGE_OVERFLOW:
 		STAT(mesq_page_overflow);
-		/* fallthru */
+		/* fall through */
 	default:
 		BUG();
 	}
Signature · 1 line
2.7.4