Skip to contentSkip to conversation

drm/vmwgfx: Fix buffer object eviction

PATCH In review Thomas Hellstrom 2 participants 3 messages Sep 14, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/vmwgfx: Fix buffer object eviction

Commit 19be55701071 ("drm/ttm: add operation ctx to ttm_bo_validate v2") introduced a regression where the vmwgfx driver refused to evict a buffer that was still busy instead of waiting for it to become idle.

Fix this.

---
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +1 -1
index 1f134570b759..f0ab6b2313bb 100644
@@ -3729,7 +3729,7 @@ int vmw_validate_single_buffer(struct vmw_private *dev_priv,
 {
 	struct vmw_buffer_object *vbo =
 		container_of(bo, struct vmw_buffer_object, base);
-	struct ttm_operation_ctx ctx = { interruptible, true };
+	struct ttm_operation_ctx ctx = { interruptible, false };
 	int ret;
 
 	if (vbo->pin_count > 0)
Signature · 6 lines
2.19.0.rc1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

Am 14.09.2018 um 09:35 schrieb Thomas Hellstrom:

Quoted 8 lines

Commit 19be55701071 ("drm/ttm: add operation ctx to ttm_bo_validate v2") introduced a regression where the vmwgfx driver refused to evict a buffer that was still busy instead of waiting for it to become idle.

Fix this.

Ups, sorry for that. Patch is Reviewed-by: Christian König <[email protected]>

Quoted 9 lines
---
  drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +0 -0
index 1f134570b759..f0ab6b2313bb 100644

drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c int vmw_validate_single_buffer(struct vmw_private *dev_priv, · line 3735

Quoted 8 lines
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +1 -1
@@ -3729,7 +3729,7 @@ int vmw_validate_single_buffer(struct vmw_private *dev_priv,
  {
  	struct vmw_buffer_object *vbo =
  		container_of(bo, struct vmw_buffer_object, base);
-	struct ttm_operation_ctx ctx = { interruptible, true };
+	struct ttm_operation_ctx ctx = { interruptible, false };
  	int ret;
 
  	if (vbo->pin_count > 0)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 11 lines · Christian König

Am 14.09.2018 um 09:35 schrieb Thomas Hellstrom:

Quoted 8 lines

Commit 19be55701071 ("drm/ttm: add operation ctx to ttm_bo_validate v2") introduced a regression where the vmwgfx driver refused to evict a buffer that was still busy instead of waiting for it to become idle.

Fix this.

Ups, sorry for that. Patch is Reviewed-by: Christian König <[email protected]>

Thanks!
/Thomas

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel