Skip to contentSkip to conversation

dmaengine: mcf-edma: fix x86_64 allmodconfig compilation warning

PATCH New Vinod Koul 1 participant 1 message Sep 14, 2018 dmaengine

lore
Share & tools
lore

Vinod Koul

author maintainer
#0 lore raw

PATCH v2 1/1 dmaengine: mcf-edma: fix x86_64 allmodconfig compilation warning

Quoted 2 lines · Angelo Dureghello

This patch fixes the compilation warning reported
during x86_64 allmodconfig build.

How does it do so, I have no clue what to expect. Please describe the change done here in the log...

Patch title also doesn't tell me anything about the fix.

Quoted 31 lines

---
Changes for v2:
- added Reported-By

---
 drivers/dma/mcf-edma.c                     | 3 ++-
 include/linux/platform_data/dma-mcf-edma.h | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/dma/mcf-edma.c +2 -1
index 4d30d5302649..e08e2409a102 100644
@@ -292,8 +292,9 @@ bool mcf_edma_filter_fn(struct dma_chan *chan, void *param)
 {
 	if (chan->device->dev->driver == &mcf_edma_driver.driver) {
 		struct fsl_edma_chan *mcf_chan = to_fsl_edma_chan(chan);
+		unsigned int req = *(unsigned int *)param;
 
-		return (mcf_chan->slave_id == (u32)param);
+		return (mcf_chan->slave_id == req);
 	}
 
 	return false;
include/linux/platform_data/dma-mcf-edma.h +0 -0
index d718ccfa3421..97cb79bda646 100644

include/linux/platform_data/dma-mcf-edma.h struct dma_slave_map; · line 24

Quoted 5 lines
include/linux/platform_data/dma-mcf-edma.h +1 -1
@@ -21,7 +21,7 @@ struct dma_slave_map;
 
 bool mcf_edma_filter_fn(struct dma_chan *chan, void *param);
 
-#define MCF_EDMA_FILTER_PARAM(ch)	((void *)ch)
+#define MCF_EDMA_FILTER_PARAM(ch)	((int[]) { (ch) })

I dont think you answered me about this, why is this change required and in the context of current patch, what does it fix?