Skip to contentSkip to conversation

arm64: Remove unused VGA console support

PATCH New Andrew Murray 3 participants 3 messages Sep 13, 2018 – Sep 21, 2018 arm64

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: Remove unused VGA console support

Support for VGA_CONSOLE is not allowable due to commit ee23794b8668 ("video: vgacon: Don't build on arm64"), thus remove the associated unused code.

Whilst PCI on arm64 would support VGA a valid screen_info structure is missing.

---
 arch/arm64/kernel/setup.c | 4 ----
 1 file changed, 4 deletions(-)
arch/arm64/kernel/setup.c +0 -4
index 5b4fac4..95670a1 100644
@@ -351,12 +351,8 @@ void __init setup_arch(char **cmdline_p)
 #endif
 
 #ifdef CONFIG_VT
-#if defined(CONFIG_VGA_CONSOLE)
-	conswitchp = &vga_con;
-#elif defined(CONFIG_DUMMY_CONSOLE)
 	conswitchp = &dummy_con;
 #endif
-#endif
 	if (boot_args[1] || boot_args[2] || boot_args[3]) {
 		pr_err("WARNING: x1-x3 nonzero in violation of boot protocol:\n"
 			"\tx1: %016llx\n\tx2: %016llx\n\tx3: %016llx\n"
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 arm64: Remove unused VGA console support

Quoted 11 lines · Andrew Murray

Support for VGA_CONSOLE is not allowable due to commit ee23794b8668 ("video: vgacon: Don't build on arm64"), thus remove the associated unused code.

Whilst PCI on arm64 would support VGA a valid screen_info structure is missing.

---
 arch/arm64/kernel/setup.c | 4 ----
 1 file changed, 4 deletions(-)

Will

maintainer Applied
#2 lore raw

PATCH 1/1 arm64: Remove unused VGA console support

In reply to Andrew Murray
Quoted 8 lines · Andrew Murray

Support for VGA_CONSOLE is not allowable due to commit ee23794b8668 ("video: vgacon: Don't build on arm64"), thus remove the associated unused code.

Whilst PCI on arm64 would support VGA a valid screen_info structure is missing.

Queued for 4.20. Thanks.

Signature · 1 line
Catalin