Skip to contentSkip to conversation

linuxptp: needs NPTL

PATCH New Fabrice Fontaine 4 participants 4 messages Sep 15, 2018 – Sep 20, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linuxptp: needs NPTL

/home/buildroot/autobuild/run/instance-1/output/host/bin/or1k-linux-gcc phc_ctl.o phc.o sk.o util.o clockadj.o sysoff.o print.o version.o -lm -lrt -o phc_ctl
phc2sys.o: In function `do_loop':
phc2sys.c:(.text+0x18bc): undefined reference to `clock_nanosleep'

Fixes:
- http://autobuild.buildroot.org/results/a31e0a5ae15e1164115e4e5981ef5fb3c3284bcc

---
 package/linuxptp/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/linuxptp/Config.in +4 -0
index 3e18a0cb13..a32dbde2e1 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LINUXPTP
 	bool "linuxptp"
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
 	help
 	  The Linux PTP Project is the Precision Time Protocol
 	  implementation according to IEEE standard 1588 for Linux.
@@ -11,3 +12,6 @@ config BR2_PACKAGE_LINUXPTP
 	  not a goal.
 
 	  http://linuxptp.sourceforge.net/
+
+comment "linuxptp needs a toolchain w/ NPTL"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 linuxptp: needs NPTL

Hi Fabrice,

Quoted 6 lines · Fabrice Fontaine

/home/buildroot/autobuild/run/instance-1/output/host/bin/or1k-linux-gcc phc_ctl.o phc.o sk.o util.o clockadj.o sysoff.o print.o version.o -lm -lrt -o phc_ctl
phc2sys.o: In function `do_loop':
phc2sys.c:(.text+0x18bc): undefined reference to `clock_nanosleep'

Fixes:
- http://autobuild.buildroot.org/results/a31e0a5ae15e1164115e4e5981ef5fb3c3284bcc

This should only affect 2018.02.x. The latest uClibc-ng version provides clock_nanosleep() even for non NPTL configurations.

baruch

Quoted 23 lines
---
 package/linuxptp/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/linuxptp/Config.in +4 -0
index 3e18a0cb13..a32dbde2e1 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LINUXPTP
 	bool "linuxptp"
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
 	help
 	  The Linux PTP Project is the Precision Time Protocol
 	  implementation according to IEEE standard 1588 for Linux.
@@ -11,3 +12,6 @@ config BR2_PACKAGE_LINUXPTP
 	  not a goal.
 
 	  http://linuxptp.sourceforge.net/
+
+comment "linuxptp needs a toolchain w/ NPTL"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 linuxptp: needs NPTL

Hello,

Quoted 10 lines · Baruch Siach
Quoted 6 lines · Fabrice Fontaine

/home/buildroot/autobuild/run/instance-1/output/host/bin/or1k-linux-gcc phc_ctl.o phc.o sk.o util.o clockadj.o sysoff.o print.o version.o -lm -lrt -o phc_ctl
phc2sys.o: In function `do_loop':
phc2sys.c:(.text+0x18bc): undefined reference to `clock_nanosleep'

Fixes:
- http://autobuild.buildroot.org/results/a31e0a5ae15e1164115e4e5981ef5fb3c3284bcc

This should only affect 2018.02.x. The latest uClibc-ng version provides clock_nanosleep() even for non NPTL configurations.

Indeed. Due to this, perhaps there's a bunch of NPTL dependencies we could remove:

package/blktrace/Config.in:     depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
package/can-utils/Config.in:    depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
package/dvblast/Config.in:      depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
package/nilfs-utils/Config.in:  depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()

Anyway, for this linuxptp change, I have marked the patch as "Delegated to Peter" on patchwork, so that Peter takes care of it.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 linuxptp: needs NPTL

Quoted 21 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

Quoted 7 lines · Baruch Siach
Quoted 6 lines · Fabrice Fontaine

/home/buildroot/autobuild/run/instance-1/output/host/bin/or1k-linux-gcc phc_ctl.o phc.o sk.o util.o clockadj.o sysoff.o print.o version.o -lm -lrt -o phc_ctl
phc2sys.o: In function `do_loop':
phc2sys.c:(.text+0x18bc): undefined reference to `clock_nanosleep'

Quoted 5 lines
Quoted 2 lines

Fixes:
- http://autobuild.buildroot.org/results/a31e0a5ae15e1164115e4e5981ef5fb3c3284bcc

This should only affect 2018.02.x. The latest uClibc-ng version provides clock_nanosleep() even for non NPTL configurations.

Indeed. Due to this, perhaps there's a bunch of NPTL dependencies we could remove:

Quoted 7 lines
package/blktrace/Config.in:     depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
package/can-utils/Config.in:    depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
package/dvblast/Config.in:      depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
package/nilfs-utils/Config.in:  depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()

Anyway, for this linuxptp change, I have marked the patch as "Delegated to Peter" on patchwork, so that Peter takes care of it.

Committed to 2018.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard