Skip to contentSkip to conversation

net: rds: use memset to optimize the recv

PATCH Applied Zhu Yanjun 2 participants 2 messages Sep 17, 2018

Subsystems (4)
lore
Share & tools
lore

Zhu Yanjun

author
#0 lore raw

PATCH v2 1/1 net: rds: use memset to optimize the recv

The function rds_inc_init is in recv process. To use memset can optimize the function rds_inc_init.
The test result:

Before:
1) + 24.950 us | rds_inc_init [rds]();
After:
1) + 10.990 us | rds_inc_init [rds]();

---
V1->V2: a new patch for net-next

---
 net/rds/recv.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
net/rds/recv.c +1 -4
index 12719653188a..727639dac8a7 100644
@@ -43,8 +43,6 @@
 void rds_inc_init(struct rds_incoming *inc, struct rds_connection *conn,
 		 struct in6_addr *saddr)
 {
-	int i;
-
 	refcount_set(&inc->i_refcount, 1);
 	INIT_LIST_HEAD(&inc->i_item);
 	inc->i_conn = conn;
@@ -52,8 +50,7 @@ void rds_inc_init(struct rds_incoming *inc, struct rds_connection *conn,
 	inc->i_rdma_cookie = 0;
 	inc->i_rx_tstamp = ktime_set(0, 0);
 
-	for (i = 0; i < RDS_RX_MAX_TRACES; i++)
-		inc->i_rx_lat_trace[i] = 0;
+	memset(inc->i_rx_lat_trace, 0, sizeof(inc->i_rx_lat_trace));
 }
 EXPORT_SYMBOL_GPL(rds_inc_init);
 
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw

From: Zhu Yanjun <[email protected]>
Date: Sun, 16 Sep 2018 22:49:30 -0400

Quoted 9 lines

The function rds_inc_init is in recv process. To use memset can optimize the function rds_inc_init.
The test result:

Before:
1) + 24.950 us | rds_inc_init [rds]();
After:
1) + 10.990 us | rds_inc_init [rds]();

Quoted 4 lines

---
V1->V2: a new patch for net-next

Applied.