x86: tangier: Fix pinmux warning
PATCH 1/1 x86: tangier: Fix pinmux warning
Currently the code builds with a warning:
w+../arch/x86/cpu/tangier/pinmux.c: In function 'tangier_pinctrl_probe':w+../arch/x86/cpu/tangier/pinmux.c:175:11: warning: format '%d' expects argument of type 'int', but argument 3 has type 'ofnode {aka union ofnode_union}' [-Wformat=]
This fixes it.
---
arch/x86/cpu/tangier/pinmux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/cpu/tangier/pinmux.c +2 -2
@@ -172,8 +172,8 @@ static int tangier_pinctrl_probe(struct udevice *dev)ofnode_for_each_subnode (pin_node,dev_ofnode (dev)) { ret =mrfld_pinctrl_cfg_pin (pin_node);if (ret) { -pr_err ("%s: invalid configuration for the pin %d\n" , - __func__, pin_node); +pr_err ("%s: invalid configuration for the pin %ld\n" , + __func__, pin_node.of_offset); } }
Signature · 1 line
2.7.4
PATCH 1/1 x86: tangier: Fix pinmux warning
Hi Georgii,
Quoted 8 lines · Bin Meng
Currently the code builds with a warning:
w+../arch/x86/cpu/tangier/pinmux.c: In function 'tangier_pinctrl_probe':w+../arch/x86/cpu/tangier/pinmux.c:175:11: warning: format '%d' expects argument of type 'int', but argument 3 has type 'ofnode {aka unionofnode_union}' [-Wformat=]
Quoted 8 lines
This fixes it.
Signed-off-by Bin Meng <[email protected]>---
arch/x86/cpu/tangier/pinmux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Please confirm whether this looks good. If no issue, I will squash this commit into your previous patch [2/5] "x86: tangier: pinmux: add API to configure protected pins"
Regards,
Bin
PATCH 1/1 x86: tangier: Fix pinmux warning
Quoted 20 lines · Bin Meng
Hi Georgii,
Quoted 8 lines · Bin Meng
Currently the code builds with a warning:
w+../arch/x86/cpu/tangier/pinmux.c: In function 'tangier_pinctrl_probe':w+../arch/x86/cpu/tangier/pinmux.c:175:11: warning: format '%d' expects argument of type 'int', but argument 3 has type 'ofnode {aka unionofnode_union}' [-Wformat=]Quoted 8 lines
This fixes it.
Signed-off-by Bin Meng <[email protected]>---
arch/x86/cpu/tangier/pinmux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 6 lines
Please confirm whether this looks good. If no issue, I will squash this commit into your previous patch [2/5] "x86: tangier: pinmux: add API to configure protected pins"
Regards,
Bin
Hi Bin,
Thanks for taking care of it so fast. Sorry for the trouble. LGTM. Squash it, please.
Regards,
Georgii
PATCH 1/1 x86: tangier: Fix pinmux warning
Quoted 26 lines · Georgii Staroselskii
Quoted 24 lines · Bin Meng
Hi Georgii,
Quoted 8 lines · Bin Meng
Currently the code builds with a warning:
w+../arch/x86/cpu/tangier/pinmux.c: In function 'tangier_pinctrl_probe':w+../arch/x86/cpu/tangier/pinmux.c:175:11: warning: format '%d' expects argument of type 'int', but argument 3 has type 'ofnode {aka unionofnode_union}' [-Wformat=]Quoted 8 lines
This fixes it.
Signed-off-by Bin Meng <[email protected]>---
arch/x86/cpu/tangier/pinmux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Please confirm whether this looks good. If no issue, I will squash this commit into your previous patch [2/5] "x86: tangier: pinmux: add API to configure protected pins"
Quoted 8 lines
Quoted 2 lines
Regards,
BinHi Bin,
Thanks for taking care of it so fast. Sorry for the trouble. LGTM. Squash it, please.
OK, squashed.
Regards,
Bin