monkey: add option for SSL/TLS plugin compilation
PATCH 2/2 monkey: add option for SSL/TLS plugin compilation
This commit add an option to enable SSL/TLS plugin compilation who is not build
by default.
If mbedtls library is selected, she will be used instead of build-in one.
--- package/monkey/Config.in | 5 +++++ package/monkey/monkey.mk | 8 ++++++++ 2 files changed, 13 insertions(+)
package/monkey/Config.in +5 -0
@@ -19,6 +19,11 @@ config BR2_PACKAGE_MONKEY_SHARED endif +config BR2_PACKAGE_MONKEY_SSL + bool "enable SSL/TLS" + help + Enable build of the SSL/TLS plugin. + comment "monkey needs an toolchain w/ threads, dynamic library" depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
package/monkey/monkey.mk +8 -0
@@ -48,6 +48,14 @@ ifeq ($(BR2_ENABLE_DEBUG),y) MONKEY_CONF_OPTS += --debug endif +ifeq ($(BR2_PACKAGE_MONKEY_SSL), y) +MONKEY_CONF_OPTS += --enable-plugins=tls +# If we already have TLS/SSL library, use it. +ifeq ($(BR2_PACKAGE_MBEDTLS), y) +MONKEY_CONF_OPTS += --mbedtls-shared +endif +endif + define MONKEY_CONFIGURE_CMDS (cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure $(MONKEY_CONF_OPTS)) endef
Signature · 1 line
2.7.4
PATCH 2/2 monkey: add option for SSL/TLS plugin compilation
Hello David,
Thanks for your contribution!
Quoted 4 lines · Pierret David
This commit add an option to enable SSL/TLS plugin compilation who is not build
by default.
If mbedtls library is selected, she will be used instead of build-in one.
We always want to use external libraries instead of bundled libraries.
package/monkey/Config.in config BR2_PACKAGE_MONKEY_SHARED · line 25
Quoted 4 lines
package/monkey/Config.in +4
-0+config BR2_PACKAGE_MONKEY_SSL + bool "enable SSL/TLS" + help + Enable build of the SSL/TLS plugin.
Please use one tab to indent bool and help, and one tab + two spaces to indent the help text.
Make sure to run "make check-package" after your changes to verify that you do not introduce coding style issues such as those ones.
Quoted 1 line
+ifeq ($(BR2_PACKAGE_MONKEY_SSL), y)
No space before "y".
package/monkey/monkey.mk ifeq ($(BR2_ENABLE_DEBUG),y) · line 57
Quoted 6 lines
package/monkey/monkey.mk +6
-0+MONKEY_CONF_OPTS += --enable-plugins=tls +# If we already have TLS/SSL library, use it. +ifeq ($(BR2_PACKAGE_MBEDTLS), y) +MONKEY_CONF_OPTS += --mbedtls-shared +endif +endif
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 2/2 monkey: add option for SSL/TLS plugin compilation
Hello Thomas,
Thank's for review
Quoted 1 line
Quoted 1 line
We always want to use external libraries instead of bundled libraries.
Ok, I define the mbedtls as a select.
I'm not yet comfortable with mailing list :/
Regards,
David
Le 17/09/2018 ? 12:01, Thomas Petazzoni a ?crit?:
Quoted 38 lines
Hello David,
Thanks for your contribution!
Quoted 4 lines · Pierret David
This commit add an option to enable SSL/TLS plugin compilation who is not build
by default.
If mbedtls library is selected, she will be used instead of build-in one.We always want to use external libraries instead of bundled libraries.
package/monkey/Config.in config BR2_PACKAGE_MONKEY_SHARED · line 25
Quoted 4 lines
package/monkey/Config.in +4
-0+config BR2_PACKAGE_MONKEY_SSL + bool "enable SSL/TLS" + help + Enable build of the SSL/TLS plugin.Please use one tab to indent bool and help, and one tab + two spaces to indent the help text.
Make sure to run "make check-package" after your changes to verify that you do not introduce coding style issues such as those ones.
Quoted 1 line
+ifeq ($(BR2_PACKAGE_MONKEY_SSL), y)
No space before "y".
package/monkey/monkey.mk ifeq ($(BR2_ENABLE_DEBUG),y) · line 57
Quoted 6 lines
package/monkey/monkey.mk +6
-0+MONKEY_CONF_OPTS += --enable-plugins=tls +# If we already have TLS/SSL library, use it. +ifeq ($(BR2_PACKAGE_MBEDTLS), y) +MONKEY_CONF_OPTS += --mbedtls-shared +endif +endifThanks!
Thomas
Signature · 90 lines
<div>
<link href="https://fonts.googleapis.com/css?family=Raleway"
rel="stylesheet" type="text/css">
<font face="Raleway, regular">
<table style="padding:20px;margin-bottom:-10px" border=0>
<tbody>
<tr>
<td style="font-size:13px; color:#ff8054; text-align:
center; padding-right:30px">
<a href="http://www.smile.eu/">
<img style="max-width:100%; height:auto"
src="http://ftp.smile.fr/client/Communication/signature/img/Logo-new.png"
alt="SMILE"/>
</a><br/><br/>
<p style="line-heigth:8px">2 Esplanade Compans
Caffarelli, 31100 Toulouse</p>
</td>
<td style="border-left: 1px solid #3b7ffe;
padding-left:20px; font-size:13px; color:#ff8054;">
<div style="color:#ff8054; font-size:14px;">
<b>David PIERRET</b>
</div>
<div style="color:#3b7ffe; font-size:13px;">
Ing?nieur Etude et D?veloppement<br>
</div><br>
<div style="color:#3b7ffe; font-size:13px;">
<span style="white-space: nowrap"><img
style="margin-right:5px"
src="http://ftp.smile.fr/client/Communication/signature/img/mail.png"
alt="email" width="12" height="10" />
<a href="mailto:[email protected]"
style="color:#3b7ffe; font-size:13px;
text-decoration:none;">david.pierret at smile.fr</a>
</span>
<br>
<span style="white-space:
nowrap"><img style="margin-right:5px"
src="http://ftp.smile.fr/client/Communication/signature/img/phone.png"
alt="phone" width="10" height="10" /></span>
+33662312341
<br>
<span
style="white-space: nowrap"><img style="margin-right:5px"
src="http://ftp.smile.fr/client/Communication/signature/img/web.png"
alt="url" width="12" height="12" />
<a href="http://www.smile.eu/" style="color:#3b7ffe; font-size:13px;
text-decoration:none;">http://www.smile.eu/</a>
</span>
</div>
<br>
<div>
<span><a style="margin-right:5px"
href="https://twitter.com/openwide_inge"><img
src="http://ftp.smile.fr/client/Communication/signature/img/rs-twitter.png"
alt="Twitter" style="max-width:100%; height:auto"/></a></span>
<span><a style="margin-right:5px"
href="https://www.facebook.com/smileopensource"><img
src="http://ftp.smile.fr/client/Communication/signature/img/rs-facebook.png"
alt="Facebook" style="max-width:100%; height:auto"></a></span>
<span><a style="margin-right:5px"
href="https://fr.linkedin.com/in/david-pierret-11912290"><img
src="http://ftp.smile.fr/client/Communication/signature/img/rs-linkedin.png"
alt="LinkedIn" style="max-width:100%; height:auto"/></a></span>
<span><a style="margin-right:5px"
href="https://github.com/Smile-SA"><img
src="http://ftp.smile.fr/client/Communication/signature/img/rs-github.png"
alt="Github" style="max-width:100%; height:auto"/></a></span>
</div>
</td>
</tr>
</tbody>
</table>
<br>
<div> <a
href="https://www.smile.eu/fr/publications/livres-blancs/freertos-aws?utm_source=signature&utm_medium=email&utm_campaign=signature"><img
src="https://signature.smile.eu/assets/img/bandeaux_signature_mail_FreeRTOS.gif.gif"
alt="D?couvrez l?univers Smile, rendez-vous sur smile.eu" border="0"
/></a></div>
<br>
<div style="color:#a3acb5; font-size:10px;">
<img
src="http://ftp.smile.fr/client/Communication/signature/img/eco.png"
alt="eco" width="13" height="11" />
Pour la plan?te, n'imprimez ce mail que si c'est n?cessaire
</div>
</font>
</div>PATCH 2/2 monkey: add option for SSL/TLS plugin compilation
This commit add an option to enable SSL/TLS plugin compilation who is not build
by default.
--- package/monkey/Config.in | 6 ++++++ package/monkey/monkey.mk | 4 ++++ 2 files changed, 10 insertions(+)
package/monkey/Config.in +6 -0
@@ -17,6 +17,12 @@ config BR2_PACKAGE_MONKEY_SHARED Build Monkey as a shared library in addition to stand-alone server +config BR2_PACKAGE_MONKEY_SSL + bool "enable SSL/TLS" + select BR2_PACKAGE_MBEDTLS + help + Enable build of the SSL/TLS plugin. + endif comment "monkey needs an toolchain w/ threads, dynamic library"
package/monkey/monkey.mk +4 -0
@@ -48,6 +48,10 @@ ifeq ($(BR2_ENABLE_DEBUG),y) MONKEY_CONF_OPTS += --debug endif +ifeq ($(BR2_PACKAGE_MONKEY_SSL),y) +MONKEY_CONF_OPTS += --enable-plugins=tls --mbedtls-shared +endif + define MONKEY_CONFIGURE_CMDS (cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure $(MONKEY_CONF_OPTS)) endef
Signature · 4 lines
2.7.4 Le 17/09/2018 ? 13:29, Pierret David a ?crit?:
Quoted 53 lines
Hello Thomas,
Thank's for review
Quoted 1 line
Quoted 1 line
We always want to use external libraries instead of bundled libraries.
Ok, I define the mbedtls as a select.
I'm not yet comfortable with mailing list :/Regards,
DavidLe 17/09/2018 ? 12:01, Thomas Petazzoni a ?crit?:
Quoted 39 lines
Hello David,
Thanks for your contribution!
Quoted 5 lines · Pierret David
This commit add an option to enable SSL/TLS plugin compilation who is not build
by default.
If mbedtls library is selected, she will be used instead of build-in one.We always want to use external libraries instead of bundled libraries.
Quoted 4 lines
+config
BR2_PACKAGE_MONKEY_SSL
+??????? bool "enable SSL/TLS"
+??????? help
+????????? Enable build of the SSL/TLS plugin.Please use one tab to indent bool and help, and one tab + two spaces to indent the help text.
Make sure to run "make check-package" after your changes to verify that you do not introduce coding style issues such as those ones.
Quoted 1 line
+ifeq ($(BR2_PACKAGE_MONKEY_SSL), y)
No space before "y".
Review
Quoted 6 lines
(quoted diff) +6
-0+MONKEY_CONF_OPTS += --enable-plugins=tls +# If we already have TLS/SSL library, use it. +ifeq ($(BR2_PACKAGE_MBEDTLS), y) +MONKEY_CONF_OPTS += --mbedtls-shared +endif +endifThanks!
Thomas
Signature · 90 lines
<div>
<link href="https://fonts.googleapis.com/css?family=Raleway"
rel="stylesheet" type="text/css">
<font face="Raleway, regular">
<table style="padding:20px;margin-bottom:-10px" border=0>
<tbody>
<tr>
<td style="font-size:13px; color:#ff8054; text-align:
center; padding-right:30px">
<a href="http://www.smile.eu/">
<img style="max-width:100%; height:auto"
src="http://ftp.smile.fr/client/Communication/signature/img/Logo-new.png"
alt="SMILE"/>
</a><br/><br/>
<p style="line-heigth:8px">2 Esplanade Compans
Caffarelli, 31100 Toulouse</p>
</td>
<td style="border-left: 1px solid #3b7ffe;
padding-left:20px; font-size:13px; color:#ff8054;">
<div style="color:#ff8054; font-size:14px;">
<b>David PIERRET</b>
</div>
<div style="color:#3b7ffe; font-size:13px;">
Ing?nieur Etude et D?veloppement<br>
</div><br>
<div style="color:#3b7ffe; font-size:13px;">
<span style="white-space: nowrap"><img
style="margin-right:5px"
src="http://ftp.smile.fr/client/Communication/signature/img/mail.png"
alt="email" width="12" height="10" />
<a href="mailto:[email protected]"
style="color:#3b7ffe; font-size:13px;
text-decoration:none;">david.pierret at smile.fr</a>
</span>
<br>
<span style="white-space:
nowrap"><img style="margin-right:5px"
src="http://ftp.smile.fr/client/Communication/signature/img/phone.png"
alt="phone" width="10" height="10" /></span>
+33662312341
<br>
<span
style="white-space: nowrap"><img style="margin-right:5px"
src="http://ftp.smile.fr/client/Communication/signature/img/web.png"
alt="url" width="12" height="12" />
<a href="http://www.smile.eu/" style="color:#3b7ffe; font-size:13px;
text-decoration:none;">http://www.smile.eu/</a>
</span>
</div>
<br>
<div>
<span><a style="margin-right:5px"
href="https://twitter.com/openwide_inge"><img
src="http://ftp.smile.fr/client/Communication/signature/img/rs-twitter.png"
alt="Twitter" style="max-width:100%; height:auto"/></a></span>
<span><a style="margin-right:5px"
href="https://www.facebook.com/smileopensource"><img
src="http://ftp.smile.fr/client/Communication/signature/img/rs-facebook.png"
alt="Facebook" style="max-width:100%; height:auto"></a></span>
<span><a style="margin-right:5px"
href="https://fr.linkedin.com/in/david-pierret-11912290"><img
src="http://ftp.smile.fr/client/Communication/signature/img/rs-linkedin.png"
alt="LinkedIn" style="max-width:100%; height:auto"/></a></span>
<span><a style="margin-right:5px"
href="https://github.com/Smile-SA"><img
src="http://ftp.smile.fr/client/Communication/signature/img/rs-github.png"
alt="Github" style="max-width:100%; height:auto"/></a></span>
</div>
</td>
</tr>
</tbody>
</table>
<br>
<div> <a
href="https://www.smile.eu/fr/publications/livres-blancs/freertos-aws?utm_source=signature&utm_medium=email&utm_campaign=signature"><img
src="https://signature.smile.eu/assets/img/bandeaux_signature_mail_FreeRTOS.gif.gif"
alt="D?couvrez l?univers Smile, rendez-vous sur smile.eu" border="0"
/></a></div>
<br>
<div style="color:#a3acb5; font-size:10px;">
<img
src="http://ftp.smile.fr/client/Communication/signature/img/eco.png"
alt="eco" width="13" height="11" />
Pour la plan?te, n'imprimez ce mail que si c'est n?cessaire
</div>
</font>
</div>PATCH 2/2 monkey: add option for SSL/TLS plugin compilation
Hello,
Quoted 5 lines · Pierret David
This commit add an option to enable SSL/TLS plugin compilation who is not build
by default.Signed-off-by David Pierret <[email protected]>
Could you send a proper v2 of the patch series ?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com