Skip to contentSkip to conversation

drm: Return -EOPNOTSUPP in drm_setclientcap() when driver do not support KMS

PATCH Superseded José Roberto de Souza 3 participants 4 messages Sep 17, 2018 – Sep 18, 2018

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm: Return -EOPNOTSUPP in drm_setclientcap() when driver do not support KMS

All DRM_CLIENT capabilities are tied to KMS support, so returning -EOPNOTSUPP when KMS is not supported.

v2: returning -EOPNOTSUPP(same value as posix ENOTSUP and available in uapi) instead of -ENOTSUPP

---
 drivers/gpu/drm/drm_ioctl.c      | 3 +++
 drivers/gpu/drm/i915/i915_perf.c | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/drm_ioctl.c +3 -0
index 60dfbfae6a02..c0de628c194c 100644
@@ -306,6 +306,9 @@ drm_setclientcap(struct drm_device *dev, void *data, struct drm_file *file_priv)
 {
 	struct drm_set_client_cap *req = data;
 
+	if (!drm_core_check_feature(dev, DRIVER_MODESET))
+		return -EOPNOTSUPP;
+
 	switch (req->capability) {
 	case DRM_CLIENT_CAP_STEREO_3D:
 		if (req->value > 1)
drivers/gpu/drm/i915/i915_perf.c +1 -1
index 664b96bb65a3..c1edd1e69a3e 100644
@@ -2817,7 +2817,7 @@ int i915_perf_open_ioctl(struct drm_device *dev, void *data,
 
 	if (!dev_priv->perf.initialized) {
 		DRM_DEBUG("i915 perf interface not available for this system\n");
-		return -ENOTSUPP;
+		return -EOPNOTSUPP;
 	}
 
 	known_open_flags = I915_PERF_FLAG_FD_CLOEXEC |
Signature · 6 lines
2.19.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for drm: Return -EOPNOTSUPP in drm_setclientcap() when driver do not support KMS

== Series Details ==

== Series Details ==

Series: drm: Return -EOPNOTSUPP in drm_setclientcap() when driver do not support KMS
URL : https://patchwork.freedesktop.org/series/49816/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4834 -> Patchwork_10207 =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_10207 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10207, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/49816/revisions/1/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10207:

=== IGT changes ===

    ==== Warnings ====

    igt@pm_rpm@module-reload:
      fi-hsw-4770r:       SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_10207 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_guc:
      fi-skl-guc:         NOTRUN -> DMESG-WARN (fdo#107258)

    igt@gem_exec_suspend@basic-s4-devices:
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_psr@primary_page_flip:
      fi-icl-u:           PASS -> FAIL (fdo#107336)

    
    ==== Possible fixes ====

    igt@drv_module_reload@basic-reload-inject:
      fi-hsw-4770r:       DMESG-WARN (fdo#107924, fdo#107425) -> PASS

    igt@kms_psr@primary_page_flip:
      fi-kbl-r:           FAIL (fdo#107336) -> PASS

fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107924 https://bugs.freedesktop.org/show_bug.cgi?id=107924

== Participating hosts (47 -> 40) ==

Additional (1): fi-skl-guc
Missing (8): fi-ilk-m540 fi-skl-gvtdvm fi-hsw-4200u fi-bdw-gvtdvm fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper

== Build changes ==

* Linux: CI_DRM_4834 -> Patchwork_10207

CI_DRM_4834: e13c7f93395b309bc440805cb7ee957c63324fa0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4645: 03b90a39ed12a568c9da752466ea708d6348e110 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10207: d576890f0facb93320df622de6ee3c2cb7841099 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

d576890f0fac drm: Return -EOPNOTSUPP in drm_setclientcap() when driver do not support KMS

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10207/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.IGT: success for drm: Return -EOPNOTSUPP in drm_setclientcap() when driver do not support KMS

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: drm: Return -EOPNOTSUPP in drm_setclientcap() when driver do not support KMS
URL : https://patchwork.freedesktop.org/series/49816/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4834_full -> Patchwork_10207_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_10207_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10207_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10207_full:

=== IGT changes ===

    ==== Warnings ====

    igt@pm_rc6_residency@rc6-accuracy:
      shard-snb:          SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_10207_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_big:
      shard-hsw:          PASS -> TIMEOUT (fdo#107937)

    igt@kms_busy@extended-modeset-hang-newfb-render-b:
      shard-glk:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_cursor_legacy@pipe-b-torture-bo:
      shard-glk:          PASS -> INCOMPLETE (k.org#198133, fdo#103359)

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-glk:          PASS -> FAIL (fdo#105363)

    igt@kms_flip@dpms-vs-vblank-race-interruptible:
      shard-glk:          PASS -> FAIL (fdo#103060)

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#102887, fdo#105363)

    
    ==== Possible fixes ====

    igt@gem_exec_schedule@preempt-contexts-render:
      shard-snb:          INCOMPLETE (fdo#105411) -> SKIP

    igt@kms_atomic_transition@plane-all-modeset-transition:
      shard-glk:          INCOMPLETE (k.org#198133, fdo#103359) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack:
      shard-glk:          FAIL (fdo#103167) -> PASS

fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#107937 https://bugs.freedesktop.org/show_bug.cgi?id=107937
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4834 -> Patchwork_10207

CI_DRM_4834: e13c7f93395b309bc440805cb7ee957c63324fa0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4645: 03b90a39ed12a568c9da752466ea708d6348e110 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10207: d576890f0facb93320df622de6ee3c2cb7841099 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10207/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to José Roberto de Souza

Quoting José Roberto de Souza (2018-09-17 22:22:44)

Quoted 18 lines

All DRM_CLIENT capabilities are tied to KMS support, so returning -EOPNOTSUPP when KMS is not supported.

v2: returning -EOPNOTSUPP(same value as posix ENOTSUP and available in uapi) instead of -ENOTSUPP

---
 drivers/gpu/drm/drm_ioctl.c      | 3 +++
 drivers/gpu/drm/i915/i915_perf.c | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/drm_ioctl.c +0 -0
index 60dfbfae6a02..c0de628c194c 100644

drivers/gpu/drm/drm_ioctl.c drm_setclientcap(struct drm_device *dev, void *data, struct drm_file *file_priv) · line 308

Quoted 3 lines
drivers/gpu/drm/drm_ioctl.c +0 -0
@@ -306,6 +306,9 @@ drm_setclientcap(struct drm_device *dev, void *data, struct drm_file *file_priv)
 {
        struct drm_set_client_cap *req = data;
 

I liked Daniel's comment suggestion.

Quoted 11 lines
drivers/gpu/drm/drm_ioctl.c +3 -0
+       if (!drm_core_check_feature(dev, DRIVER_MODESET))
+               return -EOPNOTSUPP;
+
        switch (req->capability) {
        case DRM_CLIENT_CAP_STEREO_3D:
                if (req->value > 1)
drivers/gpu/drm/i915/i915_perf.c +0 -0
index 664b96bb65a3..c1edd1e69a3e 100644

drivers/gpu/drm/i915/i915_perf.c int i915_perf_open_ioctl(struct drm_device *dev, void *data, · line 2820

Quoted 5 lines
drivers/gpu/drm/i915/i915_perf.c +1 -1
@@ -2817,7 +2817,7 @@ int i915_perf_open_ioctl(struct drm_device *dev, void *data,
 
        if (!dev_priv->perf.initialized) {
                DRM_DEBUG("i915 perf interface not available for this system\n");
-               return -ENOTSUPP;
+               return -EOPNOTSUPP;

Better served as a separate patch, so it can be applied to different trees.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx