Skip to contentSkip to conversation

at: bump version

PATCH Superseded Giulio Benetti 4 participants 23 messages Sep 17, 2018 – Sep 23, 2018

lore
Share & tools
lore
#0 lore raw

cover at: bump version

As suggested at https://elinux.org/Buildroot#Todo_list:
"Update the at package to use the upstream.
http://anonscm.debian.org/gitweb/?p=collab-maint/at.git;a=summary"
In the meanwhile that site became unreachable and the at upstream now is:
https://salsa.debian.org/debian/at

These are the basic tasks done:
- change upstream site, bump version
- add sha256 for legal-info files

Giulio Benetti (2):
at: change upstream site, bump version
at: add sha256 for legal-info files

 ...-Makefile-fix-parallel-build-failure.patch | 33 +++++++++++++++++++
 package/at/at.hash                            |  7 ++--
 package/at/at.mk                              |  9 ++---
 3 files changed, 43 insertions(+), 6 deletions(-)
 create mode 100644 package/at/0007-Makefile-fix-parallel-build-failure.patch
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 at: change upstream site, bump version

Minicom is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file

---
 ...-Makefile-fix-parallel-build-failure.patch | 33 +++++++++++++++++++
 package/at/at.hash                            |  4 +--
 package/at/at.mk                              |  9 ++---
 3 files changed, 40 insertions(+), 6 deletions(-)
 create mode 100644 package/at/0007-Makefile-fix-parallel-build-failure.patch
package/at/0007-Makefile-fix-parallel-build-failure.patch new file +33 -0
new file mode 100644
index 0000000000..145e8fa8c9
@@ -0,0 +1,33 @@
+From 5b98a3166ddc03dbe040bef2de464166a5b7ab78 Mon Sep 17 00:00:00 2001
+From: Giulio Benetti <[email protected]>
+Date: Tue, 4 Sep 2018 15:21:26 +0200
+Subject: [PATCH] Makefile: fix parallel build failure
+
+When issuing make -j build fails reporting:
+parsetime.l:5:10: fatal error: y.tab.h: No such file or directory
+This is because parsetime.l is compiled without waiting for y.tab.h file
+to be created.
+
+Add parsetime.l dependency to y.tab.h in Makefile.in
+
+Signed-off-by: Giulio Benetti <[email protected]>
+---
+ Makefile.in | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/Makefile.in b/Makefile.in
+index 4c11913..18ecc23 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -83,6 +83,8 @@ y.tab.c y.tab.h: parsetime.y
+ lex.yy.c: parsetime.l
+ 	$(LEX) -i parsetime.l
+ 
++parsetime.l: y.tab.h
++
+ atd.service: atd.service.in
+ 	cat $< | sed -e 's![@]sbindir[@]!$(sbindir)!g' | sed -e 's![@]atjobdir[@]!$(atjobdir)!g' > $@
+ 
+-- 
+2.17.1
+
package/at/at.hash +2 -2
index 22c732cc7e..e6eb26d818 100644
@@ -1,2 +1,2 @@
-# From: http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
-sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1  at_3.1.16.orig.tar.gz
+# Locally calculated
+sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
package/at/at.mk +5 -4
index 058ebac5c8..1d42b27b03 100644
@@ -4,10 +4,11 @@
 #
 ################################################################################
 
-AT_VERSION = 3.1.16
-AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
-AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
-# missing deps for parsetime.l
+AT_VERSION = release/3.1.23
+AT_SITE = https://salsa.debian.org/debian/at.git
+AT_SITE_METHOD = git
+# added missing deps for parsetime.l but still parallel build fails in some
+# case, so at the moment let's keep MAKE1
 AT_MAKE = $(MAKE1)
 AT_AUTORECONF = YES
 AT_DEPENDENCIES = $(if $(BR2_PACKAGE_FLEX),flex) host-bison host-flex
Signature · 1 line
2.17.1
#2 lore raw

PATCH v3 1/2 at: change upstream site, bump version

Hello,

Thanks for working on this! This was definitely something that needed to be done for a long time!

Quoted 1 line · Giulio Benetti

Minicom is now available on a git repository at:

Minicom ? :-)

Quoted 7 lines

https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

Quoted 7 lines

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file

---
 ...-Makefile-fix-parallel-build-failure.patch | 33 +++++++++++++++++++

Is it really necessary to have a patch that fixes parallel build, if parallel build is not entirely fixed and you need $(MAKE1) anyway ?

I believe the patch is not necessary. Let's keep MAKE1 for now, and maybe report the parallel build issue upstream.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/2 at: change upstream site, bump version

Il 18/09/2018 09:57, Thomas Petazzoni ha scritto:

Quoted 9 lines

Hello,

Thanks for working on this! This was definitely something that needed to be done for a long time!

Quoted 1 line · Giulio Benetti

Minicom is now available on a git repository at:

Minicom ? :-)

Oops.

Quoted 16 lines
Quoted 8 lines

https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

Quoted 7 lines

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file

---
  ...-Makefile-fix-parallel-build-failure.patch | 33 +++++++++++++++++++
Quoted 5 lines

Is it really necessary to have a patch that fixes parallel build, if parallel build is not entirely fixed and you need $(MAKE1) anyway ?

I believe the patch is not necessary. Let's keep MAKE1 for now, and maybe report the parallel build issue upstream.

Ok, I'm going to submit v2.

By the way, testing it on qemu and also a colleague found that on arm board, atd needs .SEQ file before starting.
Do I have to add this to package?
I mean, if that file doesn't exists in target, then let's create it?

Thanks
Best regards

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#4 lore raw

PATCH v3 1/2 at: change upstream site, bump version

Hello,

Quoted 3 lines · Giulio Benetti

By the way, testing it on qemu and also a colleague found that on arm board, atd needs .SEQ file before starting.
Do I have to add this to package?

What is this .SEQ file ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/2 at: change upstream site, bump version

Hello,

Il 18/09/2018 11:16, Thomas Petazzoni ha scritto:

Quoted 9 lines

Hello,

Quoted 3 lines · Giulio Benetti

By the way, testing it on qemu and also a colleague found that on arm board, atd needs .SEQ file before starting.
Do I have to add this to package?

What is this .SEQ file ?

/var/spool/cron/atjobs/.SEQ is a necessary file for atd which keeps status of scheduled jobs.
If atd doesn't find that file fails to run instead of creating it empty(this is the solution to make it work).
So better add:
touch /var/spool/cron/atjobs/.SEQ on target_dir
to the package.

So I've answered myself :)

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#6 lore raw

v2 cover at: bump version

In reply to Thomas Petazzoni

As suggested at https://elinux.org/Buildroot#Todo_list:
"Update the at package to use the upstream.
http://anonscm.debian.org/gitweb/?p=collab-maint/at.git;a=summary"
In the meanwhile that site became unreachable and the at upstream now is:
https://salsa.debian.org/debian/at

These are the basic tasks done:
- change upstream site, bump version
- add sha256 for legal-info files
- improved S99at init.d script to have live session working (/var/spool linked to /tmp) and warn about it

Giulio Benetti (2):
at: change upstream site, bump version
at: add sha256 for legal-info files

 package/at/S99at   |  9 +++++++++
 package/at/at.hash |  7 +++++--
 package/at/at.mk   | 10 ++++++----
 3 files changed, 20 insertions(+), 6 deletions(-)
Signature · 1 line
2.17.1
#7 lore raw

PATCH v2 1/2 at: change upstream site, bump version

At is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file
- improved S99at script:
if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't work neither for a live session. Create .SEQ file if not found, warning during start that after reboot atjobs could be lost.

---
 package/at/S99at   |  9 +++++++++
 package/at/at.hash |  4 ++--
 package/at/at.mk   | 10 ++++++----
 3 files changed, 17 insertions(+), 6 deletions(-)
package/at/S99at +9 -0
index 666d39b546..fb81736ae2 100755
@@ -6,6 +6,15 @@
 umask 077
 
 start() {
+	# Since /va/spool can be linked to /tmp (tmpfs) 
+	# /var/spool/cron/atjobs/.SEQ created could be not available
+	# Check if not exists otherwise create it
+	if [ ! -f /var/spool/cron/atjobs/.SEQ ]; then
+	    mkdir -p /var/spool/cron/atjobs/
+	    touch /var/spool/cron/atjobs/.SEQ
+	    printf "atd: Created missing .SEQ file. Probably it's in tmpfs and on reboot atjobs will be lost!\n"
+	fi
+
 	printf "Starting atd: "
 	start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
 	echo "OK"
package/at/at.hash +2 -2
index 22c732cc7e..e6eb26d818 100644
@@ -1,2 +1,2 @@
-# From: http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
-sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1  at_3.1.16.orig.tar.gz
+# Locally calculated
+sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
package/at/at.mk +6 -4
index 058ebac5c8..083fbbc74b 100644
@@ -4,10 +4,11 @@
 #
 ################################################################################
 
-AT_VERSION = 3.1.16
-AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
-AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
-# missing deps for parsetime.l
+AT_VERSION = release/3.1.23
+AT_SITE = https://salsa.debian.org/debian/at.git
+AT_SITE_METHOD = git
+# Tried to add missing deps for parsetime.l but still parallel build fails
+# in some case, so at the moment let's keep MAKE1
 AT_MAKE = $(MAKE1)
 AT_AUTORECONF = YES
 AT_DEPENDENCIES = $(if $(BR2_PACKAGE_FLEX),flex) host-bison host-flex
@@ -23,6 +24,7 @@ AT_CONF_OPTS = \
 
 define AT_INSTALL_INIT_SYSV
 	$(INSTALL) -m 0755 -D package/at/S99at $(TARGET_DIR)/etc/init.d/S99at
+	
 endef
 
 $(eval $(autotools-package))
Signature · 1 line
2.17.1
#8 lore raw

PATCH v2 1/2 at: change upstream site, bump version

Forgot to mention V1->V2 Changes:
- removed patch for parallel build since it doesn't work in every case
- improved s99at script to have atd working in live session warning about that after reboot atjobs will be lost.

Sorry.
Kind regards

Signature · 12 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

Il 18/09/2018 23:39, Giulio Benetti ha scritto:
Quoted 81 lines

At is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file
- improved S99at script:
if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't work neither for a live session. Create .SEQ file if not found, warning during start that after reboot atjobs could be lost.

---
  package/at/S99at   |  9 +++++++++
  package/at/at.hash |  4 ++--
  package/at/at.mk   | 10 ++++++----
  3 files changed, 17 insertions(+), 6 deletions(-)
package/at/S99at +9 -0
index 666d39b546..fb81736ae2 100755
@@ -6,6 +6,15 @@
  umask 077
 
  start() {
+	# Since /va/spool can be linked to /tmp (tmpfs)
+	# /var/spool/cron/atjobs/.SEQ created could be not available
+	# Check if not exists otherwise create it
+	if [ ! -f /var/spool/cron/atjobs/.SEQ ]; then
+	    mkdir -p /var/spool/cron/atjobs/
+	    touch /var/spool/cron/atjobs/.SEQ
+	    printf "atd: Created missing .SEQ file. Probably it's in tmpfs and on reboot atjobs will be lost!\n"
+	fi
+
  	printf "Starting atd: "
  	start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
  	echo "OK"
package/at/at.hash +2 -2
index 22c732cc7e..e6eb26d818 100644
@@ -1,2 +1,2 @@
-# From: http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
-sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1  at_3.1.16.orig.tar.gz
+# Locally calculated
+sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
package/at/at.mk +6 -4
index 058ebac5c8..083fbbc74b 100644
@@ -4,10 +4,11 @@
  #
  ################################################################################
 
-AT_VERSION = 3.1.16
-AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
-AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
-# missing deps for parsetime.l
+AT_VERSION = release/3.1.23
+AT_SITE = https://salsa.debian.org/debian/at.git
+AT_SITE_METHOD = git
+# Tried to add missing deps for parsetime.l but still parallel build fails
+# in some case, so at the moment let's keep MAKE1
  AT_MAKE = $(MAKE1)
  AT_AUTORECONF = YES
  AT_DEPENDENCIES = $(if $(BR2_PACKAGE_FLEX),flex) host-bison host-flex
@@ -23,6 +24,7 @@ AT_CONF_OPTS = \
 
  define AT_INSTALL_INIT_SYSV
  	$(INSTALL) -m 0755 -D package/at/S99at $(TARGET_DIR)/etc/init.d/S99at
+	
  endef
 
  $(eval $(autotools-package))
#9 lore raw

PATCH v2 1/2 at: change upstream site, bump version

In reply to Giulio Benetti

Hi Giulio,

Quoted 28 lines · Giulio Benetti

At is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file
- improved S99at script:
if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't work neither for a live session. Create .SEQ file if not found, warning during start that after reboot atjobs could be lost.

---
 package/at/S99at   |  9 +++++++++
 package/at/at.hash |  4 ++--
 package/at/at.mk   | 10 ++++++----
 3 files changed, 17 insertions(+), 6 deletions(-)
package/at/S99at +0 -0
index 666d39b546..fb81736ae2 100755

package/at/S99at line 9

Quoted 4 lines
package/at/S99at +1 -0
@@ -6,6 +6,15 @@
 umask 077
 
 start() {
+	# Since /va/spool can be linked to /tmp (tmpfs) 

va -> var

Quoted 41 lines
package/at/S99at +8 -0
+	# /var/spool/cron/atjobs/.SEQ created could be not available
+	# Check if not exists otherwise create it
+	if [ ! -f /var/spool/cron/atjobs/.SEQ ]; then
+	    mkdir -p /var/spool/cron/atjobs/
+	    touch /var/spool/cron/atjobs/.SEQ
+	    printf "atd: Created missing .SEQ file. Probably it's in tmpfs and on reboot atjobs will be lost!\n"
+	fi
+
 	printf "Starting atd: "
 	start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
 	echo "OK"
package/at/at.hash +2 -2
index 22c732cc7e..e6eb26d818 100644
@@ -1,2 +1,2 @@
-# From: http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
-sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1  at_3.1.16.orig.tar.gz
+# Locally calculated
+sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
package/at/at.mk +5 -4
index 058ebac5c8..083fbbc74b 100644
@@ -4,10 +4,11 @@
 #
 ################################################################################
 
-AT_VERSION = 3.1.16
-AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
-AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
-# missing deps for parsetime.l
+AT_VERSION = release/3.1.23
+AT_SITE = https://salsa.debian.org/debian/at.git
+AT_SITE_METHOD = git
+# Tried to add missing deps for parsetime.l but still parallel build fails
+# in some case, so at the moment let's keep MAKE1
 AT_MAKE = $(MAKE1)
 AT_AUTORECONF = YES
 AT_DEPENDENCIES = $(if $(BR2_PACKAGE_FLEX),flex) host-bison host-flex

package/at/at.mk AT_CONF_OPTS = \ · line 27

Quoted 4 lines
package/at/at.mk +1 -0
@@ -23,6 +24,7 @@ AT_CONF_OPTS = \
 
 define AT_INSTALL_INIT_SYSV
 	$(INSTALL) -m 0755 -D package/at/S99at $(TARGET_DIR)/etc/init.d/S99at
+	

Redundant newline.

package/at/at.mk AT_CONF_OPTS = \ · line 30

Quoted 3 lines
package/at/at.mk +0 -0
 endef
 
 $(eval $(autotools-package))

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#10 lore raw

PATCH v2 1/2 at: change upstream site, bump version

Hi Baruch,

Il 20/09/2018 06:38, Baruch Siach ha scritto:

Quoted 33 lines

Hi Giulio,

Quoted 30 lines · Giulio Benetti

At is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file
- improved S99at script:
if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't work neither for a live session. Create .SEQ file if not found, warning during start that after reboot atjobs could be lost.

---
  package/at/S99at   |  9 +++++++++
  package/at/at.hash |  4 ++--
  package/at/at.mk   | 10 ++++++----
  3 files changed, 17 insertions(+), 6 deletions(-)
package/at/S99at +0 -0
index 666d39b546..fb81736ae2 100755
@@ -6,6 +6,15 @@
  umask 077
 
Quoted 4 lines

package/at/S99at line 9

Quoted 2 lines
package/at/S99at +1 -0
  start() {
+	# Since /va/spool can be linked to /tmp (tmpfs)

va -> var

Oops, yes.

Quoted 43 lines
Quoted 43 lines
package/at/S99at +8 -0
+	# /var/spool/cron/atjobs/.SEQ created could be not available
+	# Check if not exists otherwise create it
+	if [ ! -f /var/spool/cron/atjobs/.SEQ ]; then
+	    mkdir -p /var/spool/cron/atjobs/
+	    touch /var/spool/cron/atjobs/.SEQ
+	    printf "atd: Created missing .SEQ file. Probably it's in tmpfs and on reboot atjobs will be lost!\n"
+	fi
+
  	printf "Starting atd: "
  	start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
  	echo "OK"
package/at/at.hash +2 -2
index 22c732cc7e..e6eb26d818 100644
@@ -1,2 +1,2 @@
-# From: http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
-sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1  at_3.1.16.orig.tar.gz
+# Locally calculated
+sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
package/at/at.mk +5 -4
index 058ebac5c8..083fbbc74b 100644
@@ -4,10 +4,11 @@
  #
  ################################################################################
 
-AT_VERSION = 3.1.16
-AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
-AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
-# missing deps for parsetime.l
+AT_VERSION = release/3.1.23
+AT_SITE = https://salsa.debian.org/debian/at.git
+AT_SITE_METHOD = git
+# Tried to add missing deps for parsetime.l but still parallel build fails
+# in some case, so at the moment let's keep MAKE1
  AT_MAKE = $(MAKE1)
  AT_AUTORECONF = YES
  AT_DEPENDENCIES = $(if $(BR2_PACKAGE_FLEX),flex) host-bison host-flex
@@ -23,6 +24,7 @@ AT_CONF_OPTS = \
 
Quoted 5 lines

package/at/at.mk AT_CONF_OPTS = \ · line 27

Quoted 3 lines
package/at/at.mk +1 -0
  define AT_INSTALL_INIT_SYSV
  	$(INSTALL) -m 0755 -D package/at/S99at $(TARGET_DIR)/etc/init.d/S99at
+	

Redundant newline.

Yep

Thank you!
Best regards

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#11 lore raw

PATCH v2 1/2 at: change upstream site, bump version

In reply to Giulio Benetti

Giulio,

Quoted 8 lines · Giulio Benetti

At is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

Please update the Config.in to list a valid url for this package.

Maybe https://salsa.debian.org/debian/at or https://tracker.debian.org/pkg/at ?

Matt

#12 lore raw

PATCH v2 1/2 at: change upstream site, bump version

Il 20/09/2018 14:43, Matthew Weber ha scritto:

Quoted 14 lines

Giulio,

Quoted 8 lines · Giulio Benetti

At is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

Quoted 3 lines

Please update the Config.in to list a valid url for this package.

Maybe https://salsa.debian.org/debian/at or https://tracker.debian.org/pkg/at ?

I correct it.

Thank you.
Best regards

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#13 lore raw

PATCH v2 2/2 at: add sha256 for legal-info files

In reply to Giulio Benetti

Copyright and COPYING file sha256 are missing.

Add them calculating locally.

---
 package/at/at.hash | 3 +++
 1 file changed, 3 insertions(+)
package/at/at.hash +3 -0
index e6eb26d818..530b1257c1 100644
@@ -1,2 +1,5 @@
 # Locally calculated
 sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
+
+sha256 01dccc0975aa9ba1a9f83e7c5e04f16077353d3c72a0a759b8846ee7a5b2b616  Copyright
+sha256 c38aee9e3c8c4d5d594ff548a1be05453023016d6286931f6512db215ec1fd42  COPYING
Signature · 1 line
2.17.1
#14 lore raw

v2 cover at: bump version

In reply to Giulio Benetti

Hello,

I've just opened a Merge Request upstream:
https://salsa.debian.org/debian/at/merge_requests/3

I invite everybody to place a "like" on Merge Request

Thanks
Kind regards

Signature · 12 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

Il 18/09/2018 23:39, Giulio Benetti ha scritto:
Quoted 21 lines

As suggested at https://elinux.org/Buildroot#Todo_list:
"Update the at package to use the upstream.
http://anonscm.debian.org/gitweb/?p=collab-maint/at.git;a=summary"
In the meanwhile that site became unreachable and the at upstream now is:
https://salsa.debian.org/debian/at

These are the basic tasks done:
- change upstream site, bump version
- add sha256 for legal-info files
- improved S99at init.d script to have live session working (/var/spool linked to /tmp) and warn about it

Giulio Benetti (2):
at: change upstream site, bump version
at: add sha256 for legal-info files

  package/at/S99at   |  9 +++++++++
  package/at/at.hash |  7 +++++--
  package/at/at.mk   | 10 ++++++----
  3 files changed, 20 insertions(+), 6 deletions(-)
#15 lore raw

v3 cover at: bump version

In reply to Giulio Benetti

As suggested at https://elinux.org/Buildroot#Todo_list:
"Update the at package to use the upstream.
http://anonscm.debian.org/gitweb/?p=collab-maint/at.git;a=summary"
In the meanwhile that site became unreachable and the at upstream now is:
https://salsa.debian.org/debian/at

These are the basic tasks done:
- change upstream site, bump version
- add sha256 for legal-info files
- improved S99at init.d script to have live session working (/var/spool linked to /tmp) and warn about it

Giulio Benetti (2):
at: change upstream site, bump version
at: add sha256 for legal-info files

 package/at/Config.in | 2 ++
 package/at/S99at     | 9 +++++++++
 package/at/at.hash   | 7 +++++--
 package/at/at.mk     | 9 +++++----
 4 files changed, 21 insertions(+), 6 deletions(-)
Signature · 1 line
2.17.1
#16 lore raw

PATCH v3 1/2 at: change upstream site, bump version

At is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file
- improved S99at script:
if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't work neither for a live session. Create .SEQ file if not found, warning during start that after reboot atjobs could be lost.

---
Changes V2->V3:
* correct comment in S99at script
* remove redundant newline in at.mk
* add website to Config.in

 package/at/Config.in | 2 ++
 package/at/S99at     | 9 +++++++++
 package/at/at.hash   | 4 ++--
 package/at/at.mk     | 9 +++++----
 4 files changed, 18 insertions(+), 6 deletions(-)
package/at/Config.in +2 -0
index 17fabf7f6b..cbc5be47b8 100644
@@ -8,3 +8,5 @@ config BR2_PACKAGE_AT
 
 	  at    - run the job at a specified time
 	  batch - run the job when system load levels permit
+
+	  https://salsa.debian.org/debian/at
package/at/S99at +9 -0
index 666d39b546..a5015b0735 100755
@@ -6,6 +6,15 @@
 umask 077
 
 start() {
+	# Since /var/spool can be linked to /tmp (tmpfs)
+	# /var/spool/cron/atjobs/.SEQ created could be not available
+	# Check if not exists otherwise create it
+	if [ ! -f /var/spool/cron/atjobs/.SEQ ]; then
+	    mkdir -p /var/spool/cron/atjobs/
+	    touch /var/spool/cron/atjobs/.SEQ
+	    printf "atd: Created missing .SEQ file. Probably it's in tmpfs and on reboot atjobs will be lost!\n"
+	fi
+
 	printf "Starting atd: "
 	start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
 	echo "OK"
package/at/at.hash +2 -2
index 22c732cc7e..e6eb26d818 100644
@@ -1,2 +1,2 @@
-# From: http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
-sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1  at_3.1.16.orig.tar.gz
+# Locally calculated
+sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
package/at/at.mk +5 -4
index 058ebac5c8..36aa8c7a42 100644
@@ -4,10 +4,11 @@
 #
 ################################################################################
 
-AT_VERSION = 3.1.16
-AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
-AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
-# missing deps for parsetime.l
+AT_VERSION = release/3.1.23
+AT_SITE = https://salsa.debian.org/debian/at.git
+AT_SITE_METHOD = git
+# Tried to add missing deps for parsetime.l but still parallel build fails
+# in some case, so at the moment let's keep MAKE1
 AT_MAKE = $(MAKE1)
 AT_AUTORECONF = YES
 AT_DEPENDENCIES = $(if $(BR2_PACKAGE_FLEX),flex) host-bison host-flex
Signature · 1 line
2.17.1
#17 lore raw

PATCH v3 1/2 at: change upstream site, bump version

Giulio,

Quoted 17 lines · Giulio Benetti

At is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file
- improved S99at script:
if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't work neither for a live session. Create .SEQ file if not found, warning during start that after reboot atjobs could be lost.

Quoted 1 line
#18 lore raw

PATCH v3 1/2 at: change upstream site, bump version

Il 20/09/2018 19:40, Matthew Weber ha scritto:

Quoted 21 lines

Giulio,

Quoted 17 lines · Giulio Benetti

At is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file
- improved S99at script:
if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't work neither for a live session. Create .SEQ file if not found, warning during start that after reboot atjobs could be lost.

Quoted 4 lines
Quoted 1 line

Thanks!

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#19 lore raw

PATCH v3 2/2 at: add sha256 for legal-info files

In reply to Giulio Benetti

Copyright and COPYING file sha256 are missing.

Add them calculating locally.

---
 package/at/at.hash | 3 +++
 1 file changed, 3 insertions(+)
package/at/at.hash +3 -0
index e6eb26d818..530b1257c1 100644
@@ -1,2 +1,5 @@
 # Locally calculated
 sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
+
+sha256 01dccc0975aa9ba1a9f83e7c5e04f16077353d3c72a0a759b8846ee7a5b2b616  Copyright
+sha256 c38aee9e3c8c4d5d594ff548a1be05453023016d6286931f6512db215ec1fd42  COPYING
Signature · 1 line
2.17.1
#20 lore raw

v3 cover at: bump version

In reply to Giulio Benetti

Hello,

Quoted 3 lines · Giulio Benetti

Giulio Benetti (2):
at: change upstream site, bump version
at: add sha256 for legal-info files

I have applied both patches, thanks for working on this.

However, as written on the Wiki "And also, submit the remaining of our patches to the new maintainers.". So could you try to get our patches on the "at" package submitted and accepted upstream ?

Thanks a lot,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#21 lore raw

v3 cover at: bump version

Hello Thomas,

Il 23/09/2018 23:33, Thomas Petazzoni ha scritto:

Quoted 9 lines

Hello,

Quoted 3 lines · Giulio Benetti

Giulio Benetti (2):
at: change upstream site, bump version
at: add sha256 for legal-info files

I have applied both patches, thanks for working on this.

Happy about this.

Quoted 4 lines

However, as written on the Wiki "And also, submit the remaining of our patches to the new maintainers.". So could you try to get our patches on the "at" package submitted and accepted upstream ?

I've already opened a Merge Request on:
https://salsa.debian.org/debian/at/merge_requests/3
as I've edited on:
https://www.elinux.org/Buildroot#Packages
Now I'm going to change that part, as only patches need to be upstreamed.

And I've already sent an e-mail asking to place a Like to improve the chances to get those patches upstream:
http://lists.busybox.net/pipermail/buildroot/2018-September/231066.html

Is it ok to invite to place Like on Merge Request? Is there another/better way?

Thanks
Best regards

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#22 lore raw

PATCH 2/2 at: add sha256 for legal-info files

In reply to Giulio Benetti

Copyright and COPYING file sha256 are missing.

Add them calculating locally.

---
 package/at/at.hash | 3 +++
 1 file changed, 3 insertions(+)
package/at/at.hash +3 -0
index e6eb26d818..530b1257c1 100644
@@ -1,2 +1,5 @@
 # Locally calculated
 sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
+
+sha256 01dccc0975aa9ba1a9f83e7c5e04f16077353d3c72a0a759b8846ee7a5b2b616  Copyright
+sha256 c38aee9e3c8c4d5d594ff548a1be05453023016d6286931f6512db215ec1fd42  COPYING
Signature · 1 line
2.17.1