fix missing Tx multi segs capabilities
cover fix missing Tx multi segs capabilities
In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly.
In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it.
Didier Pallard (4):
net/e1000: fix missing Tx multi segs capability
net/fm10k: fix missing Tx multi segs capability
net/i40e: fix missing Tx multi segs capability
net/ixgbe: fix missing Tx multi segs capability
drivers/net/e1000/em_rxtx.c | 1 + drivers/net/fm10k/fm10k_ethdev.c | 1 + drivers/net/i40e/i40e_vf_representor.c | 1 + drivers/net/ixgbe/ixgbe_vf_representor.c | 2 +- 4 files changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.11.0
PATCH 1/4 net/e1000: fix missing Tx multi segs capability
In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly.
In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it.
--- drivers/net/e1000/em_rxtx.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/e1000/em_rxtx.c +1 -0
@@ -1160,6 +1160,7 @@ em_get_tx_port_offloads_capa(struct rte_eth_dev *dev)RTE_SET_USED (dev); tx_offload_capa = +DEV_TX_OFFLOAD_MULTI_SEGS |DEV_TX_OFFLOAD_VLAN_INSERT |DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM |
Signature · 1 line
2.11.0
PATCH 2/4 net/fm10k: fix missing Tx multi segs capability
In reply to Didier PallardIn former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly.
In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it.
Problem was spotted and tested on e1000, should be also present in fm10k.
--- drivers/net/fm10k/fm10k_ethdev.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/fm10k/fm10k_ethdev.c +1 -0
@@ -1975,6 +1975,7 @@ static uint64_t fm10k_get_tx_port_offloads_capa(struct rte_eth_dev *dev)RTE_SET_USED (dev); return (uint64_t)(DEV_TX_OFFLOAD_VLAN_INSERT | + DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | DEV_TX_OFFLOAD_TCP_CKSUM |
Signature · 1 line
2.11.0
PATCH 3/4 net/i40e: fix missing Tx multi segs capability
In reply to Didier PallardIn former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly.
In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it.
Problem was spotted and tested on e1000, should be also present in i40e_vf representor.
--- drivers/net/i40e/i40e_vf_representor.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_vf_representor.c +1 -0
@@ -48,6 +48,7 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,DEV_RX_OFFLOAD_UDP_CKSUM |DEV_RX_OFFLOAD_TCP_CKSUM ; dev_info->tx_offload_capa = +DEV_TX_OFFLOAD_MULTI_SEGS |DEV_TX_OFFLOAD_VLAN_INSERT |DEV_TX_OFFLOAD_QINQ_INSERT | DEV_TX_OFFLOAD_IPV4_CKSUM |
Signature · 1 line
2.11.0
PATCH 4/4 net/ixgbe: fix missing Tx multi segs capability
In reply to Didier PallardIn former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly.
In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it.
Problem was spotted and tested on e1000, should be also present in ixgbe_vf representor.
--- drivers/net/ixgbe/ixgbe_vf_representor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_vf_representor.c +1 -1
@@ -65,7 +65,7 @@ ixgbe_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev, dev_info->tx_offload_capa =DEV_TX_OFFLOAD_VLAN_INSERT |DEV_TX_OFFLOAD_IPV4_CKSUM |DEV_TX_OFFLOAD_UDP_CKSUM |DEV_TX_OFFLOAD_TCP_CKSUM |DEV_TX_OFFLOAD_SCTP_CKSUM | -DEV_TX_OFFLOAD_TCP_TSO ; +DEV_TX_OFFLOAD_TCP_TSO |DEV_TX_OFFLOAD_MULTI_SEGS ;/**< Device TX offload capabilities. */ dev_info->speed_capa =
Signature · 1 line
2.11.0
Quoted 23 lines
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Didier Pallard
Sent: Wednesday, September 19, 2018 4:04 PM
To: [email protected]
Subject: [dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilitiesIn former API,
ETH_TXQ_FLAGS_NOMULTSEGSwas merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly.
In new API,DEV_TX_OFFLOAD_MULTI_SEGSbecame an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it.Didier Pallard (4):
net/e1000: fix missing Tx multi segs capability
net/fm10k: fix missing Tx multi segs capability
net/i40e: fix missing Tx multi segs capability
net/ixgbe: fix missing Tx multi segs capability
Quoted 7 lines
drivers/net/e1000/em_rxtx.c | 1 + drivers/net/fm10k/fm10k_ethdev.c | 1 + drivers/net/i40e/i40e_vf_representor.c | 1 + drivers/net/ixgbe/ixgbe_vf_representor.c | 2 +- 4 files changed, 4 insertions(+), 1 deletion(-)--
Quoted 1 line
2.11.0
Zhang, Qi Z
AppliedQuoted 37 lines
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Ananyev, Konstantin
Sent: Thursday, September 20, 2018 7:30 AM
To: Didier Pallard <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilitiesQuoted 27 lines
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Didier Pallard
Sent: Wednesday, September 19, 2018 4:04 PM
To: [email protected]
Subject: [dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilitiesIn former API,
ETH_TXQ_FLAGS_NOMULTSEGSwas merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly.
In new API,DEV_TX_OFFLOAD_MULTI_SEGSbecame an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it.Didier Pallard (4):
net/e1000: fix missing Tx multi segs capability
net/fm10k: fix missing Tx multi segs capability
net/i40e: fix missing Tx multi segs capability
net/ixgbe: fix missing Tx multi segs capabilitydrivers/net/e1000/em_rxtx.c | 1 + drivers/net/fm10k/fm10k_ethdev.c | 1 + drivers/net/i40e/i40e_vf_representor.c | 1 + drivers/net/ixgbe/ixgbe_vf_representor.c | 2 +- 4 files changed, 4 insertions(+), 1 deletion(-)
Quoted 3 lines
Quoted 1 line
--
Applied to dpdk-next-net-intel.
Thanks
Qi
Quoted 2 lines
Quoted 2 lines
2.11.0