Skip to contentSkip to conversation

ARM: s3c24xx: fix usage of pr_info/pr_cont

PATCH Applied Cedric Roux 2 participants 2 messages Sep 17, 2018 – Sep 19, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: s3c24xx: fix usage of pr_info/pr_cont

This commit fixes the wrong usage of pr_info introduced by the commit e728e4f20100 ("ARM: s3c24xx: formatting cleanup in mach-mini2440.c").

Since the idea is to print on a single line, pr_cont has to be used.

---
 arch/arm/mach-s3c24xx/mach-mini2440.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-s3c24xx/mach-mini2440.c +3 -3
index 9f830abe701c..50d67d760efd 100644
@@ -684,14 +684,14 @@ static void __init mini2440_init(void)
 		pr_info("MINI2440: LCD");
 		for (li = 0; li < ARRAY_SIZE(mini2440_lcd_cfg); li++)
 			if (li == features.lcd_index)
-				pr_info(" [%d:%dx%d]", li,
+				pr_cont(" [%d:%dx%d]", li,
 					mini2440_lcd_cfg[li].width,
 					mini2440_lcd_cfg[li].height);
 			else
-				pr_info(" %d:%dx%d", li,
+				pr_cont(" %d:%dx%d", li,
 					mini2440_lcd_cfg[li].width,
 					mini2440_lcd_cfg[li].height);
-		pr_info("\n");
+		pr_cont("\n");
 		s3c24xx_fb_set_platdata(&mini2440_fb_info);
 	}
 
Signature · 6 lines
2.18.0

Note: running: scripts/checkpatch.pl 000*
reports 3 warnings about the use of pr_cont.
Since this modification was required by Joe Perches, I think this patch
doest the correct thing.
maintainer Applied
#1 lore raw
Quoted 9 lines · Cedric Roux

This commit fixes the wrong usage of pr_info introduced by the commit e728e4f20100 ("ARM: s3c24xx: formatting cleanup in mach-mini2440.c").

Since the idea is to print on a single line, pr_cont has to be used.

---
 arch/arm/mach-s3c24xx/mach-mini2440.c | 6 +++---

Thanks, applied.

Best regards,
Krzysztof