Skip to contentSkip to conversation

platform/x86: intel_int0002_vgpio: Enable the driver on Bay Trail platforms

PATCH In review Hans de Goede 2 participants 2 messages Sep 19, 2018 – Sep 26, 2018 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: intel_int0002_vgpio: Enable the driver on Bay Trail platforms

The intel_int0002_vgpio driver was added to avoid an IRQ 9 storm on Cherry Trail platforms.

When originally merged the CPU ID for Bay Trail SoCs was commented out of the list of valid CPU IDs because we did not have any reports of the IRQ storm on Bay Trail platforms.

We now have a report of the IRQ 9 storm on the Bay Trail based Thinkpad Tablet 10 which is fixed by enabling this driver, so lets enable it on Bay Trail too.

I've tested various other Bay Trail device with this driver enabled without adverse side-effects.

---
 drivers/platform/x86/intel_int0002_vgpio.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/platform/x86/intel_int0002_vgpio.c +1 -5
index a473dc51b18d..987a3b03f225 100644
@@ -57,11 +57,7 @@
 #define ICPU(model)	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
 
 static const struct x86_cpu_id int0002_cpu_ids[] = {
-/*
- * Limit ourselves to Cherry Trail for now, until testing shows we
- * need to handle the INT0002 device on Baytrail too.
- *	ICPU(INTEL_FAM6_ATOM_SILVERMONT1),	 * Valleyview, Bay Trail *
- */
+	ICPU(INTEL_FAM6_ATOM_SILVERMONT1),	/* Valleyview, Bay Trail  */
 	ICPU(INTEL_FAM6_ATOM_AIRMONT),		/* Braswell, Cherry Trail */
 	{}
 };
Signature · 1 line
2.19.0.rc1
#1 lore raw
Quoted 8 lines · Hans de Goede

The intel_int0002_vgpio driver was added to avoid an IRQ 9 storm on Cherry Trail platforms.

When originally merged the CPU ID for Bay Trail SoCs was commented out of the list of valid CPU IDs because we did not have any reports of the IRQ storm on Bay Trail platforms.

Quoted 7 lines

We now have a report of the IRQ 9 storm on the Bay Trail based Thinkpad Tablet 10 which is fixed by enabling this driver, so lets enable it on Bay Trail too.

I've tested various other Bay Trail device with this driver enabled without adverse side-effects.

Pushed to my review and testing queue, thanks!

Quoted 27 lines
---
 drivers/platform/x86/intel_int0002_vgpio.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/platform/x86/intel_int0002_vgpio.c +1 -6
index a473dc51b18d..987a3b03f225 100644
@@ -57,11 +57,7 @@
 #define ICPU(model)    { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
 
 static const struct x86_cpu_id int0002_cpu_ids[] = {
-/*
- * Limit ourselves to Cherry Trail for now, until testing shows we
- * need to handle the INT0002 device on Baytrail too.
- *     ICPU(INTEL_FAM6_ATOM_SILVERMONT1),       * Valleyview, Bay Trail *
- */
+       ICPU(INTEL_FAM6_ATOM_SILVERMONT1),      /* Valleyview, Bay Trail  */
        ICPU(INTEL_FAM6_ATOM_AIRMONT),          /* Braswell, Cherry Trail */
        {}
 };
--

2.19.0.rc1

Signature · 2 lines
With Best Regards,
Andy Shevchenko