cpufreq: qcom-kryo: Fix section mismatch warning
Subsystems (2)
PATCH v2 1/1 cpufreq: qcom-kryo: Fix section mismatch warning
WARNING: vmlinux.o(.text+0x8aa424): Section mismatch in reference from the function qcom_cpufreq_kryo_probe() to the function .init.text:qcom_cpufreq_kryo_get_msm_id()
The function qcom_cpufreq_kryo_probe() references
the function __init qcom_cpufreq_kryo_get_msm_id().
This is often because qcom_cpufreq_kryo_probe lacks a __init annotation or the annotation of qcom_cpufreq_kryo_get_msm_id is wrong.
Add the '__init' annotation to qcom_cpufreq_kryo_probe so that there is no more mismatch warning.
---
v1 -> v2:
Add '__init' to qcom_cpufreq_kryo_probe instead of removing it from qcom_cpufreq_kryo_get_msm_id.
drivers/cpufreq/qcom-cpufreq-kryo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/qcom-cpufreq-kryo.c +1 -1
@@ -73,7 +73,7 @@ static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)return version; } -static int qcom_cpufreq_kryo_probe (struct platform_device *pdev) +static int __init qcom_cpufreq_kryo_probe (struct platform_device *pdev) {struct opp_table *opp_tables[NR_CPUS ] = {0 };enum _msm8996_version msm8996_version;
Signature · 1 line
2.19.0
Quoted 29 lines · Nathan Chancellor
WARNING:
vmlinux.o(.text+0x8aa424): Section mismatch in reference from the functionqcom_cpufreq_kryo_probe()to the function .init.text:qcom_cpufreq_kryo_get_msm_id()
The functionqcom_cpufreq_kryo_probe()references
the function__initqcom_cpufreq_kryo_get_msm_id().
This is often becauseqcom_cpufreq_kryo_probelacks a__initannotation or the annotation ofqcom_cpufreq_kryo_get_msm_idis wrong.Add the '
__init' annotation toqcom_cpufreq_kryo_probeso that there is no more mismatch warning.Fixes 46e2856b8e18 ("cpufreq: Add Kryo CPU scaling driver")Reported-by Nick Desaulniers <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>---
v1 -> v2:
Add '
__init' toqcom_cpufreq_kryo_probeinstead of removing it fromqcom_cpufreq_kryo_get_msm_id.drivers/cpufreq/qcom-cpufreq-kryo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/cpufreq/qcom-cpufreq-kryo.c +0
-0
drivers/cpufreq/qcom-cpufreq-kryo.c static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void) · line 79
Quoted 8 lines
drivers/cpufreq/qcom-cpufreq-kryo.c +1
-1@@ -73,7 +73,7 @@ static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)return version; } -static int qcom_cpufreq_kryo_probe (struct platform_device *pdev) +static int __init qcom_cpufreq_kryo_probe (struct platform_device *pdev) {struct opp_table *opp_tables[NR_CPUS ] = {0 };enum _msm8996_version msm8996_version;
Signature · 1 line
viresh
Quoted 11 lines · Nathan Chancellor
WARNING:
vmlinux.o(.text+0x8aa424): Section mismatch in reference from the functionqcom_cpufreq_kryo_probe()to the function .init.text:qcom_cpufreq_kryo_get_msm_id()
The functionqcom_cpufreq_kryo_probe()references
the function__initqcom_cpufreq_kryo_get_msm_id().
This is often becauseqcom_cpufreq_kryo_probelacks a__initannotation or the annotation ofqcom_cpufreq_kryo_get_msm_idis wrong.Add the '
__init' annotation toqcom_cpufreq_kryo_probeso that there is no more mismatch warning.
I wonder why this driver has an exit function marked __init rather than __exit? Does that mean it gets cleaned up after kernel init, and so on unloading of the driver, the kernel jumps to unmapped memory?
Does this patch now produce a warning for qcom_cpufreq_kryo_driver referencing qcom_cpufreq_kryo_probe?
Quoted 28 lines
Fixes 46e2856b8e18 ("cpufreq: Add Kryo CPU scaling driver")Reported-by Nick Desaulniers <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>---
v1 -> v2:
Add '
__init' toqcom_cpufreq_kryo_probeinstead of removing it fromqcom_cpufreq_kryo_get_msm_id.drivers/cpufreq/qcom-cpufreq-kryo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/cpufreq/qcom-cpufreq-kryo.c +1
-2@@ -73,7 +73,7 @@ static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)return version; } -static int qcom_cpufreq_kryo_probe (struct platform_device *pdev) +static int __init qcom_cpufreq_kryo_probe (struct platform_device *pdev) {struct opp_table *opp_tables[NR_CPUS ] = {0 };enum _msm8996_version msm8996_version; --
Quoted 2 lines
2.19.0
--
Thanks,
~Nick Desaulniers
Viresh Kumar
maintainerQuoted 11 lines · Nick Desaulniers
Quoted 9 lines · Nathan Chancellor
WARNING:
vmlinux.o(.text+0x8aa424): Section mismatch in reference from the functionqcom_cpufreq_kryo_probe()to the function .init.text:qcom_cpufreq_kryo_get_msm_id()
The functionqcom_cpufreq_kryo_probe()references
the function__initqcom_cpufreq_kryo_get_msm_id().
This is often becauseqcom_cpufreq_kryo_probelacks a__initannotation or the annotation ofqcom_cpufreq_kryo_get_msm_idis wrong.
Quoted 5 lines
Quoted 2 lines
Add the '
__init' annotation toqcom_cpufreq_kryo_probeso that there is no more mismatch warning.I wonder why this driver has an exit function marked
__initrather than__exit?
I think it was just a mistake.
Quoted 2 lines
Does that mean it gets cleaned up after kernel init, and so on unloading of the driver, the kernel jumps to unmapped memory?
The __init/exit sections are only useful when the driver is builtin and so there is no unloading. Yeah, if you would have tried to call shutdown for the kernel, it may have crashed or something. I don't know.
Quoted 2 lines
Does this patch now produce a warning for
qcom_cpufreq_kryo_driverreferencingqcom_cpufreq_kryo_probe?
Why should it ? It doesn't though.
Signature · 1 line
viresh
Viresh Kumar
maintainerQuoted 28 lines · Viresh Kumar
Quoted 11 lines · Nick Desaulniers
Quoted 9 lines · Nathan Chancellor
WARNING:
vmlinux.o(.text+0x8aa424): Section mismatch in reference from the functionqcom_cpufreq_kryo_probe()to the function .init.text:qcom_cpufreq_kryo_get_msm_id()
The functionqcom_cpufreq_kryo_probe()references
the function__initqcom_cpufreq_kryo_get_msm_id().
This is often becauseqcom_cpufreq_kryo_probelacks a__initannotation or the annotation ofqcom_cpufreq_kryo_get_msm_idis wrong.Quoted 5 lines
Quoted 2 lines
Add the '
__init' annotation toqcom_cpufreq_kryo_probeso that there is no more mismatch warning.I wonder why this driver has an exit function marked
__initrather than__exit?I think it was just a mistake.
Quoted 2 lines
Does that mean it gets cleaned up after kernel init, and so on unloading of the driver, the kernel jumps to unmapped memory?
The __init/exit sections are only useful when the driver is builtin and so there is no unloading. Yeah, if you would have tried to call shutdown for the kernel, it may have crashed or something. I don't know.
Quoted 4 lines
Quoted 2 lines
Does this patch now produce a warning for
qcom_cpufreq_kryo_driverreferencingqcom_cpufreq_kryo_probe?Why should it ? It doesn't though.
I thought you replied to my commit where I marked the exit routine with __exit and realised just now that it wasn't the case. I haven't build-tested this thing, but the question still stands. Why should it ?
Signature · 1 line
viresh
Rafael J. Wysocki
maintainerQuoted 33 lines · Viresh Kumar
Quoted 31 lines · Viresh Kumar
Quoted 11 lines · Nick Desaulniers
Quoted 9 lines · Nathan Chancellor
WARNING:
vmlinux.o(.text+0x8aa424): Section mismatch in reference from the functionqcom_cpufreq_kryo_probe()to the function .init.text:qcom_cpufreq_kryo_get_msm_id()
The functionqcom_cpufreq_kryo_probe()references
the function__initqcom_cpufreq_kryo_get_msm_id().
This is often becauseqcom_cpufreq_kryo_probelacks a__initannotation or the annotation ofqcom_cpufreq_kryo_get_msm_idis wrong.Quoted 5 lines
Quoted 2 lines
Add the '
__init' annotation toqcom_cpufreq_kryo_probeso that there is no more mismatch warning.I wonder why this driver has an exit function marked
__initrather than__exit?I think it was just a mistake.
Quoted 2 lines
Does that mean it gets cleaned up after kernel init, and so on unloading of the driver, the kernel jumps to unmapped memory?
The __init/exit sections are only useful when the driver is builtin and so there is no unloading. Yeah, if you would have tried to call shutdown for the kernel, it may have crashed or something. I don't know.
Quoted 2 lines
Does this patch now produce a warning for
qcom_cpufreq_kryo_driverreferencingqcom_cpufreq_kryo_probe?
Quoted 6 lines
Quoted 1 line
Why should it ? It doesn't though.
I thought you replied to my commit where I marked the exit routine with
__exitand realised just now that it wasn't the case. I haven't build-tested this thing, but the question still stands. Why should it ?
Because __init things go away at one point and calling them from the other sections is a bad idea. OTOH, __exit things are simply not needed in built-in drivers and they are never there if the driver is built-in, so calling them from the other sections is a bad idea too.
Can you guys, please, prepare *one* patch fixing all of the __init/__exit annotations in this driver and post it?
Thanks,
Rafael
Quoted 46 lines · Rafael J. Wysocki
Quoted 33 lines · Viresh Kumar
Quoted 31 lines · Viresh Kumar
Quoted 11 lines · Nick Desaulniers
Quoted 9 lines · Nathan Chancellor
WARNING:
vmlinux.o(.text+0x8aa424): Section mismatch in reference from the functionqcom_cpufreq_kryo_probe()to the function .init.text:qcom_cpufreq_kryo_get_msm_id()
The functionqcom_cpufreq_kryo_probe()references
the function__initqcom_cpufreq_kryo_get_msm_id().
This is often becauseqcom_cpufreq_kryo_probelacks a__initannotation or the annotation ofqcom_cpufreq_kryo_get_msm_idis wrong.Quoted 5 lines
Quoted 2 lines
Add the '
__init' annotation toqcom_cpufreq_kryo_probeso that there is no more mismatch warning.I wonder why this driver has an exit function marked
__initrather than__exit?I think it was just a mistake.
Quoted 2 lines
Does that mean it gets cleaned up after kernel init, and so on unloading of the driver, the kernel jumps to unmapped memory?
The __init/exit sections are only useful when the driver is builtin and so there is no unloading. Yeah, if you would have tried to call shutdown for the kernel, it may have crashed or something. I don't know.
Quoted 2 lines
Does this patch now produce a warning for
qcom_cpufreq_kryo_driverreferencingqcom_cpufreq_kryo_probe?Quoted 6 lines
Quoted 1 line
Why should it ? It doesn't though.
I thought you replied to my commit where I marked the exit routine with
__exitand realised just now that it wasn't the case. I haven't build-tested this thing, but the question still stands. Why should it ?Because
__initthings go away at one point and calling them from the other sections is a bad idea. OTOH,__exitthings are simply not needed in built-in drivers and they are never there if the driver is built-in, so calling them from the other sections is a bad idea too.
Quoted 5 lines
Can you guys, please, prepare *one* patch fixing all of the __init/__exit annotations in this driver and post it?
Thanks,
Rafael
Hi Rafael,
Yes, I will work on this and send out a v3 for review.
Thanks,
Nathan
Viresh Kumar
maintainerQuoted 4 lines · Rafael J. Wysocki
Because
__initthings go away at one point and calling them from the other sections is a bad idea. OTOH,__exitthings are simply not needed in built-in drivers and they are never there if the driver is built-in, so calling them from the other sections is a bad idea too.
I assumed that the driver is calling platform_driver_probe() and so probe() can be marked __init. But it doesn't do that to make deferred probing work.
Signature · 1 line
viresh
Quoted 14 lines · Nick Desaulniers
Quoted 11 lines · Nathan Chancellor
WARNING:
vmlinux.o(.text+0x8aa424): Section mismatch in reference from the functionqcom_cpufreq_kryo_probe()to the function .init.text:qcom_cpufreq_kryo_get_msm_id()
The functionqcom_cpufreq_kryo_probe()references
the function__initqcom_cpufreq_kryo_get_msm_id().
This is often becauseqcom_cpufreq_kryo_probelacks a__initannotation or the annotation ofqcom_cpufreq_kryo_get_msm_idis wrong.Add the '
__init' annotation toqcom_cpufreq_kryo_probeso that there is no more mismatch warning.
Quoted 7 lines
I wonder why this driver has an exit function marked
__initrather than__exit? Does that mean it gets cleaned up after kernel init, and so on unloading of the driver, the kernel jumps to unmapped memory?Does this patch now produce a warning for
qcom_cpufreq_kryo_driverreferencingqcom_cpufreq_kryo_probe?
Hmmm I could have sworn I built this before sending it, although my config might have been messed up but yes, I do see that warning.
WARNING: vmlinux.o(.data+0x117618): Section mismatch in reference from the variable qcom_cpufreq_kryo_driver to the function .init.text:qcom_cpufreq_kryo_probe()
The variable qcom_cpufreq_kryo_driver references
the function __init qcom_cpufreq_kryo_probe()
I suppose v1 might be the better option then as with the other patch, marking qcom_cpufreq_kryo_driver doesn't seem correct.
I'm open to suggestions though.
Nathan
Quoted 35 lines
Quoted 28 lines
Fixes 46e2856b8e18 ("cpufreq: Add Kryo CPU scaling driver")Reported-by Nick Desaulniers <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>---
v1 -> v2:
Add '
__init' toqcom_cpufreq_kryo_probeinstead of removing it fromqcom_cpufreq_kryo_get_msm_id.drivers/cpufreq/qcom-cpufreq-kryo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/cpufreq/qcom-cpufreq-kryo.c +1
-2@@ -73,7 +73,7 @@ static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)return version; } -static int qcom_cpufreq_kryo_probe (struct platform_device *pdev) +static int __init qcom_cpufreq_kryo_probe (struct platform_device *pdev) {struct opp_table *opp_tables[NR_CPUS ] = {0 };enum _msm8996_version msm8996_version; --Quoted 2 lines
2.19.0
--
Thanks,
~Nick Desaulniers