misc: mic: scif: Remove unused variable
PATCH 1/1 misc: mic: scif: Remove unused variable
Clang warns when a variable is assigned to itself.
drivers/misc/mic/scif/scif_dma.c:1577:12: warning: explicitly assigning value of variable of type 'bool' (aka '_Bool') to itself [-Wself-assign]
dst_local = dst_local;
~~~~~~~~~ ^ ~~~~~~~~~1 warning generated.
This is usually done to avoid an unused variable warning, which is the case here. dst_local is used nowhere in this function, which has been the case since the initial code drop in commit 7cc31cd27752 ("misc: mic:
SCIF DMA and CPU copy interface") in 2015. Just remove the variable, it can be added back if it was intended to be used.
Signed-off-by Nathan Chancellor <[email protected]>
--- drivers/misc/mic/scif/scif_dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/misc/mic/scif/scif_dma.c +1 -3
@@ -1553,7 +1553,7 @@ static int scif_rma_list_dma_copy_wrapper(struct scif_endpt *epd,int src_cache_off, dst_cache_off;s64 src_offset = work->src_offset, dst_offset = work->dst_offset;u8 *temp =NULL ; -bool src_local = true, dst_local = false; +bool src_local = true;struct scif_dma_comp_cb *comp_cb;dma_addr_t src_dma_addr, dst_dma_addr;int err;
@@ -1572,9 +1572,7 @@ static int scif_rma_list_dma_copy_wrapper(struct scif_endpt *epd, src_dma_addr =__scif_off_to_dma_addr (work->src_window, src_offset); dst_dma_addr =__scif_off_to_dma_addr (work->dst_window, dst_offset); src_local = work->src_window->type ==SCIF_WINDOW_SELF ; - dst_local = work->dst_window->type ==SCIF_WINDOW_SELF ; - dst_local = dst_local;/* Allocate dma_completion cb */ comp_cb =kzalloc (sizeof (*comp_cb),GFP_KERNEL );if (!comp_cb)
Signature · 1 line
2.19.0