Skip to contentSkip to conversation

Input: pm8941-pwrkey - Add pms405 pwrkey support

PATCH In review Bjorn Andersson 3 participants 4 messages Sep 20, 2018 – Oct 19, 2018

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: pm8941-pwrkey - Add pms405 pwrkey support

From: Vinod Koul <[email protected]>

Update the binding and driver for pms405 pwrkey.

---
 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt | 1 +
 drivers/input/misc/pm8941-pwrkey.c                             | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt +1 -0
index 34ab5763f494..736fba3bad54 100644
@@ -8,6 +8,7 @@ PROPERTIES
 	Definition: must be one of:
 		    "qcom,pm8941-pwrkey"
 		    "qcom,pm8941-resin"
+		    "qcom,pms405-pwrkey"
 
 - reg:
 	Usage: required
drivers/input/misc/pm8941-pwrkey.c +1 -0
index 48153e0ca19a..fccf63263c1c 100644
@@ -317,6 +317,7 @@ static const struct pm8941_data resin_data = {
 static const struct of_device_id pm8941_pwr_key_id_table[] = {
 	{ .compatible = "qcom,pm8941-pwrkey", .data = &pwrkey_data },
 	{ .compatible = "qcom,pm8941-resin", .data = &resin_data },
+	{ .compatible = "qcom,pms405-pwrkey", .data = &pwrkey_data },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, pm8941_pwr_key_id_table);
Signature · 1 line
2.18.0
#1 lore raw
Quoted 3 lines · Bjorn Andersson

From: Vinod Koul <[email protected]>

Update the binding and driver for pms405 pwrkey.

Rob, Dmitry

Gentle reminder for this patch...

Quoted 33 lines
---
 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt | 1 +
 drivers/input/misc/pm8941-pwrkey.c                             | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt +1 -0
index 34ab5763f494..736fba3bad54 100644
@@ -8,6 +8,7 @@ PROPERTIES
 	Definition: must be one of:
 		    "qcom,pm8941-pwrkey"
 		    "qcom,pm8941-resin"
+		    "qcom,pms405-pwrkey"
 
 - reg:
 	Usage: required
drivers/input/misc/pm8941-pwrkey.c +1 -0
index 48153e0ca19a..fccf63263c1c 100644
@@ -317,6 +317,7 @@ static const struct pm8941_data resin_data = {
 static const struct of_device_id pm8941_pwr_key_id_table[] = {
 	{ .compatible = "qcom,pm8941-pwrkey", .data = &pwrkey_data },
 	{ .compatible = "qcom,pm8941-resin", .data = &resin_data },
+	{ .compatible = "qcom,pms405-pwrkey", .data = &pwrkey_data },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, pm8941_pwr_key_id_table);
Signature · 1 line
2.18.0
Signature · 1 line
~Vinod
maintainer
#2 lore raw
Quoted 26 lines · Vinod
Quoted 3 lines · Bjorn Andersson

From: Vinod Koul <[email protected]>

Update the binding and driver for pms405 pwrkey.

Rob, Dmitry

Gentle reminder for this patch...

Quoted 17 lines
---
 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt | 1 +
 drivers/input/misc/pm8941-pwrkey.c                             | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt +1 -0
index 34ab5763f494..736fba3bad54 100644
@@ -8,6 +8,7 @@ PROPERTIES
 	Definition: must be one of:
 		    "qcom,pm8941-pwrkey"
 		    "qcom,pm8941-resin"
+		    "qcom,pms405-pwrkey"
 
Quoted 11 lines

drivers/input/misc/pm8941-pwrkey.c static const struct pm8941_data resin_data = { · line 320

Quoted 11 lines
Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt +0 -0
 - reg:
 	Usage: required
drivers/input/misc/pm8941-pwrkey.c +1 -0
index 48153e0ca19a..fccf63263c1c 100644
@@ -317,6 +317,7 @@ static const struct pm8941_data resin_data = {
 static const struct of_device_id pm8941_pwr_key_id_table[] = {
 	{ .compatible = "qcom,pm8941-pwrkey", .data = &pwrkey_data },
 	{ .compatible = "qcom,pm8941-resin", .data = &resin_data },
+	{ .compatible = "qcom,pms405-pwrkey", .data = &pwrkey_data },

I am sure I asked this question before (in context of a different driver), but why do we need this compatible if we already have pm8941-pwrkey compatible? Isn't pms405-pwrkey compatible with pm8941-pwrkey as far as power key block goes? In which cases do we need new compatibles and when can we reuse existing ones? Rob?

Thanks.

Signature · 1 line
Dmitry
#3 lore raw
Quoted 36 lines · Dmitry Torokhov
Quoted 35 lines · Vinod
Quoted 3 lines · Bjorn Andersson

From: Vinod Koul <[email protected]>

Update the binding and driver for pms405 pwrkey.

Rob, Dmitry

Gentle reminder for this patch...

Quoted 26 lines
---
 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt | 1 +
 drivers/input/misc/pm8941-pwrkey.c                             | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt +1 -0
index 34ab5763f494..736fba3bad54 100644
@@ -8,6 +8,7 @@ PROPERTIES
 	Definition: must be one of:
 		    "qcom,pm8941-pwrkey"
 		    "qcom,pm8941-resin"
+		    "qcom,pms405-pwrkey"
 
 - reg:
 	Usage: required
drivers/input/misc/pm8941-pwrkey.c +0 -0
index 48153e0ca19a..fccf63263c1c 100644
@@ -317,6 +317,7 @@ static const struct pm8941_data resin_data = {
 static const struct of_device_id pm8941_pwr_key_id_table[] = {
 	{ .compatible = "qcom,pm8941-pwrkey", .data = &pwrkey_data },
Quoted 8 lines
Quoted 2 lines

drivers/input/misc/pm8941-pwrkey.c static const struct pm8941_data resin_data = { · line 320

Quoted 2 lines
drivers/input/misc/pm8941-pwrkey.c +1 -0
 	{ .compatible = "qcom,pm8941-resin", .data = &resin_data },
+	{ .compatible = "qcom,pms405-pwrkey", .data = &pwrkey_data },

I am sure I asked this question before (in context of a different driver), but why do we need this compatible if we already have pm8941-pwrkey compatible? Isn't pms405-pwrkey compatible with pm8941-pwrkey as far as power key block goes? In which cases do we need new compatibles and when can we reuse existing ones? Rob?

Relooking I do think that reuse of pm8941-pwrkey is entirely feasible, thanks for the suggestion. We can drop this and I will update DTS

Signature · 1 line
~Vinod