IB/mlx4: Remove unnecessary parentheses
Subsystems (2)
PATCH 1/1 IB/mlx4: Remove unnecessary parentheses
Clang warns when more than one set of parentheses are used in single conditional statements.
drivers/infiniband/hw/mlx4/mcg.c:676:16: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
if ((method == IB_MGMT_METHOD_GET_RESP)) {
~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~drivers/infiniband/hw/mlx4/mcg.c:676:16: note: remove extraneous parentheses around the comparison to silence this warning
if ((method == IB_MGMT_METHOD_GET_RESP)) {
~ ^ ~drivers/infiniband/hw/mlx4/mcg.c:676:16: note: use '=' to turn this equality comparison into an assignment
if ((method == IB_MGMT_METHOD_GET_RESP)) {
^~
=Remove the unnecessary parentheses to silence this warning.
--- drivers/infiniband/hw/mlx4/mcg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/mlx4/mcg.c +1 -1
@@ -673,7 +673,7 @@ static void mlx4_ib_mcg_work_handler(struct work_struct *work)if (!list_empty (&group->pending_list)) req =list_first_entry (&group->pending_list, struct mcast_req, group_list); -if ((method ==IB_MGMT_METHOD_GET_RESP )) { +if (method ==IB_MGMT_METHOD_GET_RESP ) {if (req) {send_reply_to_slave (req->func, group, &req->sa_mad, status); --group->func[req->func].num_pend_reqs;
Signature · 1 line
2.19.0
Quoted 17 lines · Nathan Chancellor
Clang warns when more than one set of parentheses are used in single conditional statements.
drivers/infiniband/hw/mlx4/mcg.c:676:16: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]if ((method == IB_MGMT_METHOD_GET_RESP)) { ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/hw/mlx4/mcg.c:676:16: note: remove extraneous parentheses around the comparison to silence this warning
if ((method ==IB_MGMT_METHOD_GET_RESP)) {
~ ^ ~drivers/infiniband/hw/mlx4/mcg.c:676:16: note: use '=' to turn this equality comparison into an assignmentif ((method == IB_MGMT_METHOD_GET_RESP)) { ^~ =
Quoted 8 lines
Remove the unnecessary parentheses to silence this warning.
Reported-by Nick Desaulniers <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>--- drivers/infiniband/hw/mlx4/mcg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
Doug Ledford
AppliedQuoted 13 lines · Nathan Chancellor
Clang warns when more than one set of parentheses are used in single conditional statements.
drivers/infiniband/hw/mlx4/mcg.c:676:16: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]if ((method == IB_MGMT_METHOD_GET_RESP)) { ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/hw/mlx4/mcg.c:676:16: note: remove extraneous parentheses around the comparison to silence this warning
if ((method ==IB_MGMT_METHOD_GET_RESP)) {
~ ^ ~drivers/infiniband/hw/mlx4/mcg.c:676:16: note: use '=' to turn this equality comparison into an assignment
Quoted 8 lines
if ((method == IB_MGMT_METHOD_GET_RESP)) { ^~ =Remove the unnecessary parentheses to silence this warning.
Reported-by Nick Desaulniers <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>
Applied to for-next, thanks.
Signature · 3 lines
Doug Ledford <[email protected]> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD