video: fbdev: sis: Remove unnecessary parentheses and commented code
Subsystems (2)
PATCH 1/1 video: fbdev: sis: Remove unnecessary parentheses and commented code
Clang warns when multiple pairs of parentheses are used for a single conditional statement.
drivers/video/fbdev/sis/init301.c:851:42: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
} else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* ||
~~~~~~~~~~~~~~~~~~~~~~~~^~~~drivers/video/fbdev/sis/init301.c:851:42: note: remove extraneous parentheses around the comparison to silence this warning
} else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* ||
~ ^ ~drivers/video/fbdev/sis/init301.c:851:42: note: use '=' to turn this equality comparison into an assignment
} else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* ||
^~
=1 warning generated.
Remove the parentheses and while we're at it, clean up the commented code, which has been here since the beginning of git history.
--- drivers/video/fbdev/sis/init301.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/video/fbdev/sis/init301.c +1 -3
@@ -848,9 +848,7 @@ SiS_PanelDelay(struct SiS_Private *SiS_Pr, unsigned short DelayTime)SiS_DDC2Delay (SiS_Pr,0x4000 ); } - }else if ((SiS_Pr->SiS_IF_DEF_LVDS ==1 )/* || -(SiS_Pr->SiS_CustomT == CUT_COMPAQ1280) || -(SiS_Pr->SiS_CustomT == CUT_CLEVO1400) */ ) {/* 315 series, LVDS; Special */ + }else if (SiS_Pr->SiS_IF_DEF_LVDS ==1 ) {/* 315 series, LVDS; Special */ if (SiS_Pr->SiS_IF_DEF_CH70xx ==0 ) { PanelID =SiS_GetReg (SiS_Pr->SiS_P3d4,0x36 );
Signature · 1 line
2.19.0
Quoted 16 lines · Nathan Chancellor
Clang warns when multiple pairs of parentheses are used for a single conditional statement.
drivers/video/fbdev/sis/init301.c:851:42: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]} else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* || ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
drivers/video/fbdev/sis/init301.c:851:42: note: remove extraneous parentheses around the comparison to silence this warning
} else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* ||
~ ^ ~drivers/video/fbdev/sis/init301.c:851:42: note: use '=' to turn this equality comparison into an assignment} else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* || ^~ =
Quoted 7 lines
1 warning generated.
Remove the parentheses and while we're at it, clean up the commented code, which has been here since the beginning of git history.
Patch queued for 4.20, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics