net: neterion: vxge: Remove unnecessary parentheses
Subsystems (2)
PATCH 1/1 net: neterion: vxge: Remove unnecessary parentheses
Clang warns when multiple pairs of parentheses are used for a single conditional statement.
drivers/net/ethernet/neterion/vxge/vxge-traffic.c:2265:31: warning:
equality comparison with extraneous parentheses [-Wparentheses-equality]
if ((hldev->config.intr_mode ==
VXGE_HW_INTR_MODE_MSIX_ONE_SHOT))
~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/neterion/vxge/vxge-traffic.c:2265:31: note: remove
extraneous parentheses around the comparison to silence this warning
if ((hldev->config.intr_mode ==VXGE_HW_INTR_MODE_MSIX_ONE_SHOT))
~ ^ ~drivers/net/ethernet/neterion/vxge/vxge-traffic.c:2265:31: note: use '=' to turn this equality comparison into an assignment
if ((hldev->config.intr_mode ==
VXGE_HW_INTR_MODE_MSIX_ONE_SHOT))
^~
=1 warning generated.
Signed-off-by Nathan Chancellor <[email protected]>
--- drivers/net/ethernet/neterion/vxge/vxge-traffic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/neterion/vxge/vxge-traffic.c +1 -1
@@ -2262,7 +2262,7 @@ void vxge_hw_vpath_msix_clear(struct __vxge_hw_vpath_handle *vp, int msix_id) {struct __vxge_hw_device *hldev = vp->vpath->hldev; -if ((hldev->config.intr_mode ==VXGE_HW_INTR_MODE_MSIX_ONE_SHOT )) +if (hldev->config.intr_mode ==VXGE_HW_INTR_MODE_MSIX_ONE_SHOT )__vxge_hw_pio_mem_write32_upper ( (u32 )vxge_bVALn (vxge_mBIT ((msix_id >>2 )),0 ,32 ), &hldev->common_reg->clr_msix_one_shot_vec[msix_id %4 ]);
Signature · 1 line
2.19.0