wireless: ipw2x00: Remove unnecessary parentheses
Subsystems (3)
PATCH 1/1 wireless: ipw2x00: Remove unnecessary parentheses
Clang warns when multiple pairs of parentheses are used for a single conditional statement.
drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) {
~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: remove extraneous parentheses around the comparison to silence this warning
if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) {
~ ^ ~drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: use '=' to turn this equality comparison into an assignment
if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) {
^~
=1 warning generated.
--- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/ipw2x00/ipw2200.c +1 -1
@@ -5652,7 +5652,7 @@ static void ipw_merge_adhoc_network(struct work_struct *work) }mutex_lock (&priv->mutex); -if ((priv->ieee->iw_mode ==IW_MODE_ADHOC )) { +if (priv->ieee->iw_mode ==IW_MODE_ADHOC ) {IPW_DEBUG_MERGE ("remove network %*pE\n" , priv->essid_len, priv->essid);ipw_remove_current_network (priv);
Signature · 1 line
2.19.0
Stanislav Yakovlev
maintainerQuoted 16 lines · Nathan Chancellor
Clang warns when multiple pairs of parentheses are used for a single conditional statement.
drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: remove extraneous parentheses around the comparison to silence this warning
if ((priv->ieee->iw_mode==IW_MODE_ADHOC)) {
~ ^ ~drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: use '=' to turn this equality comparison into an assignmentif ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { ^~ =
Quoted 8 lines
1 warning generated.
Signed-off-by Nathan Chancellor <[email protected]>--- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Looks fine, thanks!
Stanislav.
Re: [PATCH] ipw2x00: Remove unnecessary parentheses
In reply to Nathan ChancellorQuoted 13 lines · Nathan Chancellor
Clang warns when multiple pairs of parentheses are used for a single conditional statement.
drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: remove extraneous parentheses around the comparison to silence this warning
if ((priv->ieee->iw_mode==IW_MODE_ADHOC)) {
~ ^ ~drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: use '=' to turn this equality comparison into an assignment
Quoted 7 lines
if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { ^~ =1 warning generated.
Patch applied to wireless-drivers-next.git, thanks.
c15ace868dd1 ipw2x00: Remove unnecessary parentheses
Signature · 3 lines
https://patchwork.kernel.org/patch/10608735/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches