Skip to contentSkip to conversation

net: lan78xx: Avoid unnecessary self assignment

PATCH New Nathan Chancellor 1 participant 1 message Sep 20, 2018

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: lan78xx: Avoid unnecessary self assignment

Clang warns when a variable is assigned to itself.

drivers/net/usb/lan78xx.c:940:11: warning: explicitly assigning value of variable of type 'u32' (aka 'unsigned int') to itself [-Wself-assign]

                        offset = offset;
                        ~~~~~~ ^ ~~~~~~

1 warning generated.

Reorder the if statement to acheive the same result and avoid a self assignment warning.

---
 drivers/net/usb/lan78xx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/usb/lan78xx.c +2 -4
index 04f0a094d864..656441d9a955 100644
@@ -936,11 +936,9 @@ static int lan78xx_read_otp(struct lan78xx_net *dev, u32 offset,
 	ret = lan78xx_read_raw_otp(dev, 0, 1, &sig);
 
 	if (ret == 0) {
-		if (sig == OTP_INDICATOR_1)
-			offset = offset;
-		else if (sig == OTP_INDICATOR_2)
+		if (sig == OTP_INDICATOR_2)
 			offset += 0x100;
-		else
+		else if (sig != OTP_INDICATOR_1)
 			ret = -EINVAL;
 		if (!ret)
 			ret = lan78xx_read_raw_otp(dev, offset, length, data);