Skip to contentSkip to conversation

font-awesome compatible with fontconfig

PATCH New Benjamin Calderon 2 participants 6 messages Sep 21, 2018 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 font-awesome compatible with fontconfig

This commit installs font-awesome in the standard fonts directory making it available systemwide.

---
 package/font-awesome/font-awesome.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
package/font-awesome/font-awesome.mk +2 -4
index f39401041a..b1026b3c4d 100644
@@ -7,12 +7,10 @@
 FONT_AWESOME_VERSION = v4.7.0
 FONT_AWESOME_SITE = $(call github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION))
 FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files)
-FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss
 
 define FONT_AWESOME_INSTALL_TARGET_CMDS
-	mkdir -p $(TARGET_DIR)/usr/share/font-awesome/
-	$(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\
-		cp -dpfr $(@D)/$(d) $(TARGET_DIR)/usr/share/font-awesome$(sep))
+	mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/
+	cp $(@D)/fonts/FontAwesome.otf $(TARGET_DIR)/usr/share/fonts/font-awesome
 endef
 
 $(eval $(generic-package))
Signature · 1 line
2.19.0
#1 lore raw

PATCH 1/1 font-awesome compatible with fontconfig

Hi Benjamin,

Quoted 14 lines · Benjamin Calderon

This commit installs font-awesome in the standard fonts directory making it available systemwide.

---
 package/font-awesome/font-awesome.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
package/font-awesome/font-awesome.mk +0 -0
index f39401041a..b1026b3c4d 100644
@@ -7,12 +7,10 @@
 FONT_AWESOME_VERSION = v4.7.0

package/font-awesome/font-awesome.mk line 13

Quoted 10 lines
package/font-awesome/font-awesome.mk +2 -4
 FONT_AWESOME_SITE = $(call github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION))
 FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files)
-FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss
 
 define FONT_AWESOME_INSTALL_TARGET_CMDS
-	mkdir -p $(TARGET_DIR)/usr/share/font-awesome/
-	$(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\
-		cp -dpfr $(@D)/$(d) $(TARGET_DIR)/usr/share/font-awesome$(sep))
+	mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/
+	cp $(@D)/fonts/FontAwesome.otf $(TARGET_DIR)/usr/share/fonts/font-awesome

What does this patch fix? What about the fonts in other directories?

package/font-awesome/font-awesome.mk line 16

Quoted 3 lines
package/font-awesome/font-awesome.mk +0 -0
 endef
 
 $(eval $(generic-package))

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 font-awesome compatible with fontconfig

the standard location for fonts is /usr/share/fonts/* and whatever is there can be used by other programs that use fontconfig (Qt5 in my case) This patch fixed the directory where font-awesome is installed from /usr/share/font-awesome to /usr/share/fonts/font-awesome thus it can be accessed by other applications and appears when running fc-list.

I have tested it with Qt5 in rpi3 and with fc-list on qemu_x86_64
____
*Benjam?n C. Calder?n*

Quoted 38 lines · Baruch Siach

Hi Benjamin,

Review

Quoted 9 lines · Benjamin Calderon

This commit installs font-awesome in the standard fonts directory making it available systemwide.

---
 package/font-awesome/font-awesome.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/package/font-awesome/font-awesome.mk

package/font-awesome/font-awesome.mk line 8

Quoted 6 lines

index f39401041a..b1026b3c4d 100644

package/font-awesome/font-awesome.mk +0 -0
@@ -7,12 +7,10 @@
 FONT_AWESOME_VERSION = v4.7.0
 FONT_AWESOME_SITE = $(call

github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION))

package/font-awesome/font-awesome.mk

Quoted 7 lines
package/font-awesome/font-awesome.mk +0 -4
 FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files)
-FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss
 
 define FONT_AWESOME_INSTALL_TARGET_CMDS
-     mkdir -p $(TARGET_DIR)/usr/share/font-awesome/
-     $(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\
-             cp -dpfr $(@D)/$(d)

$(TARGET_DIR)/usr/share/font-awesome$(sep))

package/font-awesome/font-awesome.mk line 13

Quoted 2 lines
package/font-awesome/font-awesome.mk +2 -0
+     mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/
+     cp $(@D)/fonts/FontAwesome.otf

$(TARGET_DIR)/usr/share/fonts/font-awesome

What does this patch fix? What about the fonts in other directories?

package/font-awesome/font-awesome.mk line 16

Quoted 3 lines
package/font-awesome/font-awesome.mk +0 -0
 endef
 
 $(eval $(generic-package))
Quoted 8 lines

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open
Systems =}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180921/f99f4c66/attachment.html>

#3 lore raw

PATCH 1/1 font-awesome compatible with fontconfig

Hi Benjam?n,

Quoted 6 lines · Benjam?n Calder?n

the standard location for fonts is /usr/share/fonts/* and whatever is there can be used by other programs that use fontconfig (Qt5 in my case) This patch fixed the directory where font-awesome is installed from /usr/share/font-awesome to /usr/share/fonts/font-awesome thus it can be accessed by other applications and appears when running fc-list.

Quoted 30 lines

I have tested it with Qt5 in rpi3 and with fc-list on qemu_x86_64

Quoted 27 lines · Baruch Siach

Review

Quoted 9 lines · Benjamin Calderon

This commit installs font-awesome in the standard fonts directory making it available systemwide.

---
 package/font-awesome/font-awesome.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/package/font-awesome/font-awesome.mk

package/font-awesome/font-awesome.mk line 8

Quoted 6 lines

index f39401041a..b1026b3c4d 100644

package/font-awesome/font-awesome.mk +0 -0
@@ -7,12 +7,10 @@
 FONT_AWESOME_VERSION = v4.7.0
 FONT_AWESOME_SITE = $(call

github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION))

package/font-awesome/font-awesome.mk

Quoted 7 lines
package/font-awesome/font-awesome.mk +0 -4
 FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files)
-FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss
 
 define FONT_AWESOME_INSTALL_TARGET_CMDS
-     mkdir -p $(TARGET_DIR)/usr/share/font-awesome/
-     $(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\
-             cp -dpfr $(@D)/$(d)

$(TARGET_DIR)/usr/share/font-awesome$(sep))

Quoted 1 line
package/font-awesome/font-awesome.mk +1 -0
+     mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/

So why do we need this directory? And what about fonts in the directories listed in FONT_AWESOME_DIRECTORIES_LIST? Aren't they useful anymore? If so, please update the license.

baruch

Quoted 8 lines
Quoted 8 lines

package/font-awesome/font-awesome.mk line 13

Quoted 1 line
package/font-awesome/font-awesome.mk +1 -0
+     cp $(@D)/fonts/FontAwesome.otf

$(TARGET_DIR)/usr/share/fonts/font-awesome

What does this patch fix? What about the fonts in other directories?

Quoted 3 lines
package/font-awesome/font-awesome.mk +0 -0
 endef
 
 $(eval $(generic-package))

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

A message that is not in the archive (sent off-list or not yet received): CAOt0XSc31keNicgWfc4jcn=-z43D8Vdb=0SCnVtL4POJz1QzoQ@mail.gmail.com

#5 lore raw

PATCH 1/1 font-awesome compatible with fontconfig

Hi Benjam?n,

Please keep the list on Cc.

Quoted 4 lines · Benjam?n Calder?n

The directory font-awesome inside /usr/share/fonts is just for separation of concerns. That's the practice of other font packages and if we where to upgrade to font-awesome 5 which includes more than one file it would all be contained in one folder.

But this folder is empty after you commit. Why create it?

Quoted 7 lines

The other folders are not necessary because they are actually useless in this context. CSS needs to be in a server root to be used together with HTML pages. Less and scss would need processing and thus are more of "source code" than anything else for web development, again, very unlikely to be used on an embedded system.

Will modify the path to fix the license.

Please also mention the information about the other directories in the commit log.

baruch

Quoted 49 lines · Baruch Siach
Quoted 48 lines

Hi Benjam?n,

Quoted 1 line · Benjam?n Calder?n

the standard location for fonts is /usr/share/fonts/* and whatever is

there

Quoted 5 lines

can be used by other programs that use fontconfig (Qt5 in my case) This patch fixed the directory where font-awesome is installed from /usr/share/font-awesome to /usr/share/fonts/fontawesome thus it can be accessed by other applications and appears when running fc-list.

Quoted 30 lines

I have tested it with Qt5 in rpi3 and with fc-list on qemu_x86_64

Quoted 27 lines · Baruch Siach

Review

Quoted 9 lines · Benjamin Calderon

This commit installs font-awesome in the standard fonts directory making it available systemwide.

---
 package/font-awesome/font-awesome.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/package/font-awesome/font-awesome.mk

package/font-awesome/font-awesome.mk line 8

Quoted 6 lines

index f39401041a..b1026b3c4d 100644

package/font-awesome/font-awesome.mk +0 -0
@@ -7,12 +7,10 @@
 FONT_AWESOME_VERSION = v4.7.0
 FONT_AWESOME_SITE = $(call

github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION))

package/font-awesome/font-awesome.mk

Quoted 7 lines
package/font-awesome/font-awesome.mk +0 -4
 FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files)
-FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss
 
 define FONT_AWESOME_INSTALL_TARGET_CMDS
-     mkdir -p $(TARGET_DIR)/usr/share/font-awesome/
-     $(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\
-             cp -dpfr $(@D)/$(d)

$(TARGET_DIR)/usr/share/font-awesome$(sep))

Quoted 1 line
package/font-awesome/font-awesome.mk +1 -0
+     mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/

So why do we need this directory? And what about fonts in the directories listed in FONT_AWESOME_DIRECTORIES_LIST? Aren't they useful anymore? If so, please update the license.

baruch

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

package/font-awesome/font-awesome.mk line 13

Quoted 1 line
package/font-awesome/font-awesome.mk +1 -0
+     cp $(@D)/fonts/FontAwesome.otf

$(TARGET_DIR)/usr/share/fonts/font-awesome

What does this patch fix? What about the fonts in other directories?

Quoted 3 lines
package/font-awesome/font-awesome.mk +0 -0
 endef
 
 $(eval $(generic-package))

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

#6 lore raw

PATCH 1/1 font-awesome compatible with fontconfig

Baruch, sorry for missing the list. Need to get myself a better email client.

Just noticed what you mentioned about /usr/share/fonts/font-awesome being empty, my mistake.
Will add the information about the other directories in the commit message

Thanks
____
*Benjam?n C. Calder?n*

Quoted 86 lines · Baruch Siach

Hi Benjam?n,

Please keep the list on Cc.

Quoted 2 lines · Benjam?n Calder?n

The directory font-awesome inside /usr/share/fonts is just for separation of concerns. That's the practice of other font packages and if we where

to

Quoted 1 line

upgrade to font-awesome 5 which includes more than one file it would all

be

Quoted 1 line

contained in one folder.

But this folder is empty after you commit. Why create it?

Quoted 4 lines

The other folders are not necessary because they are actually useless in this context. CSS needs to be in a server root to be used together with HTML pages. Less and scss would need processing and thus are more of "source code" than anything else for web development, again, very

unlikely

Quoted 3 lines

to be used on an embedded system.

Will modify the path to fix the license.

Please also mention the information about the other directories in the commit log.

baruch

Quoted 15 lines · Baruch Siach
Quoted 14 lines

Hi Benjam?n,

Quoted 1 line · Benjam?n Calder?n

the standard location for fonts is /usr/share/fonts/* and whatever is

there

Quoted 8 lines

can be used by other programs that use fontconfig (Qt5 in my case) This patch fixed the directory where font-awesome is installed from /usr/share/font-awesome to /usr/share/fonts/fontawesome thus it can be accessed by other applications and appears when running fc-list.

I have tested it with Qt5 in rpi3 and with fc-list on qemu_x86_64

On Thu, Sep 20, 2018 at 11:56 PM Baruch Siach <[email protected]>

Quoted 11 lines · wrote:
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines

Review

Quoted 9 lines · Benjamin Calderon

This commit installs font-awesome in the standard fonts directory making it available systemwide.

---
 package/font-awesome/font-awesome.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/package/font-awesome/font-awesome.mk

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

package/font-awesome/font-awesome.mk line 8

Quoted 6 lines

index f39401041a..b1026b3c4d 100644

package/font-awesome/font-awesome.mk +0 -0
@@ -7,12 +7,10 @@
 FONT_AWESOME_VERSION = v4.7.0
 FONT_AWESOME_SITE = $(call

github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION))

Quoted 1 line
package/font-awesome/font-awesome.mk +0 -0
 FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass

files)

Quoted 22 lines
Quoted 22 lines
Quoted 8 lines
Quoted 8 lines

package/font-awesome/font-awesome.mk

Quoted 6 lines
package/font-awesome/font-awesome.mk +0 -4
-FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss
 
 define FONT_AWESOME_INSTALL_TARGET_CMDS
-     mkdir -p $(TARGET_DIR)/usr/share/font-awesome/
-     $(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\
-             cp -dpfr $(@D)/$(d)

$(TARGET_DIR)/usr/share/font-awesome$(sep))

Quoted 1 line
package/font-awesome/font-awesome.mk +1 -0
+     mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/

So why do we need this directory? And what about fonts in the directories listed in FONT_AWESOME_DIRECTORIES_LIST? Aren't they useful anymore? If so, please update the license.

baruch

Quoted 7 lines
Quoted 7 lines

package/font-awesome/font-awesome.mk line 13

Quoted 1 line
package/font-awesome/font-awesome.mk +1 -0
+     cp $(@D)/fonts/FontAwesome.otf

$(TARGET_DIR)/usr/share/fonts/font-awesome

What does this patch fix? What about the fonts in other directories?

Quoted 2 lines
package/font-awesome/font-awesome.mk +0 -0
 endef
 
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

package/font-awesome/font-awesome.mk line 16

Quoted 1 line
package/font-awesome/font-awesome.mk +0 -0
 $(eval $(generic-package))

--
http://baruch.siach.name/blog/ ~. .~ Tk Open
Systems =}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180921/3ef59117/attachment.html>