i40e: Use proper enum in i40e_ndo_set_vf_link_state
Subsystems (3)
PATCH 1/1 i40e: Use proper enum in i40e_ndo_set_vf_link_state
Clang warns when one enumerated type is converted implicitly to another.
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:4214:42: warning:
implicit conversion from enumeration type 'enum i40e_aq_link_speed' to different enumeration type 'enum virtchnl_link_speed'
[-Wenum-conversion]
pfe.event_data.link_event.link_speed = I40E_LINK_SPEED_40GB;
~ ^~~~~~~~~~~~~~~~~~~~1 warning generated.
Use the proper enum from virtchnl_link_speed, which has the same value as I40E_LINK_SPEED_40GB, VIRTCHNL_LINK_SPEED_40GB. This appears to be missed by commit ff3f4cc267f6 ("virtchnl: finish conversion to virtchnl interface").
--- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +1 -1
@@ -4211,7 +4211,7 @@ int i40e_ndo_set_vf_link_state(struct net_device *netdev, int vf_id, int link) vf->link_forced = true; vf->link_up = true; pfe.event_data.link_event.link_status = true; - pfe.event_data.link_event.link_speed =I40E_LINK_SPEED_40GB ; + pfe.event_data.link_event.link_speed =VIRTCHNL_LINK_SPEED_40GB ;break ;case IFLA_VF_LINK_STATE_DISABLE : vf->link_forced = true;
Signature · 1 line
2.19.0
Bowers
PATCH 1/1 i40e: Use proper enum in i40e_ndo_set_vf_link_state
Quoted 27 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Nathan Chancellor
Sent: Friday, September 21, 2018 3:14 AM
To: Kirsher, Jeffrey T <[email protected]>; David S. Miller <[email protected]>
Cc: netdev at vger.kernel.org; Nathan Chancellor <[email protected]>; intel-wired-lan at lists.osuosl.org; linux- kernel at vger.kernel.org
Subject: [Intel-wired-lan] [PATCH] i40e: Use proper enum ini40e_ndo_set_vf_link_stateClang warns when one enumerated type is converted implicitly to another.
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:4214:42: warning:
implicit conversion from enumeration type 'enumi40e_aq_link_speed' to different enumeration type 'enumvirtchnl_link_speed'[-Wenum-conversion] pfe.event_data.link_event.link_speed = I40E_LINK_SPEED_40GB; ~ ^~~~~~~~~~~~~~~~~~~~1 warning generated.
Use the proper enum from
virtchnl_link_speed, which has the same value asI40E_LINK_SPEED_40GB,VIRTCHNL_LINK_SPEED_40GB. This appears to be missed by commitff3f4cc267f6("virtchnl: finish conversion to virtchnl interface").
Quoted 5 lines
Signed-off-by Nathan Chancellor <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)