SPI-NAND support

setenv mtdparts 'spi-nand0:1m(foo),-(bar)'
setenv mtdids 'spi-nand0=spi0.0' # spi0.0 is Linux MTD name for this device
ubi part bar # create a static UBI volume in the bar partition
mtd list # show the current MTD devices/partitions

cmd/mtd.c new file +37 -0

+
+int mtd_probe_devices(void)
+{
+	const char *mtdparts = env_get("mtdparts");
+	const char *mtdids = env_get("mtdids");
+	bool remaining_partitions = true;
+	struct mtd_info *mtd;
+	int i;
+
+	mtd_probe_uclass_mtd_devs();
+
+	/* Check if mtdparts/mtdids changed since last call, otherwise: exit */
+	if (!strcmp(mtdparts, old_mtdparts) && !strcmp(mtdids, old_mtdids))
+		return CMD_RET_SUCCESS;
+
+	/* Update the local copy of mtdparts */
+	free(old_mtdparts);
+	free(old_mtdids);
+	old_mtdparts = strdup(mtdparts);
+	old_mtdids = strdup(mtdids);
+
+	/* If at least one partition is still in use, do not delete anything */
+	mtd_for_each_device(mtd) {
+		if (mtd->usecount) {
+			printf("Partition \"%s\" already in use, aborting\n",
+			       mtd->name);
+			return CMD_RET_FAILURE;
+		}
+	}
+
+	/*
+	 * Everything looks clear, remove all partitions. It is not safe to
+	 * remove entries from the mtd_for_each_device loop as it uses idr
+	 * indexes and the partitions removal is done in bulk (all partitions of
+	 * one device at the same time), so break and iterate from start each
+	 * time a new partition is found and deleted.
+	 */

cmd/mtd.c new file +43 -0

+
+	/* Start the parsing by ignoring the extra 'mtdparts=' prefix, if any */
+	if (strstr(mtdparts, "mtdparts="))
+		mtdparts += 9;
+
+	/* For each MTD device in mtdparts */
+	while (mtdparts[0] != '\0') {
+		char mtd_name[MTD_NAME_MAX_LEN], *colon;
+		struct mtd_partition *parts;
+		int mtd_name_len, len;
+		int ret;
+
+		colon = strchr(mtdparts, ':');
+		if (!colon) {
+			printf("Wrong mtdparts: %s\n", mtdparts);
+			return CMD_RET_FAILURE;
+		}
+
+		mtd_name_len = colon - mtdparts;
+		strncpy(mtd_name, mtdparts, mtd_name_len);
+		mtd_name[mtd_name_len] = '\0';
+		/* Move the pointer forward (including the ':') */
+		mtdparts += mtd_name_len + 1;
+		mtd = get_mtd_device_nm(mtd_name);
+		if (IS_ERR_OR_NULL(mtd)) {
+			char linux_name[MTD_NAME_MAX_LEN];
+
+			/*
+			 * The MTD device named "mtd_name" does not exist. Try
+			 * to find a correspondance with an MTD device having
+			 * the same type and number as defined in the mtdids.
+			 */
+			debug("No device named %s\n", mtd_name);
+			ret = mtd_search_alternate_name(mtd_name, linux_name,
+							MTD_NAME_MAX_LEN);
+			if (!ret)
+				mtd = get_mtd_device_nm(linux_name);
+
+			/*
+			 * If no device could be found, move the mtdparts
+			 * pointer forward until the next set of partitions.
+			 */
+			if (ret || IS_ERR_OR_NULL(mtd)) {

cmd/mtd.c new file +14 -0

+
+		/*
+		 * Parse the MTD device partitions. It will update the mtdparts
+		 * pointer, create an array of parts (that must be freed), and
+		 * return the number of partition structures in the array.
+		 */
+		ret = mtd_parse_partitions(mtd, &mtdparts, &parts, &len);
+		if (ret) {
+			printf("Could not parse device %s\n", mtd->name);
+			return CMD_RET_FAILURE;
+		}
+
+		if (!len)
+			continue;

Current implementation of mtdparts command errors out if the desired MTD device is not found. Fallback to the new probe function in this case before erroring out.

This will the save the user the need to call something like 'mtd list' before mtdparts.

Signed-off-by Miquel Raynal <[email protected]>

Acked-by Jagan Teki <[email protected]>

Reviewed-by Stefan Roese <[email protected]>

---
 cmd/mtdparts.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

cmd/mtdparts.c +4 -0

index f7ed1a0779..a1102c3fc5 100644
@@ -79,6 +79,10 @@
 #include <linux/err.h>
 #include <linux/mtd/mtd.h>
 
+#if defined(CONFIG_MTD)
+#include <mtd.h>
+#endif
+
 #if defined(CONFIG_CMD_NAND)
 #include <linux/mtd/rawnand.h>
 #include <nand.h>

cmd/mtdparts.c +4 -0

+		if (IS_ERR_OR_NULL(*mtd)) {
+			printf("Device %s not found!\n", mtd_dev);
+			return 1;
+		}
 	}
 	put_mtd_device(*mtd);
 

int ubi_part(char *part_name, const char *vid_header_offset) {

cmd/ubi.c +1 -4

+	struct mtd_info *mtd;
 	int err = 0;
-	char mtd_dev[16];
-	struct mtd_device *dev;
-	struct part_info *part;
-	u8 pnum;
 

The 'mtdparts' command is not needed anymore. While the environment variable is still valid (and useful, along with the 'mtdids' one), the command has been replaced by 'mtd' which is much more close to the MTD stack and do not add its own specific glue.

Signed-off-by Miquel Raynal <[email protected]>

Reviewed-by Stefan Roese <[email protected]>

---
 cmd/Kconfig | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

cmd/Kconfig +0 -0

index f82addca0a..51dd058128 100644

During the last months, Boris Brezillon shared his work to support serial flashes within Linux. First, he delivered (and merged) a new layer called spi-mem. He also initiated in Linux MTD subsystem the move of all 'raw' NAND related code to a raw/ subdirectory, adding at the same time a NAND core that would be shared with all NAND devices. Then, he contributed a generic SPI-NAND driver, making use of this NAND core, as well as some vendor code to drive a few chips.

On top of this work, I made some cleanups in the MTD layer and added an 'mtd' U-Boot command to handle all sort of MTD devices. This should become the default command instead of having one per flash flavor ('sf', 'nand', 'spi-nand' ?).

The series has been tested on an Ocelot board PCB123 (VSC7514), featuring a Macronix SPI NAND chip.

TL;DR: the series contains (stripped version since 23 patches have already been taken):
- Various fixes
- Support for spi-nand devices in mtdparts.
- Generics mtdparts/mtdids parsers.
- A new 'mtd' command.
- A note to set mtdparts command legacy.

To test your SPI-NAND device with U-Boot, you can test someting like:

Quoted 4 lines

setenv mtdparts 'spi-nand0:1m(foo),-(bar)'
setenv mtdids 'spi-nand0=spi0.0' # spi0.0 is Linux MTD name for this device
ubi part bar # create a static UBI volume in the bar partition
mtd list # show the current MTD devices/partitions

Thanks,
Miquèl

Changes since v7:
-----------------
* Added Stefan R-b tags.
* Used tolower() as suggested by Stefan in lib/strto.c.
* Added a mention saying that we continue to abuse the kB suffix in lib/strto.c by not making a difference between kB and kiB which both mean "* 1024" for us. This has been added in the commit log.
* Fixed various bugs in the mtd command and in the parsers, they should be pretty stable now (tested with two MTD devices probed and several different partition configurations).
* mtdids is not deprecated at all as opposed at what I wrote in v6. U-Boot still uses its own MTD names (being <type><idx> like nor0 or spi-nand1) and mtdids is still needed to do the glue.
* Removed a useless patch removing a Kconfig entry I added myself since during a rebase someone else also added this symbol.

Changes since v6:
-----------------
* Squashed Boris' fixes about build issues in Travis.
* Merged Stefan Roese's contributions.
* cmd: mtdparts:
* added fallthrough comments in switch blocks deriving sizes.
* balanced debug messages to compare freed and allocated partitions.
* move mtdparts_init() declaration in mtd/partitions.h to be used in mtd command as well.
* introduced a "compatibility" function to return what the MTD device name could be thanks to the mtdids environment variable (which is useless with the new partitioning logic).
* mtd: mtdpart:
* reworked the way partitions are created/handled.
* cmd: mtd:
* implement a partitioning logic that takes the best out of the MTD layer without re-inventing the wheel. Partitions are all freed correctly when the value of mtdparts changes.
* balance get_mtd_device() by put_mtd_device() calls.
* prevent memory leak by reorganizing the code a bit in do_mtd.
* do not reconstruct partition list when a partition is already in use (complain about that instead).
* add support for the legacy mtdids (not needed anymore if mtdparts directly uses the MTD device names as in Linux.
* cmd: ubi:
* clean and simplify the partition handling a bit to make use the best use of the MTD layer as well and keep the code simple.

Changes since v5:
-----------------
* Included Boris fixup about the build issues.
* Added Rb/Ab tags from Jagan on patchs 20/21.

Changes since v4:
-----------------
* Added Jagan's Acked-by tags to every patch related to the SPI-mem/SPI-NAND addition.
* Rebased on top of master.

Changes since v3:
-----------------
* Fixed the debug messages in spi-mem to print either Rx or Tx data.
* Fixed a Kconfig error that prevented to build mtdparts with plain defconfig.
* Fixed a compilation error due to the above error that prevented one file to be compiled.
* Adapted the mtd command to probe MTD partitions also.
* Declared mtd_probe_devices() in a header so mtdparts or UBI could use it too (to probe all devices and MTD partitions in a clean way).
* As I worked on mtdparts, I found annoying and completely useless the fact that we need to prefix the environment variable with "mtdparts=". Canceled this obligation.
* Added one patch to allow spi-nand devices to be recognized by mtdparts (this is purely useless but needed to be done in order to use this command).
* Removed useless definitions of MTD device types in UBI code.
* Wrote a generic mtdparts environment variable parser, used by the mtd command.
* Used the mtd_probe_devices() function from get_mtd_info() in cmd/mtdparts.c to be sure the desired partition really does not exist (otherwise it will be probed and then found).

Changes since v2:
-----------------
* Rebased on u-boot master branch.
* Removed extra-parenthesis in
"mtd: Fallback to ->_read/write() when ->_read/write_oob() is missing"
* s/fiels/files/ in "mtd: move NAND fiels into a raw/ subdirectory"
* Do not describe generic SPI device properties in SPI NAND bindings.
* Changes in the mtd command:
* Printing more information in 'mtd list' (device type, device characteristics)
* Switch to do_div() instead of '(u32)value64b % value32b' which only worked because value32b was a power of 2.
* Removed erase.chip option.
* By default, erase/read/write happen on the full MTD device while a dump will only work on a single page.

Changes since v1:
-----------------
* Fixed the nand_memorg structure of the MX35LF2GE4AB chip.
* Added Reviewed-by tags from Jagan.
* Backported and squashed two patches fixing things in the SPI NAND core received on the Linux ML.
* Backported more changes in mtdcore.c from Linux.
* Added a patch to add a fallback on mtd->_read/_write() in mtdcore.c when mtd->_read/write_oob() is not supported.
* Removed the DT changes, useless as the DTs are not available in mainline yet.
* Addressed Boris/Stefan comments on the 'mtd' command.
* Added support for multi-pages OOB read/write.

Miquel Raynal (12):
lib: strto: parse all lowercase metric prefixes in ustrtoul[l]
lib: strto: fix metric suffix parsing in strtoul[l]
cmd: mtdparts: accept spi-nand devices
cmd: mtdparts: remove mandatory 'mtdparts=' prefix
mtd: uclass: add probe function
mtd: uclass: add a generic 'mtdparts' parser
mtd: uclass: search for an equivalent MTD name with the mtdids
mtd: mtdpart: implement proper partition handling
cmd: mtd: add 'mtd' command
cmd: mtdparts: try to probe the MTD devices as a fallback
cmd: ubi: clean the partition handling
cmd: mtdparts: describe as legacy

 cmd/Kconfig                    |  18 +-
 cmd/Makefile                   |   1 +
 cmd/mtd.c                      | 521 ++++++++++++++++++++++++++
 cmd/mtdparts.c                 |  46 ++-
 cmd/ubi.c                      | 100 ++---
 drivers/mtd/Makefile           |   2 +-
 drivers/mtd/mtd-uclass.c       |  16 +
 drivers/mtd/mtdcore.c          |   2 +
 drivers/mtd/mtdpart.c          | 660 +++++++++++++++++++++------------
 include/jffs2/load_kernel.h    |   7 +-
 include/linux/mtd/mtd.h        |  31 ++
 include/linux/mtd/partitions.h |   5 +-
 include/mtd.h                  |   3 +
 lib/strto.c                    |  36 +-
 14 files changed, 1094 insertions(+), 354 deletions(-)
 create mode 100644 cmd/mtd.c

Hello,

I failed the numbering, this is actually the v8. The below changelog is still right though. I don't plan to resend unless I am explicitly told to do so.

Sorry for the mistake.

Thanks,
Miquèl

Miquel Raynal <[email protected]> wrote on Thu, 6 Sep 2018 09:08:42 +0200:

Quoted 174 lines

During the last months, Boris Brezillon shared his work to support serial flashes within Linux. First, he delivered (and merged) a new layer called spi-mem. He also initiated in Linux MTD subsystem the move of all 'raw' NAND related code to a raw/ subdirectory, adding at the same time a NAND core that would be shared with all NAND devices. Then, he contributed a generic SPI-NAND driver, making use of this NAND core, as well as some vendor code to drive a few chips.

On top of this work, I made some cleanups in the MTD layer and added an 'mtd' U-Boot command to handle all sort of MTD devices. This should become the default command instead of having one per flash flavor ('sf', 'nand', 'spi-nand' ?).

The series has been tested on an Ocelot board PCB123 (VSC7514), featuring a Macronix SPI NAND chip.

TL;DR: the series contains (stripped version since 23 patches have already been taken):
- Various fixes
- Support for spi-nand devices in mtdparts.
- Generics mtdparts/mtdids parsers.
- A new 'mtd' command.
- A note to set mtdparts command legacy.

To test your SPI-NAND device with U-Boot, you can test someting like:

Quoted 4 lines

setenv mtdparts 'spi-nand0:1m(foo),-(bar)'
setenv mtdids 'spi-nand0=spi0.0' # spi0.0 is Linux MTD name for this device
ubi part bar # create a static UBI volume in the bar partition
mtd list # show the current MTD devices/partitions

Thanks,
Miquèl

Changes since v7:
-----------------
* Added Stefan R-b tags.
* Used tolower() as suggested by Stefan in lib/strto.c.
* Added a mention saying that we continue to abuse the kB suffix in lib/strto.c by not making a difference between kB and kiB which both mean "* 1024" for us. This has been added in the commit log.
* Fixed various bugs in the mtd command and in the parsers, they should be pretty stable now (tested with two MTD devices probed and several different partition configurations).
* mtdids is not deprecated at all as opposed at what I wrote in v6. U-Boot still uses its own MTD names (being <type><idx> like nor0 or spi-nand1) and mtdids is still needed to do the glue.
* Removed a useless patch removing a Kconfig entry I added myself since during a rebase someone else also added this symbol.

Changes since v6:
-----------------
* Squashed Boris' fixes about build issues in Travis.
* Merged Stefan Roese's contributions.
* cmd: mtdparts:
* added fallthrough comments in switch blocks deriving sizes.
* balanced debug messages to compare freed and allocated partitions.
* move mtdparts_init() declaration in mtd/partitions.h to be used in mtd command as well.
* introduced a "compatibility" function to return what the MTD device name could be thanks to the mtdids environment variable (which is useless with the new partitioning logic).
* mtd: mtdpart:
* reworked the way partitions are created/handled.
* cmd: mtd:
* implement a partitioning logic that takes the best out of the MTD layer without re-inventing the wheel. Partitions are all freed correctly when the value of mtdparts changes.
* balance get_mtd_device() by put_mtd_device() calls.
* prevent memory leak by reorganizing the code a bit in do_mtd.
* do not reconstruct partition list when a partition is already in use (complain about that instead).
* add support for the legacy mtdids (not needed anymore if mtdparts directly uses the MTD device names as in Linux.
* cmd: ubi:
* clean and simplify the partition handling a bit to make use the best use of the MTD layer as well and keep the code simple.

Changes since v5:
-----------------
* Included Boris fixup about the build issues.
* Added Rb/Ab tags from Jagan on patchs 20/21.

Changes since v4:
-----------------
* Added Jagan's Acked-by tags to every patch related to the SPI-mem/SPI-NAND addition.
* Rebased on top of master.

Changes since v3:
-----------------
* Fixed the debug messages in spi-mem to print either Rx or Tx data.
* Fixed a Kconfig error that prevented to build mtdparts with plain defconfig.
* Fixed a compilation error due to the above error that prevented one file to be compiled.
* Adapted the mtd command to probe MTD partitions also.
* Declared mtd_probe_devices() in a header so mtdparts or UBI could use it too (to probe all devices and MTD partitions in a clean way).
* As I worked on mtdparts, I found annoying and completely useless the fact that we need to prefix the environment variable with "mtdparts=". Canceled this obligation.
* Added one patch to allow spi-nand devices to be recognized by mtdparts (this is purely useless but needed to be done in order to use this command).
* Removed useless definitions of MTD device types in UBI code.
* Wrote a generic mtdparts environment variable parser, used by the mtd command.
* Used the mtd_probe_devices() function from get_mtd_info() in cmd/mtdparts.c to be sure the desired partition really does not exist (otherwise it will be probed and then found).

Changes since v2:
-----------------
* Rebased on u-boot master branch.
* Removed extra-parenthesis in
"mtd: Fallback to ->_read/write() when ->_read/write_oob() is missing"
* s/fiels/files/ in "mtd: move NAND fiels into a raw/ subdirectory"
* Do not describe generic SPI device properties in SPI NAND bindings.
* Changes in the mtd command:
* Printing more information in 'mtd list' (device type, device characteristics)
* Switch to do_div() instead of '(u32)value64b % value32b' which only worked because value32b was a power of 2.
* Removed erase.chip option.
* By default, erase/read/write happen on the full MTD device while a dump will only work on a single page.

Changes since v1:
-----------------
* Fixed the nand_memorg structure of the MX35LF2GE4AB chip.
* Added Reviewed-by tags from Jagan.
* Backported and squashed two patches fixing things in the SPI NAND core received on the Linux ML.
* Backported more changes in mtdcore.c from Linux.
* Added a patch to add a fallback on mtd->_read/_write() in mtdcore.c when mtd->_read/write_oob() is not supported.
* Removed the DT changes, useless as the DTs are not available in mainline yet.
* Addressed Boris/Stefan comments on the 'mtd' command.
* Added support for multi-pages OOB read/write.

Miquel Raynal (12):
lib: strto: parse all lowercase metric prefixes in ustrtoul[l]
lib: strto: fix metric suffix parsing in strtoul[l]
cmd: mtdparts: accept spi-nand devices
cmd: mtdparts: remove mandatory 'mtdparts=' prefix
mtd: uclass: add probe function
mtd: uclass: add a generic 'mtdparts' parser
mtd: uclass: search for an equivalent MTD name with the mtdids
mtd: mtdpart: implement proper partition handling
cmd: mtd: add 'mtd' command
cmd: mtdparts: try to probe the MTD devices as a fallback
cmd: ubi: clean the partition handling
cmd: mtdparts: describe as legacy

  cmd/Kconfig                    |  18 +-
  cmd/Makefile                   |   1 +
  cmd/mtd.c                      | 521 ++++++++++++++++++++++++++
  cmd/mtdparts.c                 |  46 ++-
  cmd/ubi.c                      | 100 ++---
  drivers/mtd/Makefile           |   2 +-
  drivers/mtd/mtd-uclass.c       |  16 +
  drivers/mtd/mtdcore.c          |   2 +
  drivers/mtd/mtdpart.c          | 660 +++++++++++++++++++++------------
  include/jffs2/load_kernel.h    |   7 +-
  include/linux/mtd/mtd.h        |  31 ++
  include/linux/mtd/partitions.h |   5 +-
  include/mtd.h                  |   3 +
  lib/strto.c                    |  36 +-
  14 files changed, 1094 insertions(+), 354 deletions(-)

create mode 100644 cmd/mtd.c

Hi Jagan,

I just wanted to ask about the timeline for the SPI-NAND patches. I remember that Tom wanted to have them in 2018.11. Is this going to happen or is there anything preventing this?

Quoted 5 lines · Frieder Schrempf

Hi Jagan,

I just wanted to ask about the timeline for the SPI-NAND patches. I remember that Tom wanted to have them in 2018.11. Is this going to happen or is there anything preventing this?

Travis[1] for combination of earlier series + this. Will send PR soon I get the results.

Miquel, Let me know if anything miss here?

[1] https://travis-ci.org/openedev/u-boot-amarula/builds/431062285

Hi Jagan, Frieder,

Jagan Teki <[email protected]> wrote on Thu, 20 Sep 2018 20:16:06 +0530:

Quoted 8 lines

Quoted 5 lines · Frieder Schrempf

Hi Jagan,

I just wanted to ask about the timeline for the SPI-NAND patches. I remember that Tom wanted to have them in 2018.11. Is this going to happen or is there anything preventing this?

Quoted 6 lines

Travis[1] for combination of earlier series + this. Will send PR soon I get the results.

Miquel, Let me know if anything miss here?

[1] https://travis-ci.org/openedev/u-boot-amarula/builds/431062285

You can definitely take the earlier series, they are fine and work on their own. About this one, the four first patches are fine and won't be changed, please keep them:
lib: strto: parse all lowercase metric prefixes in ustrtoul[l]
lib: strto: fix metric suffix parsing in strtoul[l]
cmd: mtdparts: accept spi-nand devices
cmd: mtdparts: remove mandatory 'mtdparts=' prefix

For the rest, as pointed by Boris, it would break UBI for certain users so I want to make a last version (mostly code moves) next week to fit it. I will resend a v9 only for patches:
mtd: uclass: add probe function
mtd: uclass: add a generic 'mtdparts' parser
mtd: uclass: search for an equivalent MTD name with the mtdids
mtd: mtdpart: implement proper partition handling
cmd: mtd: add 'mtd' command
cmd: mtdparts: try to probe the MTD devices as a fallback
cmd: ubi: clean the partition handling
cmd: mtdparts: describe as legacy

2018.11 is definitely the target.

Thanks,
Miquèl

Hi Jagan, Frieder,

Jagan Teki <[email protected]> wrote on Thu, 20 Sep 2018 20:16:06 +0530:

Quoted 8 lines

Quoted 5 lines · Frieder Schrempf

Hi Jagan,

I just wanted to ask about the timeline for the SPI-NAND patches. I remember that Tom wanted to have them in 2018.11. Is this going to happen or is there anything preventing this?

Quoted 6 lines

Travis[1] for combination of earlier series + this. Will send PR soon I get the results.

Miquel, Let me know if anything miss here?

[1] https://travis-ci.org/openedev/u-boot-amarula/builds/431062285

You can definitely take the earlier series, they are fine and work on their own. About this one, the four first patches are fine and won't be changed, please keep them:
lib: strto: parse all lowercase metric prefixes in ustrtoul[l]
lib: strto: fix metric suffix parsing in strtoul[l]
cmd: mtdparts: accept spi-nand devices
cmd: mtdparts: remove mandatory 'mtdparts=' prefix

Quoted 21 lines

Hi Jagan, Frieder,

Jagan Teki <[email protected]> wrote on Thu, 20 Sep 2018 20:16:06 +0530:

Quoted 8 lines

Quoted 5 lines · Frieder Schrempf

Hi Jagan,

I just wanted to ask about the timeline for the SPI-NAND patches. I remember that Tom wanted to have them in 2018.11. Is this going to happen or is there anything preventing this?

Quoted 6 lines

Travis[1] for combination of earlier series + this. Will send PR soon I get the results.

Miquel, Let me know if anything miss here?

[1] https://travis-ci.org/openedev/u-boot-amarula/builds/431062285

Quoted 7 lines

You can definitely take the earlier series, they are fine and work on their own. About this one, the four first patches are fine and won't be changed, please keep them:
lib: strto: parse all lowercase metric prefixes in ustrtoul[l]
lib: strto: fix metric suffix parsing in strtoul[l]
cmd: mtdparts: accept spi-nand devices
cmd: mtdparts: remove mandatory 'mtdparts=' prefix

I shall pick upto this and wait for v8 to send PR together.

Quoted 21 lines

Hi Jagan, Frieder,

Jagan Teki <[email protected]> wrote on Thu, 20 Sep 2018 20:16:06 +0530:

Quoted 8 lines

Quoted 5 lines · Frieder Schrempf

Hi Jagan,

I just wanted to ask about the timeline for the SPI-NAND patches. I remember that Tom wanted to have them in 2018.11. Is this going to happen or is there anything preventing this?

Quoted 6 lines

Travis[1] for combination of earlier series + this. Will send PR soon I get the results.

Miquel, Let me know if anything miss here?

[1] https://travis-ci.org/openedev/u-boot-amarula/builds/431062285

Quoted 7 lines

You can definitely take the earlier series, they are fine and work on their own. About this one, the four first patches are fine and won't be changed, please keep them:
lib: strto: parse all lowercase metric prefixes in ustrtoul[l]
lib: strto: fix metric suffix parsing in strtoul[l]
cmd: mtdparts: accept spi-nand devices
cmd: mtdparts: remove mandatory 'mtdparts=' prefix

I shall pick upto this and wait for v8 to send PR together.